summary refs log tree commit diff stats
path: root/testament
diff options
context:
space:
mode:
authormetagn <metagngn@gmail.com>2024-09-18 18:37:18 +0300
committerGitHub <noreply@github.com>2024-09-18 17:37:18 +0200
commit1660ddf98a6b6fbd8f05b58bbc540bc57523b31c (patch)
treedfda6350da1aee487a9d7eba1754b87ebd33edd5 /testament
parentc759d7abd1b4181fb4931bc95148beac3051bf91 (diff)
downloadNim-1660ddf98a6b6fbd8f05b58bbc540bc57523b31c.tar.gz
make `var`/pointer types not match if base type has to be converted (#24130)
split again from #24038, fixes
https://github.com/status-im/nimbus-eth2/pull/6554#issuecomment-2354977102

`var`/pointer types are no longer implicitly convertible to each other
if their element types either:

* require an int conversion or another conversion operation as long as
it's not to `openarray`,
* are subtypes with pointer indirection,

Previously any conversion below a subrange match would match if the
element type wasn't a pointer type, then it would error later in
`analyseIfAddressTaken`.

Different from #24038 in that the preview define that made subrange
matches also fail to match is removed for a simpler diff so that it can
be backported.
Diffstat (limited to 'testament')
-rw-r--r--testament/important_packages.nim2
1 files changed, 1 insertions, 1 deletions
diff --git a/testament/important_packages.nim b/testament/important_packages.nim
index efec04b3c..af8c6b888 100644
--- a/testament/important_packages.nim
+++ b/testament/important_packages.nim
@@ -162,7 +162,7 @@ pkg "ssostrings"
 pkg "stew"
 pkg "stint", "nim c stint.nim"
 pkg "strslice"
-pkg "strunicode", "nim c -r --mm:refc src/strunicode.nim"
+pkg "strunicode", "nimble uninstall -i -y normalize; nimble install -y normalize@#HEAD; nimble install --depsOnly -y; nim c -r --mm:refc src/strunicode.nim"
 pkg "supersnappy"
 pkg "synthesis"
 pkg "taskpools"