diff options
| author | ringabout <43030857+ringabout@users.noreply.github.com> | 2024-01-26 15:04:16 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-26 08:04:16 +0100 |
| commit | 24a606902a4e99ac3d7f58b89db3b023061bc8b0 (patch) | |
| tree | a202199ec969eeee8873ec9758492d0c5ff84666 /tests/iter/titervaropenarray.nim | |
| parent | 243f1e6cd5e147fdd96b5298e4df44546e5eea28 (diff) | |
| download | Nim-24a606902a4e99ac3d7f58b89db3b023061bc8b0.tar.gz | |
fixes #23247; don't destroy openarray since it doesn't own the data (#23254)
fixes #23247 closes #23251 (which accounts for why the openarray type is lifted because ops are lifted for openarray conversions) related: https://github.com/nim-lang/Nim/pull/18713 It seems to me that openarray doesn't own the data, so it cannot destroy itself. The same case should be applied to https://github.com/nim-lang/Nim/issues/19435. It shouldn't be destroyed even openarray can have a destructor. A cleanup will be followed for https://github.com/nim-lang/Nim/pull/19723 if it makes sense. According to https://github.com/nim-lang/Nim/pull/12073, it lifts destructor for openarray when openarray is sunk into the function, when means `sink openarray` owns the data and needs to destroy it. In other cases, destructor shouldn't be lifted for `openarray` in the first place and it shouldn't destroy the data if it doesn't own it. --------- Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
Diffstat (limited to 'tests/iter/titervaropenarray.nim')
0 files changed, 0 insertions, 0 deletions