diff options
| author | Jacek Sieka <arnetheduck@gmail.com> | 2020-04-28 19:56:01 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-28 19:56:01 +0200 |
| commit | 7d6cbf290a5e0cbce14b9926f57221a017f20a4a (patch) | |
| tree | f8bf7d55e271571ebbb817ff28858c29e712382b /tests/js | |
| parent | cd9af6b8040bc72985d457e5169e18ded7c107d6 (diff) | |
| download | Nim-7d6cbf290a5e0cbce14b9926f57221a017f20a4a.tar.gz | |
Error -> Defect for defects (#13908)
* Error -> Defect for defects The distinction between Error and Defect is subjective, context-dependent and somewhat arbitrary, so when looking at an exception, it's hard to guess what it is - this happens often when looking at a `raises` list _without_ opening the corresponding definition and digging through layers of inheritance. With the help of a little consistency in naming, it's at least possible to start disentangling the two error types and the standard lib can set a good example here.
Diffstat (limited to 'tests/js')
| -rw-r--r-- | tests/js/temptyseq.nim | 2 | ||||
| -rw-r--r-- | tests/js/tfieldchecks.nim | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/tests/js/temptyseq.nim b/tests/js/temptyseq.nim index df4b3e8da..6489cf817 100644 --- a/tests/js/temptyseq.nim +++ b/tests/js/temptyseq.nim @@ -2,7 +2,7 @@ proc foo = var x: seq[int] - doAssertRaises(IndexError): + doAssertRaises(IndexDefect): inc x[0] foo() diff --git a/tests/js/tfieldchecks.nim b/tests/js/tfieldchecks.nim index 77759a75a..3916cae74 100644 --- a/tests/js/tfieldchecks.nim +++ b/tests/js/tfieldchecks.nim @@ -24,7 +24,7 @@ var obj = X(f0: "foo", f1: C, f3: 3.14) block: echo obj.f0 echo obj.f1 - doAssertRaises(FieldError): echo obj.f2 + doAssertRaises(FieldDefect): echo obj.f2 echo obj.f3 block: @@ -32,7 +32,7 @@ block: echo a0[] # let a1 = unsafeAddr(obj.f1) # echo a1[] - doAssertRaises(FieldError): + doAssertRaises(FieldDefect): let a2 = addr(obj.f2) echo a2[] let a3 = addr(obj.f3) |