diff options
| author | Jacek Sieka <arnetheduck@gmail.com> | 2020-04-28 19:56:01 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-28 19:56:01 +0200 |
| commit | 7d6cbf290a5e0cbce14b9926f57221a017f20a4a (patch) | |
| tree | f8bf7d55e271571ebbb817ff28858c29e712382b /tests/overflw | |
| parent | cd9af6b8040bc72985d457e5169e18ded7c107d6 (diff) | |
| download | Nim-7d6cbf290a5e0cbce14b9926f57221a017f20a4a.tar.gz | |
Error -> Defect for defects (#13908)
* Error -> Defect for defects The distinction between Error and Defect is subjective, context-dependent and somewhat arbitrary, so when looking at an exception, it's hard to guess what it is - this happens often when looking at a `raises` list _without_ opening the corresponding definition and digging through layers of inheritance. With the help of a little consistency in naming, it's at least possible to start disentangling the two error types and the standard lib can set a good example here.
Diffstat (limited to 'tests/overflw')
| -rw-r--r-- | tests/overflw/toverflw.nim | 8 | ||||
| -rw-r--r-- | tests/overflw/toverflw2.nim | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/tests/overflw/toverflw.nim b/tests/overflw/toverflw.nim index d96231900..164e16e5c 100644 --- a/tests/overflw/toverflw.nim +++ b/tests/overflw/toverflw.nim @@ -13,7 +13,7 @@ var try: writeLine(stdout, b - a) -except OverflowError: +except OverflowDefect: overflowDetected = true {.pop.} # overflow check @@ -33,7 +33,7 @@ block: # Overflow checks in a proc try: foo() - except OverflowError: + except OverflowDefect: overflowDetected = true doAssert(overflowDetected) @@ -53,7 +53,7 @@ block: # Overflow checks in a forward declared proc try: foo() - except OverflowError: + except OverflowDefect: overflowDetected = true doAssert(overflowDetected) @@ -73,7 +73,7 @@ block: # Overflow checks doesn't affect fwd declaration try: foo() - except OverflowError: + except OverflowDefect: overflowDetected = true doAssert(not overflowDetected) diff --git a/tests/overflw/toverflw2.nim b/tests/overflw/toverflw2.nim index 91b900ca4..c06b35c6d 100644 --- a/tests/overflw/toverflw2.nim +++ b/tests/overflw/toverflw2.nim @@ -1,5 +1,5 @@ discard """ - outputsub: "Error: unhandled exception: over- or underflow [OverflowError]" + outputsub: "Error: unhandled exception: over- or underflow [OverflowDefect]" exitcode: "1" """ var a : int32 = 2147483647 |