diff options
| author | Jacek Sieka <arnetheduck@gmail.com> | 2020-04-28 19:56:01 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-28 19:56:01 +0200 |
| commit | 7d6cbf290a5e0cbce14b9926f57221a017f20a4a (patch) | |
| tree | f8bf7d55e271571ebbb817ff28858c29e712382b /tests/stdlib/nre | |
| parent | cd9af6b8040bc72985d457e5169e18ded7c107d6 (diff) | |
| download | Nim-7d6cbf290a5e0cbce14b9926f57221a017f20a4a.tar.gz | |
Error -> Defect for defects (#13908)
* Error -> Defect for defects The distinction between Error and Defect is subjective, context-dependent and somewhat arbitrary, so when looking at an exception, it's hard to guess what it is - this happens often when looking at a `raises` list _without_ opening the corresponding definition and digging through layers of inheritance. With the help of a little consistency in naming, it's at least possible to start disentangling the two error types and the standard lib can set a good example here.
Diffstat (limited to 'tests/stdlib/nre')
| -rw-r--r-- | tests/stdlib/nre/replace.nim | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/stdlib/nre/replace.nim b/tests/stdlib/nre/replace.nim index 812a7f384..6f3436410 100644 --- a/tests/stdlib/nre/replace.nim +++ b/tests/stdlib/nre/replace.nim @@ -16,7 +16,7 @@ suite "replace": check("123".replace(re"(?<foo>\d)(\d)", "${foo}$#$#") == "1123") test "replacing missing captures should throw instead of segfaulting": - expect IndexError: discard "ab".replace(re"(a)|(b)", "$1$2") - expect IndexError: discard "b".replace(re"(a)?(b)", "$1$2") + expect IndexDefect: discard "ab".replace(re"(a)|(b)", "$1$2") + expect IndexDefect: discard "b".replace(re"(a)?(b)", "$1$2") expect KeyError: discard "b".replace(re"(a)?", "${foo}") expect KeyError: discard "b".replace(re"(?<foo>a)?", "${foo}") |