diff options
| author | metagn <metagngn@gmail.com> | 2023-05-09 16:37:32 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-09 21:37:32 +0800 |
| commit | 5491e0c27419c13a0566ab3ed99ebeedccaf9a5c (patch) | |
| tree | 818653c763f961d7348434650e9296ea354a5ffa /tests | |
| parent | 4ee70165f1f0646df34ae35b7c98bd8b7d1d6d5d (diff) | |
| download | Nim-5491e0c27419c13a0566ab3ed99ebeedccaf9a5c.tar.gz | |
re-enable badssl test (#21775)
test reenable badssl
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/untestable/thttpclient_ssl_remotenetwork.nim | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/untestable/thttpclient_ssl_remotenetwork.nim b/tests/untestable/thttpclient_ssl_remotenetwork.nim index 65f7cc8d6..3cb759516 100644 --- a/tests/untestable/thttpclient_ssl_remotenetwork.nim +++ b/tests/untestable/thttpclient_ssl_remotenetwork.nim @@ -32,8 +32,8 @@ when enableRemoteNetworking and (defined(nimTestsEnableFlaky) or not defined(win good, bad, dubious, good_broken, bad_broken, dubious_broken CertTest = tuple[url:string, category:Category, desc: string] - # XXX re-enable when badssl fixes certs, some expired as of 2023-04-23 (#21709) - when false: + # badssl certs sometimes expire, set to false when that happens + when true: const certificate_tests: array[0..54, CertTest] = [ ("https://wrong.host.badssl.com/", bad, "wrong.host"), ("https://captive-portal.badssl.com/", bad, "captive-portal"), @@ -196,8 +196,8 @@ when enableRemoteNetworking and (defined(nimTestsEnableFlaky) or not defined(win type NetSocketTest = tuple[hostname: string, port: Port, category:Category, desc: string] - # XXX re-enable when badssl fixes certs, some expired as of 2023-04-23 (#21709) - when false: + # badssl certs sometimes expire, set to false when that happens + when true: const net_tests:array[0..3, NetSocketTest] = [ ("imap.gmail.com", 993.Port, good, "IMAP"), ("wrong.host.badssl.com", 443.Port, bad, "wrong.host"), |