summary refs log tree commit diff stats
path: root/web
diff options
context:
space:
mode:
authorZahary Karadjov <zahary@gmail.com>2017-04-28 19:09:11 +0300
committerZahary Karadjov <zahary@gmail.com>2017-04-28 19:09:11 +0300
commit9107e551f1a617d5c3d0c3dfef44c91422a1dd07 (patch)
tree19ac68abd94c4c6c2c3125ac7336aaa5b6e4533b /web
parentfa52cff82666cc404e71acdc967444a8d9fab31c (diff)
downloadNim-9107e551f1a617d5c3d0c3dfef44c91422a1dd07.tar.gz
close #5726
Turned out that the old code was wrong. I'm not sure why it used to work.

`response.body` properly resolves to an async proc defined in the httpclient
module with the following signature:

proc body*(response: AsyncResponse): Future[string] {.async.}

Perhaps the old code was somehow matching the body field of the `AsyncResponse`
object, which is marked as private.
Diffstat (limited to 'web')
-rw-r--r--web/bountysource.nim6
1 files changed, 4 insertions, 2 deletions
diff --git a/web/bountysource.nim b/web/bountysource.nim
index 1d47cea56..8d4f36bf0 100644
--- a/web/bountysource.nim
+++ b/web/bountysource.nim
@@ -29,17 +29,19 @@ proc newBountySource(team, token: string): BountySource =
   result.client.headers["Referer"] = "https://salt.bountysource.com/teams/nim/admin/supporters"
   result.client.headers["Origin"] = "https://salt.bountysource.com/"
 
+import typetraits
+
 proc getSupporters(self: BountySource): Future[JsonNode] {.async.} =
   let response = await self.client.get(apiUrl &
     "/supporters?order=monthly&per_page=200&team_slug=" & self.team)
   doAssert response.status.startsWith($Http200)
-  return parseJson(response.body)
+  return parseJson(await response.body)
 
 proc getGithubUser(username: string): Future[JsonNode] {.async.} =
   let client = newAsyncHttpClient()
   let response = await client.get(githubApiUrl & "/users/" & username)
   if response.status.startsWith($Http200):
-    return parseJson(response.body)
+    return parseJson(await response.body)
   else:
     echo("Could not get Github user: ", username, ". ", response.status)
     return nil