diff options
| -rw-r--r-- | compiler/lineinfos.nim | 4 | ||||
| -rw-r--r-- | compiler/options.nim | 2 | ||||
| -rw-r--r-- | compiler/semexprs.nim | 3 |
3 files changed, 7 insertions, 2 deletions
diff --git a/compiler/lineinfos.nim b/compiler/lineinfos.nim index c7057e7db..27d7b32e0 100644 --- a/compiler/lineinfos.nim +++ b/compiler/lineinfos.nim @@ -60,6 +60,7 @@ type warnInconsistentSpacing = "Spacing", warnCaseTransition = "CaseTransition", warnCycleCreated = "CycleCreated", warnObservableStores = "ObservableStores", warnStrictNotNil = "StrictNotNil", + warnResultUsed = "ResultUsed", warnCannotOpen = "CannotOpen", warnFileChanged = "FileChanged", warnUser = "User", @@ -138,6 +139,7 @@ const warnCycleCreated: "$1", warnObservableStores: "observable stores to '$1'", warnStrictNotNil: "$1", + warnResultUsed: "used 'result' variable", warnCannotOpen: "cannot open: $1", warnFileChanged: "file changed: $1", warnUser: "$1", @@ -193,7 +195,7 @@ type TNoteKinds* = set[TNoteKind] proc computeNotesVerbosity(): array[0..3, TNoteKinds] = - result[3] = {low(TNoteKind)..high(TNoteKind)} - {warnObservableStores} + result[3] = {low(TNoteKind)..high(TNoteKind)} - {warnObservableStores, warnResultUsed} result[2] = result[3] - {hintStackTrace, warnUninit, hintExtendedContext, hintDeclaredLoc} result[1] = result[2] - {warnProveField, warnProveIndex, warnGcUnsafe, hintPath, hintDependency, hintCodeBegin, hintCodeEnd, diff --git a/compiler/options.nim b/compiler/options.nim index 931458cb0..10d8f5c32 100644 --- a/compiler/options.nim +++ b/compiler/options.nim @@ -402,7 +402,7 @@ proc hasHint*(conf: ConfigRef, note: TNoteKind): bool = note in conf.mainPackageNotes else: note in conf.notes -proc hasWarn*(conf: ConfigRef, note: TNoteKind): bool = +proc hasWarn*(conf: ConfigRef, note: TNoteKind): bool {.inline.} = optWarns in conf.options and note in conf.notes proc hcrOn*(conf: ConfigRef): bool = return optHotCodeReloading in conf.globalOptions diff --git a/compiler/semexprs.nim b/compiler/semexprs.nim index cf8d4777f..8c4f25e12 100644 --- a/compiler/semexprs.nim +++ b/compiler/semexprs.nim @@ -1246,6 +1246,9 @@ proc semSym(c: PContext, n: PNode, sym: PSym, flags: TExprFlags): PNode = # not sure the symbol really ends up being used: # var len = 0 # but won't be called # genericThatUsesLen(x) # marked as taking a closure? + if hasWarn(c.config, warnResultUsed): + message(c.config, n.info, warnResultUsed) + of skGenericParam: onUse(n.info, s) if s.typ.kind == tyStatic: |