| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | fix wrong subtype relation in tuples & infer some conversions (#23228) | metagn | 2024-01-18 | 2 | -0/+34 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes #18125 Previously a tuple type like `(T, int)` would match an expected tuple type `(U, int)` if `T` is a subtype of `U`. This is wrong since the codegen does not handle type conversions of individual tuple elements in a type conversion of an entire tuple. For this reason the compiler already does not accept `(float, int)` for a matched type `(int, int)`, however the code that checked for which relations are unacceptable checked for `< isSubtype` rather than `<= isSubtype`, so subtypes were not included in the unacceptable relations. Update: Now only considered unacceptable when inheritance is used, as in [`paramTypesMatch`](https://github.com/nim-lang/Nim/blob/3379d26629f30e6be8d303a36e220d1039eb4551/compiler/sigmatch.nim#L2252-L2254). Ideally subtype relations that don't need conversions, like `nil`, `seq[empty]`, `range[0..5]` etc would be their own relation `isConcreteSubtype` (which would also allow us to differentiate with `openArray[T]`), but this is too big of a refactor for now. To compensate for this making things like `let x: (Parent, int) = (Child(), 0)` not compile (they would crash codegen before anyway but should still work in principle), type inference for tuple constructors is updated such that they call `fitNode` on the fields and their expected types, so a type conversion is generated for the individual subtype element. | ||||
| * | round out tuple unpacking assignment, support underscores (#22537) | metagn | 2023-08-24 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | * round out tuple unpacking assignment, support underscores fixes #18710 * fix test messages * use discard instead of continue Co-authored-by: Andreas Rumpf <rumpf_a@web.de> --------- Co-authored-by: Andreas Rumpf <rumpf_a@web.de> | ||||
| * | fixes #22049; fixes #22054; implicit conversion keeps varness (#22097) | ringabout | 2023-06-16 | 1 | -0/+26 |
| | | | | | | | | | | | | | | | | | | | | | | * fixes #22054; codegen for var tuples conv * rethink fixes * add test cases * templates only * fixes var tuples * keep varness no matter what * fixes typ.isNil * make it work for generics * restore isSubrange * add a test case as requested | ||||
| * | tuple unpacking for vars as just sugar, allowing nesting (#21563) | metagn | 2023-03-28 | 2 | -0/+12 |
| | | | | | | | | | | | | | | | | | | | | * tuple unpacking for vars as just sugar, allowing nesting * set temp symbol AST * hopeful fix some issues, add test for #19364 * always use temp for consts * document, fix small issue * fix manual indentation * actually fix manual * use helper proc * don't resem temp tuple assignment | ||||
| * | closes #16331; add testcase (#20730) | ringabout | 2022-11-02 | 1 | -0/+12 |
| | | |||||
| * | style usages part one (openarray => openArray) (#19321) | flywind | 2022-01-04 | 1 | -2/+2 |
| | | | | | | * style usages (openArray) * revert doc changes | ||||
| * | Fixed const tuples in inferred generics (#18598) | Jason Beetham | 2021-07-27 | 1 | -0/+14 |
| | | |||||
| * | close #7012 add testcase (#17537) | flywind | 2021-03-27 | 1 | -0/+7 |
| | | |||||
| * | tests/tuples/ttuples_issues.nim: test on all backends + various improvements ↵ | Timothee Cour | 2021-02-02 | 1 | -81/+118 |
| | | | | | | | | (#16907) * improve tests/tuples/ttuples_issues.nim: test on all backends * address comments | ||||
| * | cleanup old codes (#16173) | flywind | 2020-11-30 | 1 | -9/+2 |
| | | |||||
| * | Fix #14911 (#14922) [backport] | Clyybber | 2020-07-07 | 1 | -1/+8 |
| | | | | | | | | * Fix #14911 * Add testcase * Fix test | ||||
| * | fixes #14112, tests for #12892, #12671, #11697 (#14125) | hlaaftana | 2020-04-26 | 1 | -0/+8 |
| | | |||||
| * | fix several typos in documentation and comments (#12553) | Nindaleth | 2019-10-30 | 1 | -2/+2 |
| | | |||||
| * | Fix spellings (#12277) [backport] | Federico Ceratto | 2019-09-27 | 1 | -2/+2 |
| | | |||||
| * | Tuple error message (#11141); fixes #3211 | Arne Döring | 2019-05-15 | 2 | -0/+10 |
| | | |||||
| * | Merge pull request #11159 from JasperJenkins/const-named-tuple-unpack | Andreas Rumpf | 2019-05-08 | 2 | -1/+21 |
| |\ | | | | | Const named tuple unpacking | ||||
| | * | enable t9177. | Jasper Jenkins | 2019-05-01 | 1 | -1/+0 |
| | | | |||||
| | * | const named tuple unpacking | Jasper Jenkins | 2019-05-01 | 1 | -0/+21 |
| | | | |||||
| * | | Fix loop tuple unpacking in templates (#11174) | nc-x | 2019-05-05 | 1 | -0/+9 |
| |/ | | | | | | * Fix loop tuple unpacking in templates * Add test | ||||
| * | Fixes #10727. (#10728) | deech | 2019-02-25 | 1 | -1/+5 |
| | | |||||
| * | Tuple unpacking now works for `for` vars (#10152) | Neelesh Chandola | 2019-02-23 | 1 | -0/+39 |
| | | | | | | | | | * Tuple unpacking now works for `for` vars * Give error if length of tuple vars != length of tuple * Fix error message showing wrong tuple length * unpacking now works now for mutable items * Update changelog | ||||
| * | make tests green again | Andreas Rumpf | 2019-02-08 | 1 | -0/+1 |
| | | |||||
| * | Fix wrong result in tuple assignment (#9340) | LemonBoy | 2019-02-08 | 1 | -0/+15 |
| | | | | Fixes #9177 | ||||
| * | remove deprecated modules (#10215) | Miran | 2019-01-07 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | * removed from `compiler`: * lists (deprecated 2 years ago) * removed from `lib` (all deprecated 3 years ago): * ssl * matchers * httpserver * removed from `lib/deprecated`: * unsigned * actors (and three accompanying tests) * parseurl * moved to `lib/deprecated`: * securehash (the reason for not directly removing - it was deprecated (only) one year ago) | ||||
| * | Const tuple unpacking: add tests (#10100) | ee7 | 2018-12-27 | 1 | -0/+16 |
| | | |||||
| * | lots of small changes | Arne Döring | 2018-12-11 | 1 | -1/+1 |
| | | |||||
| * | require errormsg to be specified before file. | Arne Döring | 2018-12-11 | 1 | -2/+1 |
| | | |||||
| * | Merge tests into a larger file (part 8 of ∞) (#9583) | Miran | 2018-11-06 | 11 | -214/+213 |
| | | | | | | | | | * merge tuple tests * merge trmacros tests * merge template tests | ||||
| * | fixes more nil handling regressions | Araq | 2018-08-13 | 2 | -14/+14 |
| | | |||||
| * | rename SomeReal to SomeFloat (#7617) | Arne Döring | 2018-04-15 | 1 | -4/+4 |
| | | | | | | * rename SomeReal to SomeFloat * added changelog entry | ||||
| * | introduce nkTupleConstr AST node for unary tuple construction; breaking change | Andreas Rumpf | 2018-04-13 | 1 | -1/+13 |
| | | |||||
| * | make tests green again | Araq | 2017-12-15 | 1 | -1/+1 |
| | | |||||
| * | Remove expr/stmt (#5857) | Arne Döring | 2017-07-25 | 1 | -1/+1 |
| | | |||||
| * | fixes tuple unpacking regression | Andreas Rumpf | 2017-04-26 | 1 | -0/+2 |
| | | |||||
| * | Fix for #5695 make subscript operator overloadable for tuples (#5749) | cooldome | 2017-04-24 | 1 | -0/+40 |
| | | |||||
| * | fix: generic tuples instantiations were cached incorrectly | Andreas Rumpf | 2016-07-28 | 1 | -0/+4 |
| | | |||||
| * | Handle tuples with unnamed fields, symbols, and more. Less duplication. | Matthew Baulch | 2016-07-15 | 1 | -0/+4 |
| | | |||||
| * | Use target field types in tuple conversions. | Matthew Baulch | 2016-07-14 | 1 | -0/+19 |
| | | |||||
| * | fixes #3579 | Andreas Rumpf | 2016-06-05 | 1 | -1/+1 |
| | | |||||
| * | Spellcheck | Federico Ceratto | 2016-02-29 | 1 | -2/+2 |
| | | |||||
| * | tuple unpacking works in a non-var/let context | Araq | 2015-08-21 | 1 | -0/+32 |
| | | |||||
| * | s/procedure/routine/ in tests. | Dominik Picheta | 2015-06-05 | 1 | -1/+1 |
| | | |||||
| * | Got rid of errUndeclaredProcedureField. | Dominik Picheta | 2015-06-04 | 1 | -1/+1 |
| | | |||||
| * | Fixes #2584 | Dominik Picheta | 2015-06-04 | 1 | -1/+1 |
| | | | | | | Better compiler errors for accessing undeclared fields, calling undeclared procedures and procedure fields. | ||||
| * | made test green | Araq | 2015-05-03 | 1 | -0/+46 |
| | | |||||
| * | fixes regression caused by code cleanups | Araq | 2015-04-29 | 1 | -0/+766 |
| | | |||||
| * | Adds test file, for bug #1986 | Joseph Turner | 2015-04-09 | 1 | -0/+10 |
| | | |||||
| * | fixes #2369 | Araq | 2015-03-21 | 1 | -0/+17 |
| | | |||||
| * | fixes #2121 | Araq | 2015-02-14 | 1 | -0/+9 |
| | | |||||
| * | typo; last commit fixes #1910 | Araq | 2015-01-18 | 1 | -1/+1 |
| | | |||||