diff options
| author | Kartik K. Agaram <vc@akkartik.com> | 2016-08-28 18:12:03 -0700 |
|---|---|---|
| committer | Kartik K. Agaram <vc@akkartik.com> | 2016-08-28 18:37:57 -0700 |
| commit | 5f05e954ee1f1daf953b3ff20af81775f226d5bf (patch) | |
| tree | 21a691619f0e260e18df4140d4d8381682ecd979 /010vm.cc | |
| parent | c7fde8d4e4175b436bc8db92bedd231261827e2c (diff) | |
| download | mu-5f05e954ee1f1daf953b3ff20af81775f226d5bf.tar.gz | |
3273
Undo 3272. The trouble with creating a new section for constants is that there's no good place to order it since constants can be initialized using globals as well as vice versa. And I don't want to add constraints disallowing either side. Instead, a new plan: always declare constants in the Globals section using 'extern const' rather than just 'const', since otherwise constants implicitly have internal linkage (http://stackoverflow.com/questions/14894698/why-does-extern-const-int-n-not-work-as-expected)
Diffstat (limited to '010vm.cc')
| -rw-r--r-- | 010vm.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/010vm.cc b/010vm.cc index 1302f198..6728a0a3 100644 --- a/010vm.cc +++ b/010vm.cc @@ -412,8 +412,8 @@ string_tree* property(const reagent& r, const string& name) { return NULL; } -:(before "End Constants") -const string Ignore(","); // commas are ignored in mu except within [] strings +:(before "End Globals") +extern const string Ignore(","); // commas are ignored in mu except within [] strings :(code) void skip_whitespace_but_not_newline(istream& in) { while (true) { |