3202 - bugfix: 'start-running' and refcounts

When you pass an ingredient to a recipe using 'start-running' it mostly
behaves identically to performing a regular function call. However, if
the calling function completed before the new routine had a chance to
run, the ingredients passed in ran the risk of being reclaimed.

In response, let's always increment refcounts at the time of a function
call rather than when the ingredients are read inside the callee.

Now the summary of commit 3197 is modified to this:

  Update refcounts of products after every instruction, EXCEPT:

    a) when instruction is a non-primitive and the callee starts with
    'local-scope' (because it's already not decremented in 'return')

  OR:

    b) when instruction is primitive 'next-ingredient' or
    'next-ingredient-without-typechecking'

1 files changed, 1 insertions, 0 deletions

diff --git a/027call_ingredient.cc b/027call_ingredient.cc
index 9e98cdc2..1bc3a563 100644
--- a/027call_ingredient.cc
+++ b/027call_ingredient.cc
@@ -33,6 +33,7 @@ for (int i = 0; i < SIZE(ingredients); ++i) {
   reagent/*copy*/ ingredient = call_instruction.ingredients.at(i);
   // End Compute Call Ingredient
   current_call().ingredients.push_back(ingredient);
+  // End Populate Call Ingredient
 }
 
 :(before "End Primitive Recipe Declarations")