3653

Don't crash on bad types.

I need to be more careful in distinguishing between the two causes of
constraint violations: bad input and internal bugs. Maybe I should
create a second assert() to indicate "this shouldn't really be an
assert, but I'm too lazy to think about it right now."

1 files changed, 4 insertions, 1 deletions

diff --git a/030container.cc b/030container.cc
index 53efc857..098c38c5 100644
--- a/030container.cc
+++ b/030container.cc
@@ -204,7 +204,10 @@ void compute_container_sizes(const type_tree* type, set<type_tree>& pending_meta
   if (contains_key(pending_metadata, *type)) return;
   pending_metadata.insert(*type);
   if (!type->atom) {
-    assert(type->left->atom);
+    if (!type->left->atom) {
+      raise << "invalid type " << to_string(type) << location_for_error_messages << '\n' << end();
+      return;
+    }
     if (type->left->name == "address")
       compute_container_sizes(type->right, pending_metadata, location_for_error_messages);
     // End compute_container_sizes Non-atom Special-cases