diff options
author | Kartik K. Agaram <vc@akkartik.com> | 2016-02-21 20:30:02 -0800 |
---|---|---|
committer | Kartik K. Agaram <vc@akkartik.com> | 2016-02-21 20:40:06 -0800 |
commit | c4e143d6ea0635cdb164cec1c62afd7461e605ad (patch) | |
tree | 06fbb672ce95f1d5152c113cdb40685148b57d0c /061recipe.cc | |
parent | f22250a174d5ad5abf8bf99ad140ced52563aee2 (diff) | |
download | mu-c4e143d6ea0635cdb164cec1c62afd7461e605ad.tar.gz |
2681 - drop reagent types from reagent properties
All my attempts at staging this change failed with this humongous commit that took all day and involved debugging three monstrous bugs. Two of the bugs had to do with forgetting to check the type name in the implementation of shape-shifting recipes. Bug #2 in particular would cause core tests in layer 59 to fail -- only when I loaded up edit/! It got me to just hack directly on mu.cc until I figured out the cause (snapshot saved in mu.cc.modified). The problem turned out to be that I accidentally saved a type ingredient in the Type table during specialization. Now I know that that can be very bad. I've checked the traces for any stray type numbers (rather than names). I also found what might be a bug from last November (labeled TODO), but we'll verify after this commit.
Diffstat (limited to '061recipe.cc')
-rw-r--r-- | 061recipe.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/061recipe.cc b/061recipe.cc index 890015e5..7c1b3d05 100644 --- a/061recipe.cc +++ b/061recipe.cc @@ -33,7 +33,6 @@ get_or_insert(Type, recipe).name = "recipe"; :(before "End Null-type is_disqualified Exceptions") if (!x.type && contains_key(Recipe_ordinal, x.name)) { - x.properties.at(0).second = new string_tree("recipe-literal"); x.type = new type_tree("recipe-literal", get(Type_ordinal, "recipe-literal")); x.set_value(get(Recipe_ordinal, x.name)); return true; |