diff options
| author | Kartik Agaram <vc@akkartik.com> | 2020-01-16 18:31:12 -0800 |
|---|---|---|
| committer | Kartik Agaram <vc@akkartik.com> | 2020-01-16 18:31:12 -0800 |
| commit | 6070c23e5e1c60d3bb169e43bddfa59b1d322427 (patch) | |
| tree | 9a70e378c33c15e4779cf94abda8f37c35a5d1da /064write-byte.subx | |
| parent | 5a6601aba973ba1d1ef30b7b64438c25623b89c5 (diff) | |
| download | mu-6070c23e5e1c60d3bb169e43bddfa59b1d322427.tar.gz | |
5897 - rename comparison instructions
Signed and unsigned don't quite capture the essence of what the different combinations of x86 flags are doing for SubX. The crucial distinction is that one set of comparison operators is for integers and the second is for addresses.
Diffstat (limited to '064write-byte.subx')
| -rw-r--r-- | 064write-byte.subx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/064write-byte.subx b/064write-byte.subx index a5f886b2..16e39619 100644 --- a/064write-byte.subx +++ b/064write-byte.subx @@ -43,7 +43,7 @@ write-byte-buffered: # f : (addr buffered-file), n : int 8b/copy 1/mod/*+disp8 7/rm32/edi . . . 1/r32/ecx 4/disp8 . # copy *(edi+4) to ecx # if (f->write >= f->length) flush and clear f's stream 3b/compare 1/mod/*+disp8 7/rm32/edi . . . 1/r32/ecx 0xc/disp8 . # compare ecx with *(edi+12) - 7c/jump-if-lesser $write-byte-buffered:to-stream/disp8 + 7c/jump-if-< $write-byte-buffered:to-stream/disp8 # . flush(f) # . . push args 57/push-edi @@ -218,7 +218,7 @@ append-byte: # f : (addr stream byte), n : int 8b/copy 0/mod/indirect 7/rm32/edi . . . 1/r32/ecx . . # copy *edi to ecx # if (f->write >= f->length) abort 3b/compare 1/mod/*+disp8 7/rm32/edi . . . 1/r32/ecx 8/disp8 . # compare ecx with *(edi+8) - 7d/jump-if-greater-or-equal $append-byte:abort/disp8 + 7d/jump-if->= $append-byte:abort/disp8 $append-byte:to-stream: # write to stream # f->data[f->write] = LSB(n) |