diff options
| author | Kartik Agaram <vc@akkartik.com> | 2018-12-03 17:31:35 -0800 |
|---|---|---|
| committer | Kartik Agaram <vc@akkartik.com> | 2018-12-03 17:32:42 -0800 |
| commit | ee73f5eb31e9dd5a185da097bd990ac94c3d282b (patch) | |
| tree | c3ee7034a7d2e67bc4a0ecc2df79fe681c7c9d71 | |
| parent | 83822d63240cc4d03d00133719993f5e4b2c281f (diff) | |
| download | mu-ee73f5eb31e9dd5a185da097bd990ac94c3d282b.tar.gz | |
4829
Showing the error bit pattern explicitly makes it more clear that it's not possible to generate as a non-error value.
| -rw-r--r-- | html/subx/059read-byte.subx.html | 6 | ||||
| -rw-r--r-- | subx/059read-byte.subx | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/html/subx/059read-byte.subx.html b/html/subx/059read-byte.subx.html index a3ebe17f..fd8af4bf 100644 --- a/html/subx/059read-byte.subx.html +++ b/html/subx/059read-byte.subx.html @@ -261,7 +261,7 @@ if ('onhashchange' in window) { <span id="L195" class="LineNr">195 </span> c3/return <span id="L196" class="LineNr">196 </span> <span id="L197" class="LineNr">197 </span><span class="subxTest">test-read-byte-end-of-file</span>: -<span id="L198" class="LineNr">198 </span> <span class="subxH1Comment"># - call read-byte on an empty 'file', check that it returns -1</span> +<span id="L198" class="LineNr">198 </span> <span class="subxH1Comment"># - call read-byte on an empty 'file', check that it returns 0xffffffff</span> <span id="L199" class="LineNr">199 </span> <span class="subxComment"># setup</span> <span id="L200" class="LineNr">200 </span> <span class="subxS1Comment"># . clear-stream(_test-stream)</span> <span id="L201" class="LineNr">201 </span> <span class="subxS2Comment"># . . push args</span> @@ -286,10 +286,10 @@ if ('onhashchange' in window) { <span id="L220" class="LineNr">220 </span> e8/call read-byte/disp32 <span id="L221" class="LineNr">221 </span> <span class="subxS2Comment"># . . discard args</span> <span id="L222" class="LineNr">222 </span> 81 0/subop/add 3/mod/direct 4/rm32/ESP <span class="CommentedCode"> . </span> <span class="CommentedCode"> . </span> <span class="CommentedCode"> . </span> <span class="CommentedCode"> . </span> <span class="CommentedCode"> . </span> 4/imm32 <span class="subxComment"># add to ESP</span> -<span id="L223" class="LineNr">223 </span> <span class="subxComment"># check-ints-equal(EAX, -1, msg)</span> +<span id="L223" class="LineNr">223 </span> <span class="subxComment"># check-ints-equal(EAX, 0xffffffff, msg)</span> <span id="L224" class="LineNr">224 </span> <span class="subxS2Comment"># . . push args</span> <span id="L225" class="LineNr">225 </span> 68/push <span class="Constant">"F - test-read-byte-end-of-file"</span>/imm32 -<span id="L226" class="LineNr">226 </span> 68/push -1/imm32 +<span id="L226" class="LineNr">226 </span> 68/push 0xffffffff/imm32 <span id="L227" class="LineNr">227 </span> 50/push-EAX <span id="L228" class="LineNr">228 </span> <span class="subxS2Comment"># . . call</span> <span id="L229" class="LineNr">229 </span> e8/call check-ints-equal/disp32 diff --git a/subx/059read-byte.subx b/subx/059read-byte.subx index 305bcbb8..e91a3532 100644 --- a/subx/059read-byte.subx +++ b/subx/059read-byte.subx @@ -195,7 +195,7 @@ test-read-byte-multiple: c3/return test-read-byte-end-of-file: - # - call read-byte on an empty 'file', check that it returns -1 + # - call read-byte on an empty 'file', check that it returns 0xffffffff # setup # . clear-stream(_test-stream) # . . push args @@ -220,10 +220,10 @@ test-read-byte-end-of-file: e8/call read-byte/disp32 # . . discard args 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 4/imm32 # add to ESP - # check-ints-equal(EAX, -1, msg) + # check-ints-equal(EAX, 0xffffffff, msg) # . . push args 68/push "F - test-read-byte-end-of-file"/imm32 - 68/push -1/imm32 + 68/push 0xffffffff/imm32 50/push-EAX # . . call e8/call check-ints-equal/disp32 |