about summary refs log tree commit diff stats
path: root/apps/mu.subx
diff options
context:
space:
mode:
authorKartik Agaram <vc@akkartik.com>2020-02-20 11:54:19 -0800
committerKartik Agaram <vc@akkartik.com>2020-02-20 11:54:19 -0800
commit5d1d61012dc1449feb8928bbf516532afe1c4965 (patch)
treef09185ac77013c7dbffc6e0faa23eafa53197fd1 /apps/mu.subx
parent227c1eaf57331d89dad84dbadd02f0bf27253f48 (diff)
downloadmu-5d1d61012dc1449feb8928bbf516532afe1c4965.tar.gz
6030
Diffstat (limited to 'apps/mu.subx')
-rw-r--r--apps/mu.subx20
1 files changed, 9 insertions, 11 deletions
diff --git a/apps/mu.subx b/apps/mu.subx
index 811be37c..30b9db93 100644
--- a/apps/mu.subx
+++ b/apps/mu.subx
@@ -7411,24 +7411,22 @@ operand-matches-primitive?:  # var: (handle var), prim-var: (handle var) -> resu
     74/jump-if-= $operand-matches-primitive?:end/disp8
     # return false if var->register doesn't match prim-var->register
     {
-      # if addresses are equal, don't return here
-      8b/-> *(esi+0x10) 0/r32/eax
-      39/compare *(edi+0x10) 0/r32/eax
+      # if register addresses are equal, it's a match
+      8b/-> *(esi+0x10) 0/r32/eax  # Var-register
+      39/compare *(edi+0x10) 0/r32/eax  # Var-register
       74/jump-if-= break/disp8
       # if either address is 0, return false
       3d/compare-eax-and 0/imm32
       74/jump-if-=  $operand-matches-primitive?:end/disp8  # eax goes from meaning var->register to result
-      81 7/subop/compare *(edi+0x10) 0/imm32
+      81 7/subop/compare *(edi+0x10) 0/imm32  # Var-register
       74/jump-if-=  $operand-matches-primitive?:end/disp8  # eax goes from meaning var->register to result
-      # if prim-var->register is wildcard, return true
-      (string-equal? *(edi+0x10) Any-register)  # Var-register
+      # if prim-var->register is wildcard, it's a match
+      (string-equal? *(edi+0x10) Any-register)  # Var-register => eax
       3d/compare-eax-and 0/imm32/false
-      b8/copy-to-eax 1/imm32/true
-      75/jump-if-!= $operand-matches-primitive?:end/disp8
-      # if string contents don't match, return false
-      (string-equal? *(esi+0x10) *(edi+0x10))  # Var-register Var-register
+      75/jump-if-!= break/disp8
+      # if string contents aren't equal, return false
+      (string-equal? *(esi+0x10) *(edi+0x10))  # Var-register Var-register => eax
       3d/compare-eax-and 0/imm32/false
-      b8/copy-to-eax 0/imm32/false
       74/jump-if-= $operand-matches-primitive?:end/disp8
     }
     # return true
4'>204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442