diff options
| author | Kartik Agaram <vc@akkartik.com> | 2018-12-06 09:27:26 -0800 |
|---|---|---|
| committer | Kartik Agaram <vc@akkartik.com> | 2018-12-06 09:34:55 -0800 |
| commit | 33e7c3a75196fbf8bd8412eda797cfa170eb189d (patch) | |
| tree | 7132d877c6b8f7813fdc1c5057742698fdf75818 /subx/057stop.subx | |
| parent | 33cf1f90be1e9d92513775edccf96cf2f5a971b7 (diff) | |
| download | mu-33e7c3a75196fbf8bd8412eda797cfa170eb189d.tar.gz | |
4846
Clean up a few things: a) Call scan-next-byte in hex.subx with the right number of args. Turns out tests continue to work fine if they never use the other args. b) Tear down a test for 'stop' in the right order. Not important since we have no EBP to restore. But can still be misleading. c) Have 'check-ints-equal' return nothing. Handy for it to not mess up EAX. I never use the result anyway, and the name also is imperative suggesting callers won't expect a return value.
Diffstat (limited to 'subx/057stop.subx')
| -rw-r--r-- | subx/057stop.subx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/subx/057stop.subx b/subx/057stop.subx index 5788cb72..6e8e6c0b 100644 --- a/subx/057stop.subx +++ b/subx/057stop.subx @@ -161,9 +161,9 @@ test-stop-skips-returns-on-exit: # . . discard args 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 0xc/imm32 # add to ESP # . epilog - 5d/pop-to-EBP # don't restore ESP from EBP; manually reclaim locals 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 8/imm32 # add to ESP + 5d/pop-to-EBP c3/return _test-stop-1: # ed : (address exit-descriptor) |