diff options
| author | Kartik Agaram <vc@akkartik.com> | 2019-05-02 23:32:51 -0700 |
|---|---|---|
| committer | Kartik Agaram <vc@akkartik.com> | 2019-05-02 23:32:51 -0700 |
| commit | f2cd405d04cd904bf1ed4d5ddf4916234c0509f5 (patch) | |
| tree | aacf72ab67c49c3ac2a2d6425924ef0999ebfe8d /subx/apps/crenshaw2-1b.subx | |
| parent | 6e131cefe2cdf9d83bd0727fa3ca97a2ec3b2d3f (diff) | |
| download | mu-f2cd405d04cd904bf1ed4d5ddf4916234c0509f5.tar.gz | |
standardize function names
Operations on buffered-file now always include the word 'buffered'. More verbose, but hopefully this highlights holes in the library.
Diffstat (limited to 'subx/apps/crenshaw2-1b.subx')
| -rw-r--r-- | subx/apps/crenshaw2-1b.subx | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/subx/apps/crenshaw2-1b.subx b/subx/apps/crenshaw2-1b.subx index 2c396fb3..8dee0dbc 100644 --- a/subx/apps/crenshaw2-1b.subx +++ b/subx/apps/crenshaw2-1b.subx @@ -195,7 +195,8 @@ get-num: # in : (address buffered-file), out : (address stream), err : fd or (a # Look = get-char(in) # while is-digit?(Look) # This is complicated because I don't want to hard-code the error strategy in - # a general helper like write-byte. Maybe I should just create a local helper. + # a general helper like write-byte-buffered. Maybe I should just create a + # local helper. # # within the loop we'll try to keep things in registers: # in: ESI @@ -711,11 +712,11 @@ get-char: # f : (address buffered-file) -> <void> 89/copy 3/mod/direct 5/rm32/EBP . . . 4/r32/ESP . . # copy ESP to EBP # . save registers 50/push-EAX - # read-byte(f) + # EAX = read-byte-buffered(f) # . . push args ff 6/subop/push 1/mod/*+disp8 5/rm32/EBP . . . . 8/disp8 . # push *(EBP+8) # . . call - e8/call read-byte/disp32 + e8/call read-byte-buffered/disp32 # . . discard args 81 0/subop/add 3/mod/direct 4/rm32/ESP . . . . . 4/imm32 # add to ESP # save EAX to Look |