about summary refs log tree commit diff stats
path: root/subx/apps/factorial
diff options
context:
space:
mode:
authorKartik Agaram <vc@akkartik.com>2018-09-07 22:13:10 -0700
committerKartik Agaram <vc@akkartik.com>2018-09-07 22:19:13 -0700
commite07a3f2886b117970b3cd58f7cd6806cbfe5cc4a (patch)
tree6fcddb741f3b15eaa7892b5ce0468a6f3695005a /subx/apps/factorial
parent608a7fa8d0faf9a3e3d182d9eabe969804443aab (diff)
downloadmu-e07a3f2886b117970b3cd58f7cd6806cbfe5cc4a.tar.gz
4537
Streamline the factorial function; we don't need to save a stack variable
into a register before operating on it. All instructions can take a stack
variable directly.

In the process we found two bugs:

a) Opcode f7 was not implemented correctly. It was internally consistent
but I'd never validated it against a natively running program. Turns out
it encodes multiple instructions, not just 'not'.

b) The way we look up imm32 operands was sometimes reading them before
disp8/disp32 operands.
Diffstat (limited to 'subx/apps/factorial')
-rwxr-xr-xsubx/apps/factorialbin156 -> 157 bytes
1 files changed, 0 insertions, 0 deletions
diff --git a/subx/apps/factorial b/subx/apps/factorial
index daea2cf4..d9501e23 100755
--- a/subx/apps/factorial
+++ b/subx/apps/factorial
Binary files differ