about summary refs log tree commit diff stats
path: root/subx/ex2.subx
diff options
context:
space:
mode:
authorKartik Agaram <vc@akkartik.com>2018-07-25 20:53:43 -0700
committerKartik Agaram <vc@akkartik.com>2018-07-25 20:53:43 -0700
commit431f739ddca73eb105bced65c169963a335e3134 (patch)
tree114163fff365fcea38cb47ae5d1fae7684f58170 /subx/ex2.subx
parent1a33d221c1a23c218d3457dfe2a4344c2a33f9a1 (diff)
downloadmu-431f739ddca73eb105bced65c169963a335e3134.tar.gz
4414 - subx: syntax checking
This is a large patch, and there's a few things wrong with it:

a) Helpers are incredibly messy. I want to use has_metadata in layer 24,
but can't since it also does error checking. There must be a better
basis set of primitives for managing metadata.

b) Layer 22 introduces operands for checking, but programs with operands
don't actually run until layer 24. So I can't write non-error scenarios
in layer 22. That seems ugly. But if I try to introduce layer 24 first
there's nothing left to check after it.

I *could* play tricks with ordering layers vs transforms. Mu does that a
bit, but it becomes hard to mess with, so I'm trying to avoid that. My
current plan is for layers within an "abstraction level" to be run in
order. Higher layers will necessarily need to come before lower ones.
But hopefully this level of hierarchy will help manage the chaos.

c) The check for whether an instruction is all hex bytes makes me
nervous. I do want to check that an instruction that's just:
  cd
tells the programmer that an operand is missing. The check I currently
have is likely not perfectly correct.

I *could* put layer 25 in its own commit. But I guess I'm not doing
that now.

We have a new example program: hello world!
Diffstat (limited to 'subx/ex2.subx')
-rw-r--r--subx/ex2.subx14
1 files changed, 7 insertions, 7 deletions
diff --git a/subx/ex2.subx b/subx/ex2.subx
index 4708a8b5..21c0ec54 100644
--- a/subx/ex2.subx
+++ b/subx/ex2.subx
@@ -8,13 +8,13 @@
 #   2
 
 == 0x08048054  # code segment, after leaving room for ELF header
-# opcode        ModR/M                    SIB                   displacement    immediate
-# instruction   mod, reg, Reg/Mem bits    scale, index, base
-# 1-3 bytes     0/1 byte                  0/1 byte              0/1/2/4 bytes   0/1/2/4 bytes
-  bb                                                                            1/imm32       # copy 1 to EBX
-  81            c3                                                              1/imm32       # add 1 to EBX
+# instruction             effective address                                         operand displacement    immediate
+# op          subop       mod           rm32          base      index     scale     r32
+# 1-3 bytes                                                                                 0/1/2/4 bytes   0/1/2/4 bytes
+  bb                                                                                                        1/imm32       # copy 1 to EBX
+  81          0/add/subop 3/mod/direct  3/ebx/rm32                                                          1/imm32       # add 1 to EBX
   # exit(EBX)
-  b8                                                                            1/imm32       # copy 1 to EAX
-  cd                                                                            128/imm8      # int 80h
+  b8                                                                                                        1/imm32       # copy 1 to EAX
+  cd                                                                                                        128/imm8      # int 80h
 
 # vim:ft=subx