about summary refs log tree commit diff stats
path: root/subx
diff options
context:
space:
mode:
authorKartik Agaram <vc@akkartik.com>2019-05-13 09:52:00 -0700
committerKartik Agaram <vc@akkartik.com>2019-05-13 09:52:00 -0700
commit32a8e12efa6a9f91baaf324d202dfee44726e437 (patch)
tree4ba190fd5cc40a6e46eb26d99d157efd263b9ac8 /subx
parenta05571db9292ae413ff25467b865d9b1d80efaf8 (diff)
downloadmu-32a8e12efa6a9f91baaf324d202dfee44726e437.tar.gz
.
Diffstat (limited to 'subx')
-rw-r--r--subx/013direct_addressing.cc16
1 files changed, 8 insertions, 8 deletions
diff --git a/subx/013direct_addressing.cc b/subx/013direct_addressing.cc
index 265768ba..7b3997f6 100644
--- a/subx/013direct_addressing.cc
+++ b/subx/013direct_addressing.cc
@@ -44,7 +44,7 @@ case 0x01: {  // add r32 to r/m32
 
 :(code)
 void test_add_r32_to_r32_signed_overflow() {
-  Reg[EAX].i = 0x7fffffff;  // largest positive signed number
+  Reg[EAX].i = 0x7fffffff;  // largest positive signed integer
   Reg[EBX].i = 1;
   run(
       "== 0x1\n"  // code segment
@@ -61,7 +61,7 @@ void test_add_r32_to_r32_signed_overflow() {
 }
 
 void test_add_r32_to_r32_unsigned_overflow() {
-  Reg[EAX].u = 0xffffffff;  // largest positive unsigned number
+  Reg[EAX].u = 0xffffffff;  // largest unsigned number
   Reg[EBX].u = 1;
   run(
       "== 0x1\n"  // code segment
@@ -78,7 +78,7 @@ void test_add_r32_to_r32_unsigned_overflow() {
 }
 
 void test_add_r32_to_r32_unsigned_and_signed_overflow() {
-  Reg[EAX].u = Reg[EBX].u = 0x80000000;  // largest negative number
+  Reg[EAX].u = Reg[EBX].u = 0x80000000;  // smallest negative signed integer
   run(
       "== 0x1\n"  // code segment
       // op     ModR/M  SIB   displacement  immediate
@@ -193,8 +193,8 @@ case 0x29: {  // subtract r32 from r/m32
 
 :(code)
 void test_subtract_r32_from_r32_signed_overflow() {
-  Reg[EAX].i = 0x80000000;  // largest negative number
-  Reg[EBX].i = 0x7fffffff;  // largest positive number
+  Reg[EAX].i = 0x80000000;  // smallest negative signed integer
+  Reg[EBX].i = 0x7fffffff;  // largest positive signed integer
   run(
       "== 0x1\n"  // code segment
       // op     ModR/M  SIB   displacement  immediate
@@ -228,7 +228,7 @@ void test_subtract_r32_from_r32_unsigned_overflow() {
 
 void test_subtract_r32_from_r32_signed_and_unsigned_overflow() {
   Reg[EAX].i = 0;
-  Reg[EBX].i = 0x80000000;  // largest positive signed number
+  Reg[EBX].i = 0x80000000;  // smallest negative signed integer
   run(
       "== 0x1\n"  // code segment
       // op     ModR/M  SIB   displacement  immediate
@@ -887,8 +887,8 @@ void test_compare_r32_with_r32_lesser_unsigned_and_signed() {
 }
 
 void test_compare_r32_with_r32_lesser_unsigned_and_signed_due_to_overflow() {
-  Reg[EAX].i = 0x7fffffff;  // largest positive integer
-  Reg[EBX].i = 0x80000000;  // smallest negative integer
+  Reg[EAX].i = 0x7fffffff;  // largest positive signed integer
+  Reg[EBX].i = 0x80000000;  // smallest negative signed integer
   run(
       "== 0x1\n"  // code segment
       // op     ModR/M  SIB   displacement  immediate