about summary refs log tree commit diff stats
path: root/033exclusive_container.cc
Commit message (Collapse)AuthorAgeFilesLines
* 3383Kartik K. Agaram2016-09-171-1/+1
| | | | Fix overzealous search-and-replace in commit 3380.
* 3381Kartik K. Agaram2016-09-171-4/+4
|
* 3380Kartik K. Agaram2016-09-171-63/+63
| | | | | One more place we were missing expanding type abbreviations: inside container definitions.
* 3321Kartik K. Agaram2016-09-101-3/+4
| | | | | | | | | | | Clean up another case (after commit 3309) of premature support for shape-shifting recipes, where early layers had code without corresponding tests. One addendum to commit 3309: the proximal cause for triggering the rewrite of type_trees was that I realized to_string() and variants were lying to me while debugging; they couldn't distinguish between `(a . b)` and `((a) . b)`
* 3313Kartik K. Agaram2016-09-101-1/+1
| | | | | | | Allow type-trees to be ordered in some consistent fashion. This could be quite inefficient since we often end up comparing the four sub-trees of the two arguments in 4 different ways. So far it isn't much of a time sink.
* 3309Kartik K. Agaram2016-09-091-11/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rip out everything to fix one failing unit test (commit 3290; type abbreviations). This commit does several things at once that I couldn't come up with a clean way to unpack: A. It moves to a new representation for type trees without changing the actual definition of the `type_tree` struct. B. It adds unit tests for our type metadata precomputation, so that errors there show up early and in a simpler setting rather than dying when we try to load Mu code. C. It fixes a bug, guarding against infinite loops when precomputing metadata for recursive shape-shifting containers. To do this it uses a dumb way of comparing type_trees, comparing their string representations instead. That is likely incredibly inefficient. Perhaps due to C, this commit has made Mu incredibly slow. Running all tests for the core and the edit/ app now takes 6.5 minutes rather than 3.5 minutes. == more notes and details I've been struggling for the past week now to back out of a bad design decision, a premature optimization from the early days: storing atoms directly in the 'value' slot of a cons cell rather than creating a special 'atom' cons cell and storing it on the 'left' slot. In other words, if a cons cell looks like this: o / | \ left val right ..then the type_tree (a b c) used to look like this (before this commit): o | \ a o | \ b o | \ c null ..rather than like this 'classic' approach to s-expressions which never mixes val and right (which is what we now have): o / \ o o | / \ a o o | / \ b o null | c The old approach made several operations more complicated, most recently the act of replacing a (possibly atom/leaf) sub-tree with another. That was the final straw that got me to realize the contortions I was going through to save a few type_tree nodes (cons cells). Switching to the new approach was hard partly because I've been using the old approach for so long and type_tree manipulations had pervaded everything. Another issue I ran into was the realization that my layers were not cleanly separated. Key parts of early layers (precomputing type metadata) existed purely for far later ones (shape-shifting types). Layers I got repeatedly stuck at: 1. the transform for precomputing type sizes (layer 30) 2. type-checks on merge instructions (layer 31) 3. the transform for precomputing address offsets in types (layer 36) 4. replace operations in supporting shape-shifting recipes (layer 55) After much thrashing I finally noticed that it wasn't the entirety of these layers that was giving me trouble, but just the type metadata precomputation, which had bugs that weren't manifesting until 30 layers later. Or, worse, when loading .mu files before any tests had had a chance to run. A common failure mode was running into types at run time that I hadn't precomputed metadata for at transform time. Digging into these bugs got me to realize that what I had before wasn't really very good, but a half-assed heuristic approach that did a whole lot of extra work precomputing metadata for utterly meaningless types like `((address number) 3)` which just happened to be part of a larger type like `(array (address number) 3)`. So, I redid it all. I switched the representation of types (because the old representation made unit tests difficult to retrofit) and added unit tests to the metadata precomputation. I also made layer 30 only do the minimal metadata precomputation it needs for the concepts introduced until then. In the process, I also made the precomputation more correct than before, and added hooks in the right place so that I could augment the logic when I introduced shape-shifting containers. == lessons learned There's several levels of hygiene when it comes to layers: 1. Every layer introduces precisely what it needs and in the simplest way possible. If I was building an app until just that layer, nothing would seem over-engineered. 2. Some layers are fore-shadowing features in future layers. Sometimes this is ok. For example, layer 10 foreshadows containers and arrays and so on without actually supporting them. That is a net win because it lets me lay out the core of Mu's data structures out in one place. But if the fore-shadowing gets too complex things get nasty. Not least because it can be hard to write unit tests for features before you provide the plumbing to visualize and manipulate them. 3. A layer is introducing features that are tested only in later layers. 4. A layer is introducing features with tests that are invalidated in later layers. (This I knew from early on to be an obviously horrendous idea.) Summary: avoid Level 2 (foreshadowing layers) as much as possible. Tolerate it indefinitely for small things where the code stays simple over time, but become strict again when things start to get more complex. Level 3 is mostly a net lose, but sometimes it can be expedient (a real case of the usually grossly over-applied term "technical debt"), and it's better than the conventional baseline of no layers and no scenarios. Just clean it up as soon as possible. Definitely avoid layer 4 at any time. == minor lessons Avoid unit tests for trivial things, write scenarios in context as much as possible. But within those margins unit tests are fine. Just introduce them before any scenarios (commit 3297). Reorganizing layers can be easy. Just merge layers for starters! Punt on resplitting them in some new way until you've gotten them to work. This is the wisdom of Refactoring: small steps. What made it hard was not wanting to merge *everything* between layer 30 and 55. The eventual insight was realizing I just need to move those two full-strength transforms and nothing else.
* 3307Kartik K. Agaram2016-09-091-5/+5
|
* 3123Kartik K. Agaram2016-07-221-5/+16
| | | | | | Bugfix: permit dummy product when trying to convert exclusive containers. The 'status' product is still required, however. Without it there's no point to calling 'maybe-convert'.
* 3120Kartik K. Agaram2016-07-211-5/+5
| | | | | | | | Always show instruction before any transforms in error messages. This is likely going to make some errors unclear because they *need* to show the original instruction. But if we don't have tests for those situations did they ever really work?
* 3108Kartik K. Agaram2016-07-101-1/+0
|
* 3048 - bugfix: checking 'merge' instructionsKartik K. Agaram2016-06-111-1/+21
|
* 3046Kartik K. Agaram2016-06-111-3/+3
|
* 2990Kartik K. Agaram2016-05-201-9/+9
| | | | | | | | | | Standardize quotes around reagents in error messages. I'm still sure there's issues. For example, the messages when type-checking 'copy'. I'm not putting quotes around them because in layer 60 I end up creating dilated reagents, and then it's a bit much to have quotes and (two kinds of) brackets. But I'm sure I'm doing that somewhere..
* 2965 - update refcounts when copying containersKartik K. Agaram2016-05-151-3/+7
| | | | | | This is hopefully quite thorough. I handle nested containers, as well as exclusive containers that might contain addresses only when the tag has a specific value.
* 2955 - back to more refcount housekeepingKartik K. Agaram2016-05-121-3/+3
| | | | | Update refcounts of address elements when copying containers. Still lots to do; see todo list at end of 036refcount.cc.
* 2936Kartik K. Agaram2016-05-071-2/+2
|
* 2935Kartik K. Agaram2016-05-071-3/+3
|
* 2934 - all layers running againKartik K. Agaram2016-05-071-2/+0
| | | | | | Since I switched to a Mac laptop (commit 2725) I've been lax in running test_all_layers because I have to ssh into a server and whatnot. I should just get CI setup somewhere..
* 2931 - be explicit about making copiesKartik K. Agaram2016-05-061-13/+13
|
* 2898 - start filling in missing refcountsKartik K. Agaram2016-05-031-6/+7
| | | | | | | This commit covers instructions 'put', 'put-index' and 'maybe-convert'. Next up are the harder ones: 'copy' and 'merge'. In these cases there's a non-scalar being copied, and we need to figure out which locations within it need to update their refcount.
* 2893Kartik K. Agaram2016-05-031-0/+424
|
* 2863Kartik K. Agaram2016-04-241-414/+0
| | | | | Finally after much massaging, the 'address' and 'new' layers are adjacent.
* 2861 - 'maybe-convert' no longer returns addressKartik K. Agaram2016-04-231-13/+51
|
* 2818Kartik K. Agaram2016-03-281-2/+2
|
* 2803Kartik K. Agaram2016-03-211-6/+6
| | | | | Show more thorough information about instructions in the trace, but keep the original form in error messages.
* 2773 - switch to 'int'Kartik K. Agaram2016-03-131-8/+8
| | | | This should eradicate the issue of 2771.
* 2769 - fix build_and_test_until 043space.ccKartik K. Agaram2016-03-131-3/+3
|
* 2735 - define recipes using 'def'Kartik K. Agaram2016-03-081-13/+13
| | | | | | | | | | | | I'm dropping all mention of 'recipe' terminology from the Readme. That way I hope to avoid further bike-shedding discussions while I very slowly decide on the right terminology with my students. I could be smarter in my error messages and use 'recipe' when code uses it and 'function' otherwise. But what about other words like ingredient? It would all add complexity that I'm not yet sure is worthwhile. But I do want separate experiences for veteran programmers reading about Mu on github and for people learning programming using Mu.
* 2712Kartik K. Agaram2016-02-261-8/+8
|
* 2709Kartik K. Agaram2016-02-251-5/+0
| | | | | Only Hide_errors when strictly necessary. In other places let test failures directly show the unexpected error.
* 2704 - eradicate all mention of warnings from coreKartik K. Agaram2016-02-251-1/+1
|
* 2681 - drop reagent types from reagent propertiesKartik K. Agaram2016-02-211-4/+3
| | | | | | | | | | | | | | | | | All my attempts at staging this change failed with this humongous commit that took all day and involved debugging three monstrous bugs. Two of the bugs had to do with forgetting to check the type name in the implementation of shape-shifting recipes. Bug #2 in particular would cause core tests in layer 59 to fail -- only when I loaded up edit/! It got me to just hack directly on mu.cc until I figured out the cause (snapshot saved in mu.cc.modified). The problem turned out to be that I accidentally saved a type ingredient in the Type table during specialization. Now I know that that can be very bad. I've checked the traces for any stray type numbers (rather than names). I also found what might be a bug from last November (labeled TODO), but we'll verify after this commit.
* 2677Kartik K. Agaram2016-02-201-1/+1
| | | | Include type names in the type tree. Though we aren't using them yet.
* 2671 - never use debug_string() in tracesKartik K. Agaram2016-02-191-4/+4
| | | | It's only for transient debugging.
* 2685Kartik K. Agaram2016-02-191-4/+4
| | | | | | | | | | | | | | | | Stack of plans for cleaning up replace_type_ingredients() and a couple of other things, from main problem to subproblems: include type names in the type_tree rather than in the separate properties vector make type_tree and string_tree real cons cells, with separate leaf nodes redo the vocabulary for dumping various objects: do we really need to_string and debug_string? can we have a version with *all* information? can we have to_string not call debug_string? This commit nibbles at the edges of the final task, switching from member method syntax to global function like almost everything else. I'm mostly using methods just for STL in this project.
* 2679 - all tests passing againKartik K. Agaram2016-02-191-2/+3
| | | | | | | | | | Still not done, though: a) There's a few memory leaks to track down, including one in hash from 2668. b) replace_type_ingredients has gotten *even* uglier. I need to rethink it.
* 2667 - redo container data structureKartik K. Agaram2016-02-171-14/+6
| | | | I've been gradually Greenspunning reagents. Just go all the way.
* 2660 - check dynamic arrays in exclusive containersKartik K. Agaram2016-02-151-0/+17
| | | | | Also a bugfix: don't cause future parse errors when these checks are triggered.
* 2657 - type-checking for 'merge' instructionsKartik K. Agaram2016-02-151-0/+139
|
* 2655 - support shape-shifting exclusive containersKartik K. Agaram2016-02-141-2/+3
|
* 2653Kartik K. Agaram2016-02-141-10/+8
|
* 2635Kartik K. Agaram2016-02-061-0/+2
|
* 2582Kartik K. Agaram2016-01-201-2/+2
|
* 2580 - check product type of 'maybe-convert'Kartik K. Agaram2016-01-201-4/+46
| | | | I had to undo some over-zealous changes in 2576.
* 2555Kartik K. Agaram2016-01-111-3/+3
|
* 2378Kartik K. Agaram2015-11-061-1/+1
| | | | | | Now we're starting to run up against the misbehavior introduced by generics: Type tries to insert rows for type ingredients. That is a no-no.
* 2377 - stop using operator[] in mapKartik K. Agaram2015-11-061-16/+16
| | | | | | | | | | | | | | | | I'm still seeing all sorts of failures in turning on layer 11 of edit/, so I'm backing away and nailing down every culprit I run into. First up: stop accidentally inserting empty objects into maps during lookups. Commands run: $ sed -i 's/\(Recipe_ordinal\|Recipe\|Type_ordinal\|Type\|Memory\)\[\([^]]*\)\] = \(.*\);/put(\1, \2, \3);/' 0[1-9]* $ vi 075scenario_console.cc # manually fix up Memory[Memory[CONSOLE]] $ sed -i 's/\(Memory\)\[\([^]]*\)\]/get_or_insert(\1, \2)/' 0[1-9]* $ sed -i 's/\(Recipe_ordinal\|Type_ordinal\)\[\([^]]*\)\]/get(\1, \2)/' 0[1-9]* $ sed -i 's/\(Recipe\|Type\)\[\([^]]*\)\]/get(\1, \2)/' 0[1-9]* Now mu dies pretty quickly because of all the places I try to lookup a missing value.
* 2311Kartik K. Agaram2015-10-291-1/+1
|
* 2284Kartik K. Agaram2015-10-261-5/+5
|
* 2277 - reagents now have a tree of typesKartik K. Agaram2015-10-251-12/+10
|