about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
* 2691Kartik K. Agaram2016-02-231-2/+0
|
* 2690 - one more memory leakKartik K. Agaram2016-02-221-2/+2
| | | | | | | This is the easy one. The remaining ones are like phantoms popping up and dying at random. One thing I know is that they all have to do with tangling. Always implicated is the line in the tangle layer where instructions are loaded and inserted into After_fragments.
* 2689 - fix a memory leakKartik K. Agaram2016-02-221-1/+1
| | | | | | | That same line that caused me so much grief in 2681! I just ran edit/ through valgrind for the first time, and found more memory leaks breeding while I wasn't looking. That's next.
* 2688Kartik K. Agaram2016-02-223-12/+1
|
* 2687Kartik K. Agaram2016-02-221-1/+1
|
* 2686Kartik K. Agaram2016-02-221-12001/+0
|
* 2685Kartik K. Agaram2016-02-225-7/+6
|
* 2684Kartik K. Agaram2016-02-221-1/+1
|
* 2683Kartik K. Agaram2016-02-212-7/+0
| | | | | | Ok, we don't need that check after all, because the type_ingredient_names.empty() check earlier in the layer prevents it from ever triggering.
* 2682Kartik K. Agaram2016-02-211-3/+3
|
* 2681 - drop reagent types from reagent propertiesKartik K. Agaram2016-02-2124-375/+12376
| | | | | | | | | | | | | | | | | All my attempts at staging this change failed with this humongous commit that took all day and involved debugging three monstrous bugs. Two of the bugs had to do with forgetting to check the type name in the implementation of shape-shifting recipes. Bug #2 in particular would cause core tests in layer 59 to fail -- only when I loaded up edit/! It got me to just hack directly on mu.cc until I figured out the cause (snapshot saved in mu.cc.modified). The problem turned out to be that I accidentally saved a type ingredient in the Type table during specialization. Now I know that that can be very bad. I've checked the traces for any stray type numbers (rather than names). I also found what might be a bug from last November (labeled TODO), but we'll verify after this commit.
* 2680Kartik K. Agaram2016-02-207-32/+32
| | | | Delete all the [] that has crept in since 2377 in November.
* 2679Kartik K. Agaram2016-02-202-22/+22
|
* 2678Kartik K. Agaram2016-02-2011-90/+92
| | | | | | | Start using type names from the type tree rather than the property tree in most places. Hopefully the only occurrences of 'properties.at(0).second' left are ones where we're managing it. Next we can stop writing to it.
* 2677Kartik K. Agaram2016-02-2010-17/+19
| | | | Include type names in the type tree. Though we aren't using them yet.
* 2676 - start coalescing type and type-name treesKartik K. Agaram2016-02-201-4/+4
|
* 2675 - undo 2674Kartik K. Agaram2016-02-201-21/+19
|
* 2674 - tried to follow s-exps more closelyKartik K. Agaram2016-02-202-19/+24
| | | | | | | But I realize that this won't actually streamline replace_type_ingredients(), which needs that 'if (curr->left) curr = curr->left' dance for an unrelated reason. So there's no justification for entering into this big refactoring.
* 2673Kartik K. Agaram2016-02-191-1/+2
|
* 2672Kartik K. Agaram2016-02-191-4/+4
|
* 2671 - never use debug_string() in tracesKartik K. Agaram2016-02-1912-61/+41
| | | | It's only for transient debugging.
* 2670 - better names for string conversionsKartik K. Agaram2016-02-194-17/+19
| | | | | | to_string(): relatively stable fields only; for trace() debug_string(): all fields; for debugging inspect(): for a form that can be parsed back later
* 2689 - consistently use s-exp syntax in tracesKartik K. Agaram2016-02-195-22/+24
|
* 2688Kartik K. Agaram2016-02-191-11/+11
|
* 2687Kartik K. Agaram2016-02-191-111/+116
| | | | | | Move code around to put all string-conversion functions in a single section with a reasonable order, from recipe to instruction to reagent to reagent members.
* 2686Kartik K. Agaram2016-02-192-3/+3
|
* 2685Kartik K. Agaram2016-02-1935-166/+162
| | | | | | | | | | | | | | | | Stack of plans for cleaning up replace_type_ingredients() and a couple of other things, from main problem to subproblems: include type names in the type_tree rather than in the separate properties vector make type_tree and string_tree real cons cells, with separate leaf nodes redo the vocabulary for dumping various objects: do we really need to_string and debug_string? can we have a version with *all* information? can we have to_string not call debug_string? This commit nibbles at the edges of the final task, switching from member method syntax to global function like almost everything else. I'm mostly using methods just for STL in this project.
* 2684Kartik K. Agaram2016-02-198-4597/+0
| | | | Cleanup.
* 2683Kartik K. Agaram2016-02-199-57/+4650
| | | | | | | | | | | | | Attempts at improving the superficial looks of replace_type_ingredients(). These don't change the underlying complexity, but perhaps they help gain confidence that all cases have been covered. There's a mini version-history of prior attempts in tmp directories. But really, the ugliness and duplication here stems from earlier design choices: a) Keeping type ordinals and type names in separate trees. b) Even further back, choosing to duplicate types at properties[0].
* 2682Kartik K. Agaram2016-02-191-0/+13
| | | | | | | | | New test after yesterday's changes already passing, which helps me gain some confidence. There's some redundancy in the shape_shifting_container layer. I'm probably testing the same things at the level of element_type(), MERGE, and GET..
* 2681Kartik K. Agaram2016-02-191-1/+1
|
* 2680Kartik K. Agaram2016-02-192-27/+27
| | | | Memory leaks fixed.
* 2679 - all tests passing againKartik K. Agaram2016-02-193-64/+55
| | | | | | | | | | Still not done, though: a) There's a few memory leaks to track down, including one in hash from 2668. b) replace_type_ingredients has gotten *even* uglier. I need to rethink it.
* 2678Kartik K. Agaram2016-02-191-0/+1
| | | | Now I've fixed the type-checker, but it fails while running.
* 2677Kartik K. Agaram2016-02-191-11/+30
| | | | | Getting warmer. The unit tests for element_type now work, and the larger test too seems to get further.
* 2676Kartik K. Agaram2016-02-191-21/+24
| | | | Inline nth_type and nth_type_name.
* 2675Kartik K. Agaram2016-02-181-10/+8
| | | | | Make nth_type non-recursive in advance of hoisting the call into the caller.
* 2674Kartik K. Agaram2016-02-181-1/+7
| | | | | | | | | | Make it explicit that I don't currently intend to further replace type ingredients inside replacements. That might well make sense, but I've not thought up any use cases or tests for it, and it seems excessive at the moment. And when I find bugs I keep wondering if the repeated replace might be the problem. No longer.
* 2673 - renameKartik K. Agaram2016-02-181-8/+8
|
* 2672 - no, that test should be considered failingKartik K. Agaram2016-02-181-2/+20
| | | | | Also exercise the breaking part in a couple of the unit tests for replace_type_ingredient. Now we need to fix all three.
* 2671Kartik K. Agaram2016-02-181-8/+29
| | | | | | Fix the pending test while trying to fix the warning about 'merge'. Warning still present.
* 2670 - improvements to genericsKartik K. Agaram2016-02-182-11/+146
| | | | | | | | | | | Eliminated a few holes, gained more clarity on the shape of others. Maybe I was sleep-deprived, but this was really hard until I wrote a few unit tests directly on replace_type_ingredient. Still one flaw remaining: the type-checker isn't smart enough to handle 'merge' for all the new cases. Tests pass since we don't use those features outside C++ tests yet.
* 2669Kartik K. Agaram2016-02-171-0/+1
|
* 2668 - add an escape hatch for 'hash'Kartik K. Agaram2016-02-171-0/+21
| | | | | | | | If you don't want a field of a container to be included in its hash, use the /ignore-for-hash property. This property only works for containers, not exclusive-containers or arrays. Mu will warn if you misuse it.
* 2667 - redo container data structureKartik K. Agaram2016-02-177-85/+57
| | | | I've been gradually Greenspunning reagents. Just go all the way.
* 2666Kartik K. Agaram2016-02-171-1/+1
|
* 2665Kartik K. Agaram2016-02-173-15/+6
|
* 2664 - 'hash' any typeKartik K. Agaram2016-02-161-3/+339
| | | | | | This is smart enough to only look at data and ignores internal book-keeping like addresses, refcounts and floating-point details. Though the last is not ideal yet.
* 2663Kartik K. Agaram2016-02-161-6/+1
|
* 2662 - rewrite 'hash' in C++Kartik K. Agaram2016-02-152-28/+36
| | | | | | | | | Since it needs specialized non-overflowing types like unsigned long long, my plan is to eventually write it in straight machine code using Mu primitives to make that a slightly nicer process. Hopefully we'll need to deal with machine types only for a tiny set of crucial primitives and it won't be too painful to drop down to machine code for them.
iv>