| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
| |
Undo commit 3938 and almost everything after. Let's do this right.
|
| |
|
|
|
|
|
|
| |
No, my conclusion in the previous commit was wrong. When you print a
character on the right margin, the cursor coordinates always wrap around
to the left margin on the next row. It's just that if you're at the
bottom of the screen, scrolling gives the impression that the row didn't
change.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Even though the bug of commit 3938 is now fixed, I'm still trying to
track down why the failure looked different on the fake screen than on
the real one. Snapshot as I try to track down the difference.
One key lesson is that the approach of commit 3860 -- updating the
cursor before rather than after printing each character -- turns out to
be untenable. A sequence of `print` followed by `cursor-position` needs
to behave the same as the real screen.
But it's still not clear how the real screen. When you get to the end of
a line the cursor position wraps after print to the left margin (column
0) on the next row. When you get to the bottom right the cursor position
wraps to the *bottom left* margin. How the heck does it know to scroll
on the next print, then? Is there some hidden state in the terminal?
|
| | |
|
| | |
|
| |
|
|
| |
Standardize functions to put the main object being modified first.
|
| |
|
|
|
|
| |
This change is interesting because I only updated one test to gain confidence
that F4 will never redraw the recipe side. (Most of the changes are to
explicitly render-all before each scenario.)
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Yet another bugfix, this time in just the sandbox/ app:
open sandbox/ with empty lesson/ directory
type 'a'
press backspace
cursor was not moving left
Now fixed.
Turns out the sandbox/ app hadn't been working right since commit 3854.
(Which ironically was a revert but clearly didn't revert enough; the last
truly good commit was 3823, and we're still clawing our way back to the
sunlight.)
The issue in this case was that commit 3853 disabled update-cursor in some
situations when it shouldn't have. To be safe, just always update-cursor
one very event. I should probably reorganize this in edit/ as well, but
it's not necessary for this particular bug.
---
Incidentally, as part of my git bisecting I realized that the bug fixed
in the trace browser as part of commit 3862 was very old:
press '/'
press some key
press ctrl-u to erase
press some key
= out of bounds string access
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To achieve this we have to switch to a model of the screen in termbox that
is closer to the underlying terminal.
Before:
a screen is a grid of characters
writing out of bounds does nothing
After:
a screen is a scrolling raster of characters
writing out of bounds wraps to next line and scrolls if necessary
To move to the new model, it was essential that I migrate my fake screen
at the same time to mimic it. This is why the first attempt (commit 3824)
failed (commit 3858). This is also why this commit can't be split into
smaller pieces.
The fake screen now 'scrolls' by rotating screen lines from top to bottom.
There's still no notion of a scrollback buffer.
The newer model is richer; it permits repl-like apps that upstream termbox
can't do easily. It also permits us to simply use `printf` or `cout` to
write to the screen, and everything mostly works as you would expect. Exceptions:
a) '\n' won't do what you expect. You need to explicitly print both '\n'
and '\r'.
b) backspace won't do what you expect. It only moves the cursor back,
without erasing the previous character. It does not wrap.
Both behaviors exactly mimic my existing terminal's emulation of vt100.
The catch: it's easy to accidentally scroll in apps. Out-of-bounds prints
didn't matter before, but they're bugs now. To help track them down, use
the `save-top-idx`, `assert-no-scroll` pair of helpers.
An important trick is to wrap the cursor before rather after printing
a character. Otherwise we end up scrolling every time we print to the
bottom-right character. This means that the cursor position can be invalid
at the start of a print, and we need to handle that.
In the process we also lose the ability to hide and show the screen. We
have to show the prints happening. Seems apt for a "white-box" platform
like Mu.
|
| | |
|
| |
|
|
|
| |
Bugfix on commit 3853: clear `render-all-on-no-more-events` once you've
actually run the `render-all`.
|
| |
|
|
| |
Revert commits 3824, 3850 and 3852. We'll redo them more carefully.
|
| |
|
|
|
|
| |
Bring back commit 3844, albeit in simplified form. I'd forgotten that the
one place where we still need to buffer rendering is when people hold down
up/down arrow keys.
|
| |
|
|
|
| |
Bugfix: writes out of bounds used to be skipped, but started clobbering
the screen on commit 3824.
|
| |
|
|
|
| |
Once I start optimizing most events to not repaint everything there's no
need to be smart about queued-up events.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now it's much more apparent why things are slow. You can see each repaint
happening. Already I fixed one performance bug -- in clear-rest-of-screen.
Since this subverts Mu's fake screen there may be bugs.
Another salubrious side effect: I've finally internalized that switching
to raw mode doesn't have to clear the screen. That was just an artifact
of how termbox abstracted operations. Now I can conceive of using termbox
to build a repl as well.
(I was inspired to poke into termbox internals by
http://viewsourcecode.org/snaptoken/kilo and
https://github.com/antirez/linenoise)
|
| |
|
|
|
|
|
|
| |
Resize events don't actually seem to ever get queued up, so they're still
super slow. Dump all our extra smarts about skipping repaints. We need
to focus on speeding up repaints in general.
Thanks Andrew Owen for reporting this issue.
|
| | |
|
| |
|
|
|
|
| |
Move 'render-code' to the layer where it's used.
Thanks Caleb Couch for finding this bit of ugliness.
|
| |
|
|
|
|
|
| |
Stop trying to create a new layer showing how we minimize prints.
Stephen's suggestion is to create a data structure that encapsulates
instructions to `insert-at-cursor` for either just printing a character
to screen or rendering everything. Let's try that at some point.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Reorder products of some functions in the edit/ and sandbox/ apps. My
recent realization: always return 'real' products before ones that just
indicate an ingredient is mutable.
|
| |
|
|
|
| |
Delete some obsolete /same-as-ingredient attributes. We should always
let Mu deduce those at this point.
|
| |
|
|
|
|
| |
Decouple programming environment initialization from rendering. This
helps make clear that we only need the width from screen during
initialization.
|
| |
|
|
|
|
| |
Decouple editor initialization from rendering to screen. This hugely
simplifies the header of 'new-editor' and makes clear that it was only
using the screen for rendering.
|
| |
|
|
|
|
| |
Cleaning up the console interfaces before we start changing the socket
interfaces to look like them. Reading from sockets need to be
non-blocking just like reading from the console.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop requiring jump instructions to explicitly provide a ':label' type
for jump targets.
This has been a source of repeated confusion for my students:
a) They'd add the ':label' to the label definition rather than the
jump target (label use)
b) They'd spend time thinking about whether the initial '+' prefix was
part of the label name.
In the process I cleaned up a couple of things:
- the space of names is more cleanly partitioned into labels and
non-labels (clarifying that '_' and '-' are non-label prefixes)
- you can't use label names as regular variables anymore
- you can infer the type of a label just from its name
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Redo commit 3457.
Basically there were 3 unicode characters we changed back then:
solid horizontal line: 9473 -> 9472
fuzzy horizontal line: 9480 -> 9548
fuzzy vertical line: 9482 -> 9550
The solid horizontal line has no issues, so we just redo it here.
For the other two, we'll perform the substitution only when rendering
html. That gives us the best of both worlds: the scenario screens render
right in html, and alt-tabbing continues to be snappy when running the
edit/ app.
|
| |
|
|
|
|
|
|
|
|
| |
Revert commit 3457, where I switched the unicode characters used in the
edit/ app to something that doesn't render double-wide in html. It turns
out that the new unicode characters made iTerm2 sluggish in alt-tabbing
between windows. (Commit 3488 only fixed the screen-clearing issue.)
I haven't reverted the html files. I'm going to redo commit 3457 next so
the html files continue to render like they do now.
|
| |
|
|
|
| |
Switch around some unicode characters in the edit/ app so that it
renders more cleanly in html (with monospace fonts).
|
| |
|
|
|
|
|
| |
Ugly that we didn't need 'screen' to provide a type in scenarios
(because assume-screen expands to a definition of 'screen') but we did
need a type for 'console'. Just never require types for special names in
scenarios.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
A long-standing problem has been that I couldn't spread code across
'run' blocks because they were separate scopes, so I've ended up making
them effectively comments. Running code inside a 'run' block is
identical in every way to simply running the code directly. The 'run'
block is merely a visual aid to separate setup from the component under
test.
In the process I've also standardized all Mu scenarios to always run in
a local scope, and only use (raw) numeric addresses for values they want
to check later.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Well, almost. I can't use them in some places in C++ where I'm just
creating a temporary reagent without passing it through transforms. Like
in some unit tests. I can't use them in memory-should-contain.
And there's one remaining bug: I can't use abbreviations in a couple of
places in 075channel.mu.
|
| |
|
|
|
|
|
| |
Process type abbreviations in function headers.
Still a couple of places where doing this causes strange errors. We'll
track those down next.
|
| |
|
|
|
| |
In the process I've uncover a couple of situations we don't support type
abbreviations yet. They're next.
|
| | |
|
| |
|
|
|
| |
As much as possible; if the cursor moves off screen, it still resets to
top of screen.
|
| |
|
|
|
|
| |
This required the fix of 3051 to first-class recipe support, and will
next enable us to keep the cursor from moving in response to resize
events.
|
| | |
|
| |
|
|
| |
Clean up this helper before we start redoing sandbox menubars.
|
| |
|
|
|
|
|
| |
Now that we no longer have non-shared addresses, we can just always
track refcounts for all addresses.
Phew!
|
| | |
|