| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Show number of instructions in the editor when a
user clicks on a run instruction in the sandbox.
|
| | |
|
| |
|
|
|
| |
As much as possible; if the cursor moves off screen, it still resets to
top of screen.
|
| |
|
|
|
|
| |
This required the fix of 3051 to first-class recipe support, and will
next enable us to keep the cursor from moving in response to resize
events.
|
| |
|
|
| |
Thanks Caleb Couch for finding this.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some rare situations the editor would join a line with the next when
it should simply wrap to the next screen row. Thanks Caleb and Ella
Couch for finally running into a situation that was easy to reproduce.
The scenario diffs are misleading on this commit. I had to:
a) delete the obsolete 'editor-wraps-cursor-after-inserting-characters'
because it was written back when a line just large enough to fit in a
single line would not wrap:
| | <-- screen boundary
abcde
These days it will wrap after making room for the wrap indicator:
| | <-- screen boundary
abcd↩
e
b) rename editor-wraps-cursor-after-inserting-characters-2 to
editor-wraps-cursor-after-inserting-characters-in-middle-of-line
c) create a new scenario demonstrating the bug:
editor-wraps-cursor-after-inserting-characters-at-end-of-line
|
| |
|
|
|
| |
When I floor the down-arrow too much, don't scroll unnecessarily off the
bottom of the screen. But *do* scroll if there's errors to show.
|
| |
|
|
|
|
|
|
|
|
| |
Standardize quotes around reagents in error messages.
I'm still sure there's issues. For example, the messages when
type-checking 'copy'. I'm not putting quotes around them because in
layer 60 I end up creating dilated reagents, and then it's a bit much to
have quotes and (two kinds of) brackets. But I'm sure I'm doing that
somewhere..
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Doesn't work as advertised yet. This is just the render piece, and
fixing all the tests.
I've been careful to try to break tests for edit once I implement the
button. Delete I can't ensure will break afterwards. Remember to test
clicking on multiple places on the menu.
Managing the screens is starting to grow onerous; maybe we need
something called normalize which clears some things. But the sandbox
menu can be on arbitrary lines..
|
| | |
|
| |
|
|
| |
Clean up this helper before we start redoing sandbox menubars.
|
| |
|
|
| |
The actual fix is in the layer rewriting literal strings.
|
| |
|
|
|
|
| |
In the process I've also simplified the sandbox/ app. Since it's
impossible for sandbox editors to span multiple pages, we can drop all
scroll support altogether.
|
| |
|
|
|
| |
This had been broken ever since 2854, because we can't write tests for
restore-snapshots at the moment.
|
| | |
|
| |
|
|
|
|
|
| |
Now that we no longer have non-shared addresses, we can just always
track refcounts for all addresses.
Phew!
|
| | |
|
| |
|
|
| |
Phew!
|
| | |
|
| | |
|
| |
|
|
| |
Issue 1 in 2829 is now fixed.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings back some of the complexity I thought I'd gotten rid of in
2799.
The regression brought home the point that I'd forgotten to write tests
for those bits. Written now.
It also brought home the point that our cleanup in 'reload' has always
been hacky and incomplete.
It's also ugly that those tests in the sandbox/ and edit/ apps need
changing (particularly when the test is about how the output doesn't
change).
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
I'm dropping all mention of 'recipe' terminology from the Readme. That
way I hope to avoid further bike-shedding discussions while I very
slowly decide on the right terminology with my students.
I could be smarter in my error messages and use 'recipe' when code uses
it and 'function' otherwise. But what about other words like ingredient?
It would all add complexity that I'm not yet sure is worthwhile. But I
do want separate experiences for veteran programmers reading about Mu on
github and for people learning programming using Mu.
|
| |
|
|
|
| |
We're still not done. Layer 60 doesn't yet handle variables in
surrounding spaces. There's probably other issues..
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Thanks Nicolas Léveillé for running up against this bug:
https://news.ycombinator.com/item?id=11094837
(Also noticed and fixed several subsidiary issues. This whole aspect
doesn't seem fully baked yet.)
|
| |
|
|
| |
Reorganize further to make edit/008-sandbox-test more self-contained.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you restore 2 sandboxes, the first render was setting
response-starting-row-on-screen on both, without ever rendering a
response. If the lower sandbox contained a print and rendered the screen
instead of the response, the original response-starting-row-on-screen
was never reset. If the process of running the sandboxes caused the
lower sandbox's title bar to move below the now-stale
response-starting-row-on-screen[1], editing the lower sandbox no longer
works.
[1] (Either because the upper sandbox prints to screen as well (causing
the first F4 to move the lower sandbox down by several lines), or
because a fresh sandbox is created with several lines before the first
F4 is hit.)
Current solution: never set response-starting-row-on-screen during
reload (or otherwise when there's no response).
This is hard to test right now because 'restore' is not a tested
interface, and I can't come up with another situation where the
response-starting-row-on-screen goes stale. So I'm now trying to keep
all changes to response-starting-row-on-screen close together. Another
idea is to add a check that the click row lies below the
response-starting row *and* above the start of the next sandbox. (But
what if there's no next sandbox?)
(This bug is really a regression, introduced last Sep in 2163.)
|
| |
|
|
| |
Moving back to wrapped line was overflowing the right margin.
|
| |
|
|
| |
Somehow this never transferred over from the Arc version until now.
|
| |
|
|
|
|
|
|
|
|
| |
When I first forked it from the edit/ app, I wasn't sure how to deal
with changing the recipe side when the only way the program accesses it
is with the untestable 'restore' hack. Now we introduce a little hook
into event-loop and pass in any updated recipe side directly.
In the process I've cleaned up several minor stylistic inconsistencies
between edit/ and sandbox/ apps.
|
| |
|
|
| |
Caused by 2591.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
This required completely redesigning scrolling.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm now thinking about how to support scrolling on the sandbox side.
Caleb's idea is to use down-arrow inside the sandbox editor, and then
"scroll off" the editor to the top of each successive sandbox. I think
I'll reserve the white background as the cursor color in that situation.
I wonder if I should just undo all the support for sandbox labels since
yesterday. Labels are perhaps superfluous once I support scrolling and
reorder sandboxes to always throw ones with errors up top. But then you
can end up scrolling through lots of tests without any sense of how far
down you are. So the other approach is to keep labels and try to keep
them stable, not reorder them.
Looking further ahead I'm going to need a way to jump to a specific
sandbox. Maybe instead of reordering sandboxes I should just
automatically render from the first sandbox with error. Maybe show the
number of failed sandboxes in the status instead of the index of the
first failure.
|