| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
| |
This regression was (also) introduced by commit 3902 in June.
|
| |
|
|
|
|
| |
This regression was introduced by commit 3902 in June.
Making this commit clean took the last 4 commits of reorganizing.
|
| |
|
|
|
| |
It's always been ugly that I referred to a later layer/feature in a
label name.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Yet another regression, this time cascading from commit 3953. My
scenario wasn't actually testing what I thought it was testing.
|
| |
|
|
|
| |
Don't refresh entire sandbox side when toggling the expected result for
a single sandbox.
|
| |
|
|
|
|
|
| |
Don't unnecessarily write sandboxes to disk on F4.
This seems to save almost 20% time when processing a large lesson
directory with 36 sandboxes.
|
| |
|
|
|
|
|
|
| |
Improvement on fix 3957: rather than put a band-aid over a slow
operation, eliminate the slowdown entirely.
In this case it turns out we're unnecessarily saving files to disk when
they could never be modified. Are we doing this on F4 as well?!
|
| |
|
|
|
| |
Marking sandbox responses as expected can take a long time if there are
many sandboxes. Indicate when a click is being worked on.
|
| |
|
|
|
| |
Move a scenario which is after commit 3954 applicable to both editors,
not just the recipe side.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a blanket rule, down-arrow now stops scrolling once the bottom margin
comes on screen.
Now that we have page-wise scrolling with ctrl-f/b and line-wise
scrolling with ctrl-s/x, we don't need to conflate scroll positioning
with the arrow keys. And as a result, early students no longer have to
struggle with accidentally scrolling part of the sandbox off the screen
when there's tons of empty space available.
`move-to-next-line` is still super messy and will need further
rethinking, but this commit simplifies the codebase as a whole by
eliminating a couple of historical accidents:
a) We only introduced scrolling past the bottom of the screen to allow
more sandboxes to come into view before we had scrolling for the
sandbox side.
b) We undid scrolling past the bottom in just the recipe side to allow
errors to come into view.
Since these historical details are now irrelevant, we no longer need
separate logic for the recipe and sandbox sides, and we don't need to
keep track of the recipe-bottom separate from the bottom margin of
arbitrary editors.
|
| |
|
|
|
|
|
|
|
| |
Redo cursor-down to fix a bug.
This should be the final bug I find as part of my audit of everywhere we
compare characters to newlines in layer 3 of the edit/ app.
Pretty messy implementation, but we'll clean it up now.
|
| | |
|
| |
|
|
|
|
| |
Fix a regression caused by commit 3919.
Thanks Juan Crispin Hernandez for running into this.
|
| |
|
|
| |
Fix the failing scenario of commit 3944.
|
| |
|
|
|
|
|
| |
Reintroduce the failing test of commit 3938. It has two problems:
a) it's failing, and
b) it's not failing the same way as with a real screen.
|
| |
|
|
| |
Undo commit 3938 and almost everything after. Let's do this right.
|
| |
|
|
|
|
|
|
| |
No, my conclusion in the previous commit was wrong. When you print a
character on the right margin, the cursor coordinates always wrap around
to the left margin on the next row. It's just that if you're at the
bottom of the screen, scrolling gives the impression that the row didn't
change.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Even though the bug of commit 3938 is now fixed, I'm still trying to
track down why the failure looked different on the fake screen than on
the real one. Snapshot as I try to track down the difference.
One key lesson is that the approach of commit 3860 -- updating the
cursor before rather than after printing each character -- turns out to
be untenable. A sequence of `print` followed by `cursor-position` needs
to behave the same as the real screen.
But it's still not clear how the real screen. When you get to the end of
a line the cursor position wraps after print to the left margin (column
0) on the next row. When you get to the bottom right the cursor position
wraps to the *bottom left* margin. How the heck does it know to scroll
on the next print, then? Is there some hidden state in the terminal?
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Fix an out-of-bounds write to the screen when sandboxes aligned just
right.
Thanks Ella Couch for reporting this issue.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Bugfix: when you hit `enter`, the cursor-row does not increment in *one*
special situation: when the line wraps and the cursor is right at the
start of one of the wrapped lines.
|
| |
|
|
| |
Bugfix: adjust row when hitting ctrl-u on wrapped lines.
|
| | |
|
| |
|
|
|
| |
Bugfix: ctrl-a leaves things consistent in the presence of wrapped
lines.
|
| | |
|
| | |
|
| |
|
|
| |
Bugfix: up-arrow in combination with wrapped lines.
|
| |
|
|
| |
Bugfix: handle wrapped lines when moving to end of line.
|
| | |
|
| | |
|
| |
|
|
| |
Remember that `before-previous-line` deals with wrapped screen lines.
|
| |
|
|
| |
Bugfix in ctrl-u.
|
| | |
|
| |
|
|
| |
Standardize functions to put the main object being modified first.
|
| |
|
|
| |
Turns out all I had to do was reset `go-render?` to false.
|
| |
|
|
|
|
| |
This change is interesting because I only updated one test to gain confidence
that F4 will never redraw the recipe side. (Most of the changes are to
explicitly render-all before each scenario.)
|
| | |
|
| | |
|
| |
|
|
| |
Fix a keyboard shortcut conflict in commit 3884.
|
| | |
|
| | |
|
| | |
|