| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
Remember that `before-previous-line` deals with wrapped screen lines.
|
| |
|
|
| |
Bugfix in ctrl-u.
|
| | |
|
| |
|
|
| |
Standardize functions to put the main object being modified first.
|
| |
|
|
| |
Turns out all I had to do was reset `go-render?` to false.
|
| |
|
|
|
|
| |
This change is interesting because I only updated one test to gain confidence
that F4 will never redraw the recipe side. (Most of the changes are to
explicitly render-all before each scenario.)
|
| | |
|
| | |
|
| |
|
|
| |
Fix a keyboard shortcut conflict in commit 3884.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Thanks Juan Crispin Hernandez for the suggestion.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Strange race condition: if I repeatedly press <enter> and <backspace> so
the screen is constantly playing catch up, it will sometimes fail these
assertions when it does eventually catch up. Somehow the cursor ends up
misplaced. Let's just take them out. It's likely some low-level implementation
detail of the terminal.
|
| | |
|
| |
|
|
| |
Clean up a few superficial things in Caleb's commit.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Yet another bugfix, this time in just the sandbox/ app:
open sandbox/ with empty lesson/ directory
type 'a'
press backspace
cursor was not moving left
Now fixed.
Turns out the sandbox/ app hadn't been working right since commit 3854.
(Which ironically was a revert but clearly didn't revert enough; the last
truly good commit was 3823, and we're still clawing our way back to the
sunlight.)
The issue in this case was that commit 3853 disabled update-cursor in some
situations when it shouldn't have. To be safe, just always update-cursor
one very event. I should probably reorganize this in edit/ as well, but
it's not necessary for this particular bug.
---
Incidentally, as part of my git bisecting I realized that the bug fixed
in the trace browser as part of commit 3862 was very old:
press '/'
press some key
press ctrl-u to erase
press some key
= out of bounds string access
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To achieve this we have to switch to a model of the screen in termbox that
is closer to the underlying terminal.
Before:
a screen is a grid of characters
writing out of bounds does nothing
After:
a screen is a scrolling raster of characters
writing out of bounds wraps to next line and scrolls if necessary
To move to the new model, it was essential that I migrate my fake screen
at the same time to mimic it. This is why the first attempt (commit 3824)
failed (commit 3858). This is also why this commit can't be split into
smaller pieces.
The fake screen now 'scrolls' by rotating screen lines from top to bottom.
There's still no notion of a scrollback buffer.
The newer model is richer; it permits repl-like apps that upstream termbox
can't do easily. It also permits us to simply use `printf` or `cout` to
write to the screen, and everything mostly works as you would expect. Exceptions:
a) '\n' won't do what you expect. You need to explicitly print both '\n'
and '\r'.
b) backspace won't do what you expect. It only moves the cursor back,
without erasing the previous character. It does not wrap.
Both behaviors exactly mimic my existing terminal's emulation of vt100.
The catch: it's easy to accidentally scroll in apps. Out-of-bounds prints
didn't matter before, but they're bugs now. To help track them down, use
the `save-top-idx`, `assert-no-scroll` pair of helpers.
An important trick is to wrap the cursor before rather after printing
a character. Otherwise we end up scrolling every time we print to the
bottom-right character. This means that the cursor position can be invalid
at the start of a print, and we need to handle that.
In the process we also lose the ability to hide and show the screen. We
have to show the prints happening. Seems apt for a "white-box" platform
like Mu.
|
| | |
|
| | |
|
| |
|
|
|
| |
Bugfix on commit 3853: clear `render-all-on-no-more-events` once you've
actually run the `render-all`.
|
| |
|
|
| |
Revert commits 3824, 3850 and 3852. We'll redo them more carefully.
|
| |
|
|
|
|
| |
Bring back commit 3844, albeit in simplified form. I'd forgotten that the
one place where we still need to buffer rendering is when people hold down
up/down arrow keys.
|
| |
|
|
|
| |
Bugfix: writes out of bounds used to be skipped, but started clobbering
the screen on commit 3824.
|
| |
|
|
|
| |
Once I start optimizing most events to not repaint everything there's no
need to be smart about queued-up events.
|
| | |
|
| |
|
|
| |
Fix CI.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now it's much more apparent why things are slow. You can see each repaint
happening. Already I fixed one performance bug -- in clear-rest-of-screen.
Since this subverts Mu's fake screen there may be bugs.
Another salubrious side effect: I've finally internalized that switching
to raw mode doesn't have to clear the screen. That was just an artifact
of how termbox abstracted operations. Now I can conceive of using termbox
to build a repl as well.
(I was inspired to poke into termbox internals by
http://viewsourcecode.org/snaptoken/kilo and
https://github.com/antirez/linenoise)
|
| |
|
|
|
|
|
|
| |
Resize events don't actually seem to ever get queued up, so they're still
super slow. Dump all our extra smarts about skipping repaints. We need
to focus on speeding up repaints in general.
Thanks Andrew Owen for reporting this issue.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Standardize the order of some common blocks in `render`, `render-text`
and `render-code`. This is preparation for trying to reorganize them to
reduce duplicate code.
|
| |
|
|
| |
Fix a _very_ misleading comment.
|
| |
|
|
|
|
| |
Move 'render-code' to the layer where it's used.
Thanks Caleb Couch for finding this bit of ugliness.
|
| |
|
|
| |
Don't try to snapshot in scenarios.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
I accidentally got rid of git snapshotting of lessons back when I switched
to testable file primitives last December (commit 3705).
>:-(
Bringing it back now, hopefully better. The improvement is that there's
now at most one commit every time we hit F4.
This change adds yet another reason that running `mu` from a different
directory is just not supported.
|
| | |
|
| |
|
|
|
|
|
| |
Stop trying to create a new layer showing how we minimize prints.
Stephen's suggestion is to create a data structure that encapsulates
instructions to `insert-at-cursor` for either just printing a character
to screen or rendering everything. Let's try that at some point.
|
| | |
|
| |
|
|
|
| |
We do support printing non-integer numbers for some time, albeit using
the underlying host platform.
|
| | |
|
| |
|
|
| |
Bitrot in main when loading just layer 1 of the edit/ and sandbox/ apps.
|
| | |
|
| | |
|