about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
...
* use method syntax where possibleKartik K. Agaram2022-03-069-80/+80
| | | | | | Perhaps this is a bad idea. It feels arbitrary, what methods Lua happens to include in string and table objects without having to go through the respective modules.
* reading from file a character at a timeKartik K. Agaram2022-03-061-0/+20
|
* local functions broke start_reading/start_writingKartik K. Agaram2022-03-061-2/+2
| | | | | Looks like Lua's local functions lose access to outer scopes (upvalues) or something like that..
* move start_reading/start_writing out of templateKartik K. Agaram2022-03-065-144/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When should code go in the template used by new apps vs the .lua files distributed with Teliva? - from a privilege perspective there's no difference - from a compatibility perspective stuff in .tlv will not get upgraded with Teliva. - for me the maintainer, functions in .lua files are easier to upgrade in a single place. - for the reader of an app, functions in .lua files will not show up to be edited. They can still be overloaded, but the current version isn't as discoverable. Putting something in the app is a slight nudge to readers that they're encouraged to mess with it. - Stuff in .lua files can use local functions and so have more internal complexity. Apps can also hide details within functions, but that'll make them more likely to run into limitations with Teliva's editing environment. I'm not yet sure how to reason about the second point in practice. - Stuff in .tlv files I don't have to worry about compatibility guarantees for. - Stuff in .lua files I _do_ have to worry about compatibility guarantees for. Perhaps this means I'm doing things exactly wrong in this commit? Functions like map/reduce/filter/append seem more timeless, whereas I'm still just feeling my way around with start_reading and start_writing. We'll see. For now I'm ruled by the fourth point. Messing with tasks and the scheduler is much more advanced than anything else in template.tlv; it seems to make sense to add some friction to modifying them. Bottomline: Complex sub-systems go in .lua files. Simple, self-contained definitions go into apps. Both are probably equally burdensome now from a compatibility perspective.
* extract a helperKartik K. Agaram2022-03-061-1/+5
| | | | | | I'm starting to get quite indisciplined about where I introduce global bindings. Seems reasonable since any modules in Teliva will come from within the framework.
* use the new file API in most placesKartik K. Agaram2022-03-061-4/+6
| | | | | Really everywhere except zet.tlv. toot-toot is intended to emit throwaway files anyway.
* reconcile all apps with template.tlvKartik K. Agaram2022-03-068-436/+710
| | | | | | They may take more or less from it (sieve.tlv in particular takes nothing since call depth doesn't help at all there), but what they take is in the right order so that you can compare across apps.
* starting to convert all file reads to the new APIKartik K. Agaram2022-03-061-1/+1
| | | | | For starters, this detail was puzzling when I returned to the Game of Life app.
* a simple hack to make caller apparentKartik K. Agaram2022-03-052-6/+8
| | | | | | | | | | | | | | | | | | | | Teliva isn't yet smart enough to know the caller of an indirect function where the function being called goes through a local variable. I'd expected fixing this to be a long death march. However, there's a shockingly easy fix: just make every indirect call go through an additional direct function call. My policy for zet.tlv was that function 'main' could open any file. This stopped working since I introduced spawn_main. But with this commit it's working again. I can also drop all my special-casing of 'main' since it's now a regular Lua call. We still can't rely on the caller of an indirect call. That affects start_reading and start_writing, which really need to be part of the framework.
* new API for file operationsKartik K. Agaram2022-03-054-40/+83
| | | | | | | | | | | | | | | | | | | | | File operations now always return a channel (or nil on error or permission denied). When start_reading() from a filename, you can repeatedly :recv() from the channel it returns. When :recv() returns nil, you're at the end of the file. Stop. When you start_writing() to a filename, you can repeatedly :send() to the channel it returns. When you're done writing, :close() the channel. Writes to the file won't be externally visible until you do. To make this work I'm now always starting up the scheduler, so I need to fix sieve.tlv. Transparently running the scheduler is an abstraction, and whenever I create an abstraction I always worry about how it might fail. There's a hopefully-clear error when you read past end of a file.
* anagrams.tlv: now fully responsiveKartik K. Agaram2022-03-052-19/+135
| | | | | | | | | If we press a key the computation now restarts instantly. There's no fiction of multi-threading in Teliva. If the application doesn't work right, it beach-balls. If it doesn't beach-ball under normal circumstances you're more certain it'll never beach-ball. It's more work up-front, but there's less variability in outcomes.
* some dead codeKartik K. Agaram2022-03-051-59/+0
|
* reliably exit on confirmationKartik K. Agaram2022-03-051-1/+5
| | | | | | | Until now you had to press ctrl-x twice in rapid succession to exit if an app turned on non-blocking keyboard with nodelay(true). This became particularly noticeable after the previous change to anagrams.tlv, which could no longer exit.
* fixup! no further confirmation once editing commencesKartik K. Agaram2022-03-051-0/+1
|
* anagrams.tlv: slightly more responsiveKartik K. Agaram2022-03-052-1/+31
| | | | | | | Now we cancel screen-painting if any key is pressed. However it looks like just computing the list of anagrams can take a long time.
* include caller in sandboxing messagesKartik K. Agaram2022-03-041-1/+1
|
* simplify permissions model for file operationsKartik K. Agaram2022-03-032-5/+5
| | | | | We don't care to distinguish modes like "rw" or "a+". An app is permitted to perform either just reads or both reads and writes.
* clearer copy for confirmation dialogKartik K. Agaram2022-03-031-1/+1
|
* basic support for testing writes to screenKartik K. Agaram2022-03-031-0/+73
|
* more unobtrusive skip messageKartik K. Agaram2022-03-031-1/+1
| | | | In particular, the periods looked like passing tests.
* no further confirmation once editing commencesKartik K. Agaram2022-03-031-1/+3
|
* ask for confirmation on _any_ teliva shortcutKartik K. Agaram2022-03-031-22/+33
| | | | | This feels more intrusive. Let's see how we like it. Will I start having ctrl-x ctrl-x in my muscle memory?
* experiment: drop -WshadowKartik K. Agaram2022-03-033-5/+5
| | | | | I'm totally fine with lexical scope in other languages. Why does it feel like such a big deal in C?
* fake keyboard constructorKartik K. Agaram2022-03-021-0/+34
|
* distinguish between window global and argKartik K. Agaram2022-03-0212-110/+110
|
* always ask for confirmation on exitKartik K. Agaram2022-03-011-2/+18
| | | | | Let's see if we can live with this rather than some way to let apps indicate if they want confirmation or not..
* zet.tlv: hotkeys are not alternativesKartik K. Agaram2022-02-271-18/+18
| | | | | In any case, I want the convention to be '|' for alternation. '/' is more likely to be a real hotkey.
* zet.tlv: streamline historyKartik K. Agaram2022-02-271-3029/+0
|
* starting to make Teliva apps more testableKartik K. Agaram2022-02-2712-129/+129
| | | | | | | | | | Tasteful apps should only perform side-effects through 'window' arguments rather than the 'curses' module directly. It's ok however to read constants like curses.A_NORMAL or curses.stdscr(). There are some limitations, unfortunately. Ncurses wasn't designed with testability in mind. For example, there's no way to curs_set or assume_default_colors without the 'curses' module. Oh well.
* always run unit tests for channels and tasksKartik K. Agaram2022-02-261-216/+210
|
* import https://github.com/majek/lua-channelsKartik K. Agaram2022-02-264-2/+1044
| | | | Also a little test program to demo channels in action.
* duplicate keypress on failing testKartik K. Agaram2022-02-261-1/+0
|
* readme tweakKartik K. Agaram2022-02-261-6/+7
|
* a little program for kids: anagrams of namesKartik K. Agaram2022-02-212-2/+398
|
* delete curses primitives to read whole linesKartik K. Agaram2022-02-213-77/+8
| | | | | | | | They make it seem like you can use them to create simple REPL apps, but you can't, because standard Teliva shortcuts won't work. I _could_ make them work by emulating them using getch(), but that feels like an unnecessary abstraction for now.
* stop letting apps change directoryKartik K. Agaram2022-02-202-2/+3
| | | | | | | | | | | | | | I introduced this ability when I packaged up the lfs directory, but it can enable apps to circumvent sandboxing rules in some situations. If you can socially engineer someone to allow reading a file called 'passwd' in the current directory, you can now change directory to /etc and read something sensitive. Protecting against stuff like this gets subtle. It's easy for people to create policies that aren't robust to changing directories. Requiring absolute paths is also pretty unfriendly. So the whole notion of current directory is perhaps implicit state that is confusing to manage. Fix it in the context of a single session.
* rewrite the section on Teliva's dependenciesKartik K. Agaram2022-02-191-3/+17
|
* Readme: move some sections around to flow betterKartik K. Agaram2022-02-191-26/+20
|
* starting a few Readme tweaksKartik K. Agaram2022-02-191-4/+0
| | | | For starters, drop some redundant prose here.
* bring back pcall and xpcallKartik K. Agaram2022-02-181-0/+24
| | | | They aren't evaluating strings after all.
* show app blurb in screenshotKartik K. Agaram2022-02-171-0/+0
|
* 'doc:blurb': a place to briefly describe an appKartik K. Agaram2022-02-179-1/+79
| | | | | | This is for what the app does, as opposed to 'doc:main', which is also intended to include commentary about the internal organization of the app.
* fix a conflicting keyboard shortcutKartik K. Agaram2022-02-171-2/+2
|
* disable non-portable ASan flagsKartik K. Agaram2022-02-161-2/+2
|
* fix chesstv.tlv after we introduced sandboxingKartik K. Agaram2022-02-121-0/+23
|
* zet.tlv: new shortcuts, mostly for the editorKartik K. Agaram2022-02-121-0/+3447
|
* zet.tlv: some more editor shortcutsKartik K. Agaram2022-02-122-2/+438
|
* stop aborting if audit log fills upKartik K. Agaram2022-02-121-10/+32
| | | | | | | | | | | | When I started logging getch() events (which are just to help the reader orient on the log), this suddenly became more urgent. Now the log is larger, and it's also a circular buffer that rolls back to the start when it fills up. The next failure mode will be if we see the buffer filled up with just getch() calls, reducing visibility over real file and network operations. In which case we'll need to start coalescing getch() events.
* zet.tlv: yet another bugfixKartik K. Agaram2022-02-111-0/+141
| | | | Need for tests growing more acute..
* fix build on Mac OSKartik K. Agaram2022-02-102-0/+3
|