about summary refs log tree commit diff stats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* start showing call stack on errorsKartik K. Agaram2021-12-042-47/+64
| | | | | | | | It turns out Lua has been providing us this information all along! I'd just not created the space on screen to show it. Make it persist better. Kilo now no longer tracks its own status messages, which is a regression in a rare condition.
* another fix for colorsKartik K. Agaram2021-12-031-2/+2
| | | | | I'd assumed that assume_default_colors updates fg/bg -1, but it doesn't. Looks like I can't ever use -1 colors.
* support the comment/uncomment hotkey on MacsKartik K. Agaram2021-12-032-2/+3
| | | | | | | ^/ works on Linux but not on Mac ^- emits the same character code on Mac ^_ seems to be the underlying character code, and works on both ctrl-7 also emits the same character code
* less ambiguous menusKartik K. Agaram2021-12-032-9/+9
| | | | | Doesn't make sense to use '/' as a delimiter when we have hotkeys involving '/'.
* get rid of `Esc` hotkeyKartik K. Agaram2021-12-033-10/+9
| | | | | For a variety of historical reasons, terminals pause every time you press `Esc`. Let's get rid of that lag.
* typosKartik K. Agaram2021-12-031-3/+3
|
* experimenting with different keysKartik K. Agaram2021-12-031-0/+2
| | | | | | | | | | | | | | On a Thinkpad X13, the `delete` key emits `^[[3~` outside of Teliva. Within Teliva, ncurses converts it to character code 330 (0x14a), which it fails to recognize as KEY_BACKSPACE. Why? My backspace is converted to character code 263, which ncurses does recognize as KEY_BACKSPACE. ctrl-h is character code 8. Both 330 and 263 are valid Unicode code points, which feels really ugly and ambiguous.
* stop showing frequent save messagesKartik K. Agaram2021-12-031-1/+1
|
* show ^h in a couple more menusKartik K. Agaram2021-12-031-0/+2
|
* improve support for backspaceKartik K. Agaram2021-12-033-18/+15
| | | | | | | I still don't understand the entire state space here, so I'm trying to err on the side of improving discoverability of the `ctrl-h` escape hatch. Without requiring too wide a window to show all hotkeys on the menu.
* error message when no app is providedKartik K. Agaram2021-12-031-194/+6
| | | | Also strip out a bunch of Lua's commandline parsing.
* .Kartik K. Agaram2021-12-031-2/+3
|
* legible colors across all terminal configurationsKartik K. Agaram2021-12-031-1/+1
| | | | | | | | | | | | | So far I've been trying to make Teliva follow the default colorscheme of the terminal, but that easily ends up with illegible color combinations. New plan: always start with a light background within Teliva. People who want a dark background will currently need to mess with C sources. This should somewhat fix https://github.com/akkartik/teliva/issues/1. It's still not clear whether the default should be a dark or light background. While dark background is more common in terminals, I believe newcomers to terminals will prefer a light background. Then again, I'm biased since I use a light background in my terminals.
* show state of screen on runtime errorKartik K. Agaram2021-12-031-0/+7
| | | | This is essential when debugging.
* .Kartik K. Agaram2021-12-031-1/+1
|
* extract a helperKartik K. Agaram2021-12-031-18/+32
|
* fix a slight portability issue, maybeKartik K. Agaram2021-12-021-1/+1
| | | | | | | | When installing using NixOS[1], the screen looks wrong. It looks like attrset(A_NORMAL) does not undo color changes with some versions of dependencies. [1] https://github.com/marianoguerra/marianoguerra.github.io/blob/master/advent-of-future-of-code/days/day-02.md
* stop inserting ctrl- keys into programsKartik K. Agaram2021-11-301-4/+2
|
* better cross-platform backspace supportKartik K. Agaram2021-11-302-4/+10
| | | | | | | | I wish I could just hide KEY_BACKSPACE and prevent myself from using it by accident. Then again, I'm not making this smarts available in Teliva programs themselves. Just for the Teliva environment.
* kilo bugfix: syntax highlight final word in lineKartik K. Agaram2021-11-291-1/+1
| | | | | Kilo likely never ran into this because it's only been tested on C, which uses semi-colons at the end of each statement.
* gotcha: silent string concatenationKartik K. Agaram2021-11-291-1/+1
|
* .Kartik K. Agaram2021-11-291-7/+7
|
* a couple more global curses bindingsKartik K. Agaram2021-11-291-0/+3
|
* fix regression in showing error messagesKartik K. Agaram2021-11-291-4/+4
|
* .Kartik K. Agaram2021-11-291-2/+0
|
* let people fix bad images from within TelivaKartik K. Agaram2021-11-292-12/+28
| | | | | | | | | Short of syntax errors that keep us from parsing the teliva_program table, we should now be able to recover gracefully from everything. Yesterday I started to try to add this to load_definitions before realizing most errors are only noticed while running `main`. But I didn't think of recovering from the docall of `main` until this morning.
* redo uncommentKartik K. Agaram2021-11-281-5/+6
| | | | It was printing a phantom null at end of line on screen.
* auto-indentKartik K. Agaram2021-11-281-1/+7
|
* tab key: always insert two spacesKartik K. Agaram2021-11-281-0/+5
|
* hide some 'advanced' hotkeys to support narrow windowsKartik K. Agaram2021-11-281-4/+0
|
* ctrl-/ to comment/uncomment lineKartik K. Agaram2021-11-282-0/+28
|
* ctrl-u/ctrl-k to make editing a bit more ergonomicKartik K. Agaram2021-11-282-1/+18
|
* special indent settings for kiloKartik K. Agaram2021-11-281-0/+3
|
* indentKartik K. Agaram2021-11-281-40/+40
|
* mac backspace attempt 3Kartik K. Agaram2021-11-281-1/+1
|
* fix half-assed mac os backspace commitKartik K. Agaram2021-11-282-4/+4
|
* sacrificing another LoC to ward off crashesKartik K. Agaram2021-11-281-0/+1
| | | | | | It makes me very nervous now that there's save_editor_state within editor event loop, when the editor could be editing notes. Things are slightly better than this morning, but this prototype still suxxors.
* editing notes sucks a little lessKartik K. Agaram2021-11-282-4/+10
| | | | | | I think I've gotten rid of all the segfaults, but it's still pretty messed up: if you hit ctrl-g and go edit some definition, it doesn't get saved. You're just storing the edit in the note.
* fix the bug described in commit cec57992b7Kartik K. Agaram2021-11-281-4/+12
|
* rename a fn and reorganize its responsibilitiesKartik K. Agaram2021-11-281-3/+3
|
* split a lumpy abstraction into two cleaner onesKartik K. Agaram2021-11-281-13/+19
| | | | | | | | | | | | | | I'm mindful of the way abstractions can create duplicate effort: https://flak.tedunangst.com/post/browser-ktrace-browsing == Kartik's SAD theorem As programs grow complex, you will be repeatedly forced to either: - maintain some State, - perform some computations Again, - or Duplicate some code. Here a small amount of duplication seems like the best alternative. Particularly since no syscalls are involved.
* purge abstraction hiding teliva_editor_bufferKartik K. Agaram2021-11-281-10/+5
|
* inline another functionKartik K. Agaram2021-11-282-8/+2
| | | | | I'm going to give up on hiding teliva_editor_buffer from kilo. It was taking too much knowledge of extern function prototypes on both sides.
* take one responsibility away from edit_imageKartik K. Agaram2021-11-281-4/+4
| | | | Also rename it appropriately.
* .Kartik K. Agaram2021-11-281-1/+1
|
* inline an unnecessary functionKartik K. Agaram2021-11-281-7/+2
|
* start streamlining architectureKartik K. Agaram2021-11-282-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All the spaghetti is hiding another issue: when we load editor state, that code path currently never leads to importing the edited buffer back into the image. Yet another attempt at drawing the state diagram: Wgetch -> switch_to_editor -> select_view select_view -> load_editor_state | big_picture_view load_editor_state -> edit_from -> editorProcessKeypress big_picture_view -> edit_image -> edit_buffer -> resumeEdit* -> load_editor_buffer -> editorProcessKeypress big_picture_view -> recent_changes recent_changes -> big_picture_view | edit_buffer The problem is that load_editor_state doesn't eventually call load_editor_buffer the way its sibling big_picture_view does. For starters, it's confusing that switch_to_editor calls big_picture_view which calls other editor functions. What is 'editor' here, anyway? Let's rename switch_to_editor to developer_mode. So the app starts out in user mode, and might eventually transition to developer mode. Developer mode is a black hole; to leave it and return to user mode we restart the entire app. The architecture in my mind is now: - Teliva consists of user mode and developer mode - Developer mode consists of multiple views - Each view, when it needs to edit something: - initializes kilo - loads a buffer into it - resumes editing the buffer as necessary
* fix going to big picture after saving editor stateKartik K. Agaram2021-11-281-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | My code is already at spaghetti levels. Some coping mechanisms. === The big problem with the Teliva approach compared to my previous Mu project: no tests. At this point I should document the growing list of manual tests I've been maintaining: run a program run a program, edit run a program, edit, make an edit, run | edit takes effect run a program with error run a program, edit, make an error, run run a program, edit, ^g to a different definition, make an edit, ^e to run again run a program, edit, ^g to a non-existent definition run a program, edit, ^g to a different definition, ^g to a different definition, ^e to run again start -> big picture -> edit -> move cursor -> run -> edit | cursor preserved start -> big picture -> edit A -> move cursor -> big picture -> edit B | cursor initialized start -> big picture -> edit A -> move cursor -> run -> exit -> start -> big picture -> edit B | cursor initialized start -> big picture -> edit A -> move cursor -> run -> exit -> start -> big picture -> edit B -> big picture (*) syntax highlighting for line comments syntax highlighting for multiline comments (*) - fixed in this commit === Coarse-grained state diagram (ignoring recent_changes_view): app -> big picture on ^e big picture -> editor when selecting a definition editor -> app on e editor -> big picture on ^b Fine-grained sequence diagram: main -> pmain -> ... -> Wgetch -> switch_to_editor -> select_view select_view -> load_editor_state, falling through to big_picture_view if needed load_editor_state -> edit_from -> editorProcessKeypress The consequence I hadn't fully internalized was the return path: editorProcessKeypress -> edit_from -> big_picture_view Which implies that load_editor_state fails in two ways: - when the state doesn't exist or is not applicable or is corrupted - when editing from the state explicitly requested the big picture view Switching the return value semantics for load_editor_state now supports both ways.
* yet another fucking makefile bugKartik K. Agaram2021-11-281-1/+1
| | | | | | | | | | | | | | Making changes to lcurses directory was causing it to be compiled, but not causing teliva to be relinked. Now I'm: - unconditionally running `make` on subdirectories - conditionally linking their outputs Seems reasonable when I put it like that. Hopefully this is working now. I used to know `make` down cold a decade ago, but it's evaporated from my brain.
* clear editor state across user-visible restartsKartik K. Agaram2021-11-281-1/+3
| | | | | | | | | | | | | | | | Teliva's constantly restarting without the user being aware of it. So far I figured saving history across the user actually exiting and restarting Teliva was just a happy "feature". However, it looks like that's actually more complex to implement. Keeping editor state across user-visible restarts results in these problems: - opening the editor after restart has the cursor position messed up, no matter what definition you open. - more seriously, opening the editor after restart can't seem to get to the big-picture view anymore. Rather than try to debug what's going on, I'm going to just cordon off that part of the state space for now.
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-11-16 06:51:21 +0000