about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
...
* start writing some tests for drawingsKartik K. Agaram2022-06-142-1/+33
|
* .Kartik K. Agaram2022-06-141-2/+2
|
* extract variables for drawing paddingKartik K. Agaram2022-06-143-6/+10
|
* extract variable Margin_leftKartik K. Agaram2022-06-144-86/+81
|
* .Kartik K. Agaram2022-06-141-1/+0
|
* stop generating invalid keychordsKartik K. Agaram2022-06-141-0/+1
|
* some more manual tests related to drawingsKartik K. Agaram2022-06-141-0/+5
| | | | | In the process I notice an issue: we seem to be adding no-op undo records after every drawing operation.
* lots more testsKartik K. Agaram2022-06-142-32/+65
| | | | | | | I've been adding diligently to manual_tests but not actually _performing_ any manual tests before releases. They were just a todo list of automated tests to write, and long out of date. Now the list is up to date and much shorter.
* mouse buttons are integers, not stringsKartik K. Agaram2022-06-145-45/+45
| | | | | | Not sure where that idiom comes from or why strings work in some places (auto-coercion?). I picked it up off some example apps. But https://love2d.org/wiki/love.mouse.isDown says it should be an integer.
* answered an open questionKartik K. Agaram2022-06-141-1/+0
| | | | | The default font seems somehow different than the font created by newFont with just a font size.
* go through and fix similar issuesKartik K. Agaram2022-06-142-6/+19
| | | | All places where string.sub was being passed a _pos variable.
* cleanupKartik K. Agaram2022-06-141-6/+0
|
* bugfixKartik K. Agaram2022-06-143-4/+46
| | | | | | | | | | | | | | | | | | | | | | | manifestation: clicking past end of a long, wrapping line containing non-ASCII would cause the cursor to disappear rather than position past end of screen line. Hitting enter would then throw an assertion with the following stack trace: Error: text.lua:381: bad argument #2 to 'sub' (number expected, got nil) stack traceback: [love "boot.lua"]:345: in function <[love "boot.lua"]:341> [C]: in function 'sub' text.lua:381: in function 'insert_return' text.lua:179: in function 'keychord_pressed' main.lua:495: in function 'keychord_pressed' keychord.lua:10: in function <keychord.lua:5> app.lua:34: in function <app.lua:25> [C]: in function 'xpcall' cause: the click caused a call to Text.to_pos_on_line whose result was not on a UTF-8 character boundary. fix: make to_pos_on_line utf8-aware.
* bugfix: UTF-8 in compute_fragmentsKartik K. Agaram2022-06-143-5/+27
|
* .Kartik K. Agaram2022-06-141-2/+2
|
* new testKartik K. Agaram2022-06-122-0/+26
| | | | | For commit e4e12c77ad which fixed a regression caused by commit 24a0d162ef.
* new testKartik K. Agaram2022-06-121-0/+12
| | | | | | | | | | For commit ff88a2a927 which fixed a regression caused by commit e51ce12969. I'm trying to provide enough guardrails for myself and future readers without causing a combinatorial explosion in tests. The previous commit was able to get more value out of existing tests, but this test feels necessary. And useful in general without reference to a specific bug.
* override mouse state lookups in testsKartik K. Agaram2022-06-126-76/+113
| | | | | | | If I'd had this stuff in my test harness earlier, two recent commits would have failed tests and given me early warning: ff88238ff1 ff88a2a927
* delete all tests once they've executedKartik K. Agaram2022-06-121-0/+4
|
* redundant checkKartik K. Agaram2022-06-121-4/+2
|
* fix a second BSOD in #4 :/Kartik K. Agaram2022-06-121-1/+1
| | | | I need more tests.
* bugfix in commit e51ce12969Kartik K. Agaram2022-06-121-4/+6
| | | | | | | | | Any time I press a ctrl- chord LÖVE actually sees two key chords: C-lctrl C-... (the real one) But it's not just that. There's also a lot in the codebase that's just habit-based. I need more tests.
* bugfix: BSOD in #4.Kartik K. Agaram2022-06-112-4/+4
| | | | I messed up a function call in commit 391d764e13.
* bugfix: autosave and undo in a couple of casesKartik K. Agaram2022-06-111-0/+6
| | | | This fixes part of #4, but not the BSOD.
* bugfix: missed fixing a callsiteKartik K. Agaram2022-06-111-1/+1
|
* .Kartik K. Agaram2022-06-111-1/+1
|
* things seem to feel snappier nowKartik K. Agaram2022-06-101-6/+2
| | | | | However, I think a lot of the benefit comes from just turning JIT off. Turning it on is still noticably sluggish.
* stop handling nil screen_line_starting_pos everywhereKartik K. Agaram2022-06-102-24/+6
| | | | Things seem to be working..
* this fixes the immediate regressionKartik K. Agaram2022-06-101-19/+17
|
* stop repeatedly checking for line wrappingKartik K. Agaram2022-06-101-7/+8
| | | | | | We have a regression since we started reclaiming love Text fragments more aggressively in commit 69c5d844ccc. Pressing pageup no longer knows about any line's screen lines. Not fixed yet.
* slight reorg in ReadmeKartik K. Agaram2022-06-101-2/+4
|
* more precise scroll on pasteKartik K. Agaram2022-06-101-19/+4
|
* faster pasteKartik K. Agaram2022-06-102-13/+11
| | | | | We don't need to perform the scroll calculations after inserting every single character from the clipboard.
* revert previous commitKartik K. Agaram2022-06-101-5/+15
|
* experiment: extremely precise scrolling on pasteKartik K. Agaram2022-06-101-15/+5
| | | | But this is too slow.
* clean up memory leak experimentsKartik K. Agaram2022-06-102-517/+0
|
* while we're at it, undo naming pointsKartik K. Agaram2022-06-101-0/+2
|
* set current_drawing_index with current_drawingKartik K. Agaram2022-06-101-3/+6
|
* include drawing index in a few placesKartik K. Agaram2022-06-101-15/+15
|
* .Kartik K. Agaram2022-06-101-1/+1
|
* stop saving the entire file when modifying drawingsKartik K. Agaram2022-06-103-11/+10
| | | | Now we just disallow that entirely.
* undo creating new drawingsKartik K. Agaram2022-06-102-1/+8
|
* extract scrolling logic out of insert_at_cursorKartik K. Agaram2022-06-102-6/+18
|
* extract scrolling logic out of insert_returnKartik K. Agaram2022-06-102-4/+6
|
* remove some memory leaks from rendered fragmentsKartik K. Agaram2022-06-105-0/+2672
| | | | | | | | | | | | | | | All signs so far seem to be that CPU is cheap for this application, but memory is expensive. It's easy to get sluggish if the GC comes on. After some experiments using https://github.com/yaukeywang/LuaMemorySnapshotDump, one source of memory leaks is rendered fragments (https://love2d.org/wiki/Text objects). I need to render text in approximately word-sized fragments to mostly break lines more intelligently at word boundaries. I've attached the files I used for my experiments (suffixed with a '.') There's definitely still a leak in fragments. The longer I edit, the more memory goes to them.
* avoid some string concatenationsKartik K. Agaram2022-06-101-6/+6
| | | | | | | | file:write can write multiple args one after another; no need to concatenate them first. I'm starting to pay attention to memory usage after the experience of turning off the JIT.
* include a unit testKartik K. Agaram2022-06-091-0/+17
|
* bugfix: cut (C-x) without first selecting anythingKartik K. Agaram2022-06-092-0/+5
|
* fix a corner case when selecting textKartik K. Agaram2022-06-092-9/+51
| | | | | The hard part here is keeping click-drag selection working (without pressing and holding shift).
* moveKartik K. Agaram2022-06-091-4/+4
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-12-25 14:57:42 +0000