about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
...
* better fix for commit 3ffc2ed8fKartik K. Agaram2022-06-201-0/+1
| | | | | | | | | I'm giving up finding a more generalized solution. The issue is that we need the correct selection state right up to the point where we modify Lines, in order to capture precise undo state. Hopefully there aren't any other keychords that should clear the selection.
* revert selection logic to before commit 3ffc2ed8fKartik K. Agaram2022-06-203-8/+12
| | | | | We still have a failing test, but now it's the one we introduced in commit 3ffc2ed8f.
* snapshot: test for a new regressionKartik K. Agaram2022-06-201-0/+22
| | | | | | Caused by commit 3ffc2ed8f. We might need to bring back a lot of complexity for this.
* selection bugfixKartik K. Agaram2022-06-202-1/+19
|
* much simplerKartik K. Agaram2022-06-202-31/+8
| | | | | | | | We just need to ensure textinput events never make use of selection state. All tests are passing, but I'm aware of a couple of issues. But now we can keep all the special cases in one place.
* some early returns should be assertsKartik K. Agaram2022-06-201-1/+3
|
* move Selection1 clearing past business logicKartik K. Agaram2022-06-201-10/+10
| | | | | | Now all the cases that clear Selection1 do so in a very consistent way at the end of each case. And cases that set Selection1 symmetrically do so at the start of each case.
* remove some redundant checksKartik K. Agaram2022-06-201-30/+10
| | | | Now all the cases manage Selection1 similarly.
* no, that's not rightKartik K. Agaram2022-06-203-3/+40
| | | | | | | | | | | | | | Bugfix: we want selections to persist even when we lift up the shift key. This requires hoisting some code inside every case inside the whole keypress hierarchy, to ensure we never clear selections before textinput events can handle them. Current cross-cutting concerns we're explicitly scattering code for. - autosave - undo - selection management
* bugfix: typing should delete highlighted textKartik K. Agaram2022-06-203-9/+29
| | | | The test harness now also mimics real usage more precisely.
* clearer copyKartik K. Agaram2022-06-201-2/+3
|
* bugfixKartik K. Agaram2022-06-193-1/+27
| | | | | | | | | | | | | | | To reproduce: click to position cursor at end of a line hit enter press any key before: newline got erased and key got added to previous line now: newline is preserved The new test checks a generalization of this.
* bugfix: crash in Text.up() after returnKartik K. Agaram2022-06-193-38/+31
| | | | Let's just make all the utf8.offset calculations more defensive.
* typosKartik K. Agaram2022-06-191-2/+2
|
* fix help for rectangles and squaresKartik K. Agaram2022-06-181-0/+20
| | | | Thanks John Blommers (https://github.com/akkartik/lines.love/issues/1#issuecomment-1159582457)
* make sure to save right when quittingKartik K. Agaram2022-06-181-0/+5
| | | | I just noticed a few characters missing from one of my notes.
* correct location of the line width sliderKartik K. Agaram2022-06-183-4/+5
|
* clean upKartik K. Agaram2022-06-173-30/+0
|
* more precise shape selectionKartik K. Agaram2022-06-172-7/+35
| | | | | | | It's important that the error be additive rather than multiplicative, otherwise the area grows asymmetrically along a line. Hopefully freehand drawings will work more intuitively now.
* correct commit f3abc2cbf2Kartik K. Agaram2022-06-173-10/+48
| | | | | | I can't be trusted to do anything without a test. This should fix #5. Please reopen if it doesn't.
* drop last couple of manual testsKartik K. Agaram2022-06-173-13/+32
|
* manual test for adjusting line widthKartik K. Agaram2022-06-171-0/+6
|
* .Kartik K. Agaram2022-06-171-1/+1
|
* better handle moving pointsKartik K. Agaram2022-06-172-15/+5
| | | | | This should hopefully address #5. I'm removing some constraints from manhattan lines, rectangles and squares.
* affordance to adjust width for word wrapKartik K. Agaram2022-06-172-1/+43
|
* indentKartik K. Agaram2022-06-171-4/+4
|
* autosave slightly less aggressivelyKartik K. Agaram2022-06-174-18/+72
| | | | | | | | It might reduce wear and tear on disk, and losing 3 seconds of data doesn't feel catastrophic (short of a C-z rampage). Thanks to the love2d.org community for the suggestion: https://love2d.org/forums/viewtopic.php?f=14&t=93173
* document one more shortcutKartik K. Agaram2022-06-171-0/+1
|
* tweak to ReadmeKartik K. Agaram2022-06-151-2/+2
|
* new fork for #1Kartik K. Agaram2022-06-151-0/+4
|
* bugfix: alignment of help screenKartik K. Agaram2022-06-151-33/+33
|
* dead codeKartik K. Agaram2022-06-151-45/+0
|
* moveKartik K. Agaram2022-06-151-28/+28
|
* .Kartik K. Agaram2022-06-151-6/+3
|
* stop recording points for arcsKartik K. Agaram2022-06-152-2/+1
| | | | | | It was kinda weird that we were recording the start but not the end. And moving the start point didn't actually affect the arc. Let's see if we actually ever need it.
* move current mode indicator slightlyKartik K. Agaram2022-06-151-2/+2
|
* standardize on ordering of casesKartik K. Agaram2022-06-151-9/+9
|
* .Kartik K. Agaram2022-06-141-3/+3
|
* all pending manual tests done!Kartik K. Agaram2022-06-142-7/+39
|
* test: undo moving pointKartik K. Agaram2022-06-142-1/+47
|
* test: undo naming a pointKartik K. Agaram2022-06-143-1/+45
| | | | Also ensure we autosave.
* test: autosave after name/move/delete of pointKartik K. Agaram2022-06-142-3/+22
|
* test: autosave after any shapeKartik K. Agaram2022-06-144-4/+43
|
* tests: deleting points/shapesKartik K. Agaram2022-06-141-1/+105
|
* test: moving a pointKartik K. Agaram2022-06-143-16/+44
| | | | | I found some code in the process that seems unreachable. Some chance of a regression here..
* test: naming a pointKartik K. Agaram2022-06-143-2/+39
|
* a little more prose describing manual_testsKartik K. Agaram2022-06-142-23/+30
|
* one less manual testKartik K. Agaram2022-06-141-1/+0
| | | | Still a few more we can write.
* drop non-existent feature from commentKartik K. Agaram2022-06-141-1/+0
|
* tests for drawing polygonsKartik K. Agaram2022-06-142-11/+180
|