Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove some unnecessary work | Kartik K. Agaram | 2022-08-17 | 1 | -1/+3 |
| | |||||
* | standardize scroll check in a few places | Kartik K. Agaram | 2022-08-17 | 1 | -3/+3 |
| | | | | | | | | | | | | I'm taking some lessons from pensieve.love here. It seem like specific pixel thresholds don't matter too much for plain lines.love. I'd probably feel safer if I just used Text.cursor_out_of_screen in these places, but it means we draw the screen twice for most events[1]. Let's see if we can get by with the current approach. [1] Or we have to start scheduling things for the next draw, which is more complex to orchestrate. | ||||
* | simplify cursor-on-screen check | Kartik K. Agaram | 2022-08-17 | 2 | -11/+9 |
| | |||||
* | swap return values | Kartik K. Agaram | 2022-08-17 | 3 | -8/+8 |
| | |||||
* | obsolete comment | Kartik K. Agaram | 2022-08-16 | 1 | -2/+0 |
| | |||||
* | move | Kartik K. Agaram | 2022-08-15 | 1 | -28/+28 |
| | |||||
* | drop some unnecessary calls | Kartik K. Agaram | 2022-08-15 | 1 | -6/+0 |
| | |||||
* | stop confusingly reading a global | Kartik K. Agaram | 2022-08-15 | 1 | -2/+2 |
| | | | | | | | The way Text.draw is called by edit.draw, we know it'll never be called for lines above screen_top1.line. Comparing every line on screen with screen_top1 makes no sense. The intent is really just to compare with screen_top1 only for the first line, and otherwise to ignore this check. | ||||
* | new mirror | Kartik K. Agaram | 2022-08-14 | 1 | -0/+1 |
| | |||||
* | more cogent onboarding instructions | Kartik K. Agaram | 2022-08-14 | 1 | -4/+7 |
| | | | | Someone looking at the repo will probably prefer the terminal. | ||||
* | remove some duplication | Kartik K. Agaram | 2022-08-14 | 2 | -13/+8 |
| | |||||
* | bugfix: obsolete location for attribute | Kartik K. Agaram | 2022-08-14 | 1 | -2/+2 |
| | |||||
* | overzealous search-and-replace | Kartik K. Agaram | 2022-08-13 | 1 | -1/+1 |
| | |||||
* | bugfix: check after cursor on same line when searching upwards | Kartik K. Agaram | 2022-08-11 | 2 | -1/+28 |
| | |||||
* | search: transparently handle drawings everywhere | Kartik K. Agaram | 2022-08-11 | 1 | -22/+18 |
| | |||||
* | bugfix: search upwards | Kartik K. Agaram | 2022-08-11 | 2 | -1/+20 |
| | |||||
* | bugfix: check before cursor on same line | Kartik K. Agaram | 2022-08-11 | 2 | -1/+31 |
| | |||||
* | bugfix: handle drawings when updating screen top | Kartik K. Agaram | 2022-08-11 | 1 | -0/+1 |
| | |||||
* | rename | Kartik K. Agaram | 2022-08-11 | 1 | -24/+24 |
| | |||||
* | bugfix: pagedown was sometimes bouncing up | Kartik K. Agaram | 2022-08-10 | 2 | -1/+18 |
| | |||||
* | bugfix: backspace from start of final line | Kartik K. Agaram | 2022-08-10 | 2 | -1/+21 |
| | |||||
* | unnecessary args | Kartik K. Agaram | 2022-08-10 | 1 | -1/+1 |
| | |||||
* | hardcode some assumptions about how this app uses love | Kartik K. Agaram | 2022-08-06 | 1 | -18/+11 |
| | |||||
* | bugfix: imprecision in drawing | Kartik K. Agaram | 2022-08-03 | 2 | -0/+4 |
| | | | | | | | | | | | scenario: slowly press down mouse button and drag to draw a line release mouse button Before this commit the point would jump just a little bit on release, and points would go slightly to the left of where I expect. Yet another thing it's hard to write an automated test for. | ||||
* | round one coordinate | Kartik K. Agaram | 2022-07-30 | 1 | -1/+1 |
| | |||||
* | round coordinates to integers in a few places | Kartik K. Agaram | 2022-07-29 | 1 | -7/+11 |
| | | | | | | | | | | | | | Thanks Lion Kimbro for pointing out this issue. I still have to use floats for start/end angles of arcs. That might be a sign that I don't have the right serialization yet for them. Or that that feature needs to go. I started out with a hazy idea of only using 8-bit ints for coordinates, but now I'm not sure how committed I am to that constraint. While the width is always 256 units, it might be nice to create long portrait drawings at some point, whose height is greater than 256 units. | ||||
* | click to the left of a line | Kartik K. Agaram | 2022-07-29 | 4 | -4/+28 |
| | |||||
* | copying to clipboard can never scroll | Kartik K. Agaram | 2022-07-27 | 1 | -1/+0 |
| | |||||
* | line.y -> line_cache.starty in a few more places | Kartik K. Agaram | 2022-07-27 | 3 | -14/+14 |
| | | | | | | Disquieting that none of my tests caught these. On the other hand, I also haven't noticed any issues in practice. Perhaps cache invalidation is often unnecessary. | ||||
* | have file API operate on state object | Kartik K. Agaram | 2022-07-25 | 4 | -21/+20 |
| | |||||
* | update cursor in search box | Kartik K. Agaram | 2022-07-25 | 1 | -3/+1 |
| | |||||
* | bugfix: alt-tab shouldn't emit keypress events | Kartik K. Agaram | 2022-07-25 | 1 | -1/+20 |
| | | | | | Looks like this only happens on Linux: https://love2d.org/forums/viewtopic.php?p=249700 | ||||
* | move | Kartik K. Agaram | 2022-07-25 | 1 | -2/+3 |
| | |||||
* | simplify hysteresis logic | Kartik K. Agaram | 2022-07-25 | 1 | -8/+3 |
| | |||||
* | bugfix: skip over drawings when searching | Kartik K. Agaram | 2022-07-25 | 2 | -15/+17 |
| | |||||
* | extract method | Kartik K. Agaram | 2022-07-23 | 2 | -14/+13 |
| | |||||
* | bugfix: online help | Kartik K. Agaram | 2022-07-22 | 2 | -8/+12 |
| | | | | Broken in the commit before last. | ||||
* | bugfix: search | Kartik K. Agaram | 2022-07-21 | 2 | -1/+34 |
| | | | | | Broken since commit 188bbc73 9 days ago :/ At least we have a test for it now. | ||||
* | move drawing.starty into line cache | Kartik K. Agaram | 2022-07-20 | 3 | -60/+71 |
| | |||||
* | use line cache for drawings as well | Kartik K. Agaram | 2022-07-20 | 3 | -31/+31 |
| | |||||
* | bugfix: where cursor is drawn | Kartik K. Agaram | 2022-07-20 | 3 | -14/+25 |
| | | | | | | | The published version of lines.love was broken for almost an hour. The cursor would render one position to the right of where it really is. To fix it, this commit rolls back 26ba6e4e5a71. There doesn't seem a good way to test it. | ||||
* | reorg manual tests doc | Kartik K. Agaram | 2022-07-20 | 1 | -9/+7 |
| | |||||
* | . | Kartik K. Agaram | 2022-07-20 | 1 | -0/+2 |
| | |||||
* | exclude left margin from my word-split heuristic | Kartik K. Agaram | 2022-07-20 | 2 | -3/+3 |
| | | | | | Gratifying how few tests need changing. Recent commits seem on the right track. | ||||
* | allow Text.nearest_pos_less_than to return 0 | Kartik K. Agaram | 2022-07-20 | 2 | -7/+4 |
| | | | | This eliminates another case of overflowing margins. | ||||
* | drop an unnecessary level of indent | Kartik K. Agaram | 2022-07-20 | 1 | -23/+21 |
| | |||||
* | clean up some prints | Kartik K. Agaram | 2022-07-20 | 1 | -17/+10 |
| | | | | | (Looking at prints in Text.draw, Text.compute_fragments and Text.nearest_pos_less_than) | ||||
* | move a var closer to its use | Kartik K. Agaram | 2022-07-20 | 1 | -2/+2 |
| | |||||
* | more clearly skip prints before screen top | Kartik K. Agaram | 2022-07-20 | 1 | -21/+19 |
| | |||||
* | unify two similar functions | Kartik K. Agaram | 2022-07-19 | 2 | -24/+16 |
| | | | | | | The cost is just having to tweak a few more brittle tests. I can't actually perceive any difference in how the cursor moves when I click on text. |