about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
...
| * pass all button params to the iconKartik K. Agaram2022-08-232-2/+3
| |
| * allow buttons to nest as wellKartik K. Agaram2022-08-231-2/+11
| |
| * flip return value of button handlersKartik K. Agaram2022-08-232-6/+4
| | | | | | | | | | | | This is compatible with Javascript, and it also seems like a better default; when people forget to think about return values in click handlers, they should be consumed.
| * stop putting button state in a globalKartik K. Agaram2022-08-233-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Symptom: a test (test_click_to_create_drawing) started randomly failing after I inserted a `return` 2 commits ago. Cause: my tests call edit.draw, but button handlers only get cleared in app.draw. So my tests weren't clearing button handlers, and every call to edit.draw was accumulating states. Still unclear why those were going to different state objects after the `return`, but anyway. I'm not going to understand every last thing that happens when things go wrong, just guarantee they can't go wrong. And the way to do that is to decentralize button handlers to each state that receives them. The State object in buttons.lua doesn't have to be Editor_state. It just has to be some table that provides a Schelling Point for shared state.
| * improve explanation for buttonsKartik K. Agaram2022-08-231-1/+4
| |
| * allow buttons to interrupt eventsKartik K. Agaram2022-08-232-2/+6
| | | | | | | | Most button onpress1 handlers will want to return true.
| * indentKartik K. Agaram2022-08-231-1/+3
| |
| * distinguish consistently between mouse buttons and other buttonsKartik K. Agaram2022-08-233-30/+30
| |
* | Merge lines.loveKartik K. Agaram2022-08-220-0/+0
|\|
| * include pensieve.love even though it's in developmentKartik K. Agaram2022-08-221-0/+5
| |
* | Merge lines.loveKartik K. Agaram2022-08-212-1/+4
|\| | | | | | | Bring forks up to date.
| * include a forkKartik K. Agaram2022-08-211-0/+2
| |
| * correct a commentKartik K. Agaram2022-08-211-1/+1
| | | | | | | | We no longer have undo history directly in globals.
* | Merge lines.loveKartik K. Agaram2022-08-192-0/+3
|\|
| * regression: dropping files on the windowKartik K. Agaram2022-08-192-0/+3
| | | | | | | | Also improve the test to catch this next time.
* | Merge lines.loveKartik K. Agaram2022-08-192-4/+6
|\|
| * fix a nameKartik K. Agaram2022-08-191-4/+4
| |
| * reclaim a couple more functions after testsKartik K. Agaram2022-08-191-0/+2
| |
* | Merge lines.loveKartik K. Agaram2022-08-181-2/+2
|\|
| * couple of accidental globalsKartik K. Agaram2022-08-181-2/+2
| | | | | | | | Luckily they didn't bite me yet.
* | Merge lines.loveKartik K. Agaram2022-08-184-52/+41
|\|
| * get rid of some ridiculous codeKartik K. Agaram2022-08-181-15/+5
| | | | | | | | | | | | I guess I wrote it before I settled into the idiom of: * first change cursor * then scroll if necessary
| * spurious argsKartik K. Agaram2022-08-181-18/+18
| |
| * dead codeKartik K. Agaram2022-08-181-2/+0
| |
| * generalize a functionKartik K. Agaram2022-08-183-12/+13
| |
| * drop some obsolete argsKartik K. Agaram2022-08-181-2/+2
| |
| * subsection headings in a long switchKartik K. Agaram2022-08-181-0/+2
| |
| * extract a variableKartik K. Agaram2022-08-181-2/+3
| |
| * simplifyKartik K. Agaram2022-08-181-4/+1
| |
* | Merge lines.loveKartik K. Agaram2022-08-171-5/+2
|\|
| * simpler location comparisonKartik K. Agaram2022-08-171-5/+2
| |
* | Merge lines.loveKartik K. Agaram2022-08-171-4/+5
|\|
| * move caching behavior inside compute_fragmentsKartik K. Agaram2022-08-171-6/+6
| |
| * remove some unnecessary workKartik K. Agaram2022-08-171-1/+3
| |
* | Merge lines.loveKartik K. Agaram2022-08-172-14/+12
|\|
| * standardize scroll check in a few placesKartik K. Agaram2022-08-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | I'm taking some lessons from pensieve.love here. It seem like specific pixel thresholds don't matter too much for plain lines.love. I'd probably feel safer if I just used Text.cursor_out_of_screen in these places, but it means we draw the screen twice for most events[1]. Let's see if we can get by with the current approach. [1] Or we have to start scheduling things for the next draw, which is more complex to orchestrate.
| * simplify cursor-on-screen checkKartik K. Agaram2022-08-172-11/+9
| |
* | Merge lines.loveKartik K. Agaram2022-08-173-8/+8
|\|
| * swap return valuesKartik K. Agaram2022-08-173-8/+8
| |
* | Merge lines.loveKartik K. Agaram2022-08-171-2/+0
|\|
| * obsolete commentKartik K. Agaram2022-08-161-2/+0
| |
* | titleKartik K. Agaram2022-08-151-2/+2
| |
* | Merge lines.loveKartik K. Agaram2022-08-151-27/+27
|\| | | | | | | | | (I'm going to change the format of these commits to be more useful in the presence of more than one level of upstream.)
| * moveKartik K. Agaram2022-08-151-28/+28
| |
* | Merge upstreamKartik K. Agaram2022-08-151-8/+2
|\|
| * drop some unnecessary callsKartik K. Agaram2022-08-151-6/+0
| |
| * stop confusingly reading a globalKartik K. Agaram2022-08-151-2/+2
| | | | | | | | | | | | | | The way Text.draw is called by edit.draw, we know it'll never be called for lines above screen_top1.line. Comparing every line on screen with screen_top1 makes no sense. The intent is really just to compare with screen_top1 only for the first line, and otherwise to ignore this check.
* | bring back a level of wrappingKartik K. Agaram2022-08-158-96/+97
| | | | | | | | | | Many projects will require the ability to add metadata to lines, so let's not drop that.
* | superfluous lineKartik K. Agaram2022-08-151-1/+0
| |
* | clean up a few more loose endsKartik K. Agaram2022-08-143-25/+0
| |
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-12-27 22:23:10 +0000