about summary refs log tree commit diff stats
path: root/edit.lua
Commit message (Collapse)AuthorAgeFilesLines
* bugfixKartik K. Agaram2022-12-241-1/+1
| | | | | | | | | | | Scenario: make some edits, select some text, make some more edits. Press ctrl-z. Before this commit, undo would stop at the point of selection and previous edits would become unreachable. After this commit, both ctrl-z and ctrl-y seem able to span the point of selection.
* typoKartik K. Agaram2022-12-241-1/+1
|
* consistent names in a few more placesKartik K. Agaram2022-12-231-4/+4
|
* make love event names consistentKartik K. Agaram2022-12-231-19/+19
| | | | | I want the words to be easy to read, and to use a consistent tense. update and focus seem more timeless; let's make everything like those.
* require editor margins to be intsKartik K. Agaram2022-12-231-2/+2
| | | | | | | | | | | | Not directly relevant here, but forks of this project that permit zooming can run into weird glitches if margins are not a whole number of pixels. I'd always assumed a type system that divided ints into floats was strictly superior, but now I have experienced a situation where requiring ints isn't just a compromise for the underlying CPU implementation. Particularly since Lua's print() silently hides really tiny fractions.
* bugfix in changing shape mid-strokeKartik K. Agaram2022-12-121-2/+5
|
* bugfix: naming points in drawingsKartik K. Agaram2022-12-121-1/+6
| | | | | | | | | We had a regression since commit 60e1023f0 on Nov 27. Turns out we do need the ancient hack after all. But no, we won't go back to the hack. It's a simple problem to fix right. And while we're at it, we'll fix the test harness to be more realistic so it would have caught this problem.
* bugfixKartik K. Agaram2022-11-271-1/+1
|
* ctrl+a: select entire bufferKartik K. Agaram2022-11-191-1/+4
|
* stop tracking wallclock timeKartik K. Agaram2022-11-031-2/+2
| | | | We only need time differences.
* bugfix: path munging on WindowsKartik K. Agaram2022-09-101-1/+1
|
* self-documenting 0 Test_right_marginKartik K. Agaram2022-09-071-1/+4
|
* support drawings in the source editorKartik K. Agaram2022-09-051-3/+5
|
* editing source code from within the appKartik K. Agaram2022-09-031-9/+0
| | | | | integrated from pong.love via text.love: https://merveilles.town/@akkartik/108933336531898243
* infrastructure for caching LÖVE text objectsKartik K. Agaram2022-08-241-0/+1
|
* flip return value of button handlersKartik K. Agaram2022-08-231-2/+1
| | | | | | This is compatible with Javascript, and it also seems like a better default; when people forget to think about return values in click handlers, they should be consumed.
* stop putting button state in a globalKartik K. Agaram2022-08-231-2/+3
| | | | | | | | | | | | | | | | Symptom: a test (test_click_to_create_drawing) started randomly failing after I inserted a `return` 2 commits ago. Cause: my tests call edit.draw, but button handlers only get cleared in app.draw. So my tests weren't clearing button handlers, and every call to edit.draw was accumulating states. Still unclear why those were going to different state objects after the `return`, but anyway. I'm not going to understand every last thing that happens when things go wrong, just guarantee they can't go wrong. And the way to do that is to decentralize button handlers to each state that receives them. The State object in buttons.lua doesn't have to be Editor_state. It just has to be some table that provides a Schelling Point for shared state.
* allow buttons to interrupt eventsKartik K. Agaram2022-08-231-1/+5
| | | | Most button onpress1 handlers will want to return true.
* distinguish consistently between mouse buttons and other buttonsKartik K. Agaram2022-08-231-11/+11
|
* subsection headings in a long switchKartik K. Agaram2022-08-181-0/+2
|
* simplify cursor-on-screen checkKartik K. Agaram2022-08-171-5/+3
|
* remove some duplicationKartik K. Agaram2022-08-141-6/+4
|
* bugfix: obsolete location for attributeKartik K. Agaram2022-08-141-2/+2
|
* click to the left of a lineKartik K. Agaram2022-07-291-2/+4
|
* copying to clipboard can never scrollKartik K. Agaram2022-07-271-1/+0
|
* line.y -> line_cache.starty in a few more placesKartik K. Agaram2022-07-271-8/+8
| | | | | | Disquieting that none of my tests caught these. On the other hand, I also haven't noticed any issues in practice. Perhaps cache invalidation is often unnecessary.
* have file API operate on state objectKartik K. Agaram2022-07-251-2/+2
|
* extract methodKartik K. Agaram2022-07-231-0/+11
|
* move drawing.starty into line cacheKartik K. Agaram2022-07-201-4/+4
|
* use line cache for drawings as wellKartik K. Agaram2022-07-201-4/+4
|
* separate data structure for each line's cache dataKartik K. Agaram2022-07-171-8/+13
| | | | I have no idea what the performance implications of this are..
* keep all text cache writes inside text.luaKartik K. Agaram2022-07-171-4/+3
|
* switch to line index in a functionKartik K. Agaram2022-07-171-2/+2
| | | | - Text.to_pos_on_line
* switch to line index in a functionKartik K. Agaram2022-07-171-2/+2
| | | | - Text.in_line
* drop some extra argsKartik K. Agaram2022-07-171-4/+4
|
* fold together two largely similar casesKartik K. Agaram2022-07-171-28/+23
|
* drop some redundant args from Text.drawKartik K. Agaram2022-07-171-3/+3
|
* formattingKartik K. Agaram2022-07-161-1/+1
|
* bring back a set of constantsKartik K. Agaram2022-07-161-7/+6
| | | | | It's starting to sink in that I don't want hard-coded constants inside objects.
* more precise nameKartik K. Agaram2022-07-151-3/+10
|
* make test initializations a little more obviousKartik K. Agaram2022-07-151-7/+17
|
* a bug I've never run intoKartik K. Agaram2022-07-131-2/+8
| | | | | | The previous commit was failing inside a test that I can't reproduce manually. Perhaps it's something about how often draw/update run in practice. Anyways, it's definitely uncovered a real issue.
* replace globals with args in a few functionsKartik K. Agaram2022-07-121-2/+2
| | | | | | | | | - Drawing.draw_shape - Drawing.draw_pending_shape - Drawing.in_drawing - Drawing.find_or_insert_point - Drawing.near - Drawing.pixels
* correct a mis-named thresholdKartik K. Agaram2022-07-121-0/+2
|
* deduce left/right from state where possibleKartik K. Agaram2022-07-121-1/+1
|
* left/right margin -> left/right coordinatesKartik K. Agaram2022-07-121-16/+19
| | | | | Editor state initialization now depends on window dimensions, so we have to more carefully orchestrate startup.
* add state arg to a few functionsKartik K. Agaram2022-07-121-1/+1
| | | | | | | - Drawing.current_drawing - Drawing.select_shape_at_mouse - Drawing.select_point_at_mouse - Drawing.select_drawing_at_mouse
* add state arg to a few functionsKartik K. Agaram2022-07-121-10/+10
| | | | | | | | | | | | | - Text.cursor_at_final_screen_line - Text.move_cursor_down_to_next_text_line_while_scrolling_again_if_necessary - Text.snap_cursor_to_bottom_of_screen - Text.in_line - Text.to_pos_on_line - Text.to2 - Text.to1 - Text.previous_screen_line - Text.tweak_screen_top_and_cursor - Text.redraw_all
* add state arg to a few functionsKartik K. Agaram2022-07-121-2/+2
| | | | | - Text.pos_at_start_of_cursor_screen_line - Text.cursor_past_screen_bottom
* add state arg to a few functionsKartik K. Agaram2022-07-121-3/+3
| | | | | - Text.search_next - Text.search_previous
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-12-26 03:31:17 +0000