| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
| |
Editor state initialization now depends on window dimensions, so we have
to more carefully orchestrate startup.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Text.cursor_at_final_screen_line
- Text.move_cursor_down_to_next_text_line_while_scrolling_again_if_necessary
- Text.snap_cursor_to_bottom_of_screen
- Text.in_line
- Text.to_pos_on_line
- Text.to2
- Text.to1
- Text.previous_screen_line
- Text.tweak_screen_top_and_cursor
- Text.redraw_all
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this commit, top-level edit functions:
- edit.draw
- edit.update
- edit.quit
- edit.mouse_pressed
- edit.mouse_released
- edit.textinput
- edit.keychord_pressed
- edit.key_released
|
| |
|
|
|
|
| |
We're still accessing them through a global. But we'll change that next.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Still lots to do, but the eventual hope is that this will make this
project's code easier to reuse from other LÖVE projects.
One gotcha: even as we start putting code more aggressively into nested
tables, tests must remain at the top-level. Otherwise they won't run.
|
|
|
|
|
| |
One advantage of this approach: we don't end up with multiple lexical
scopes containing duplicates of the same modules.
|
| |
|
| |
|
|
|
|
| |
- Text.snap_cursor_to_bottom_of_screen
|
|
|
|
| |
- Text.to_pos_on_line
|
| |
|
|
|
|
| |
- Text.in_line
|
|
|
|
|
|
|
|
|
| |
- Text.clip_selection
- Text.cut_selection
- Text.delete_selection
- Text.delete_selection_without_undo
- Text.mouse_pos
- Text.to_pos
|
|
|
|
|
|
|
|
|
|
|
| |
I have a set of changes that passes all tests, but I'm going to commit
them very carefully to ensure I don't miss any call-sites. In this
commit I'm adding the args to:
- Text.draw
- Text.tweak_screen_top_and_cursor
But calls within them don't yet pass them where they should. In this
manner I'm going to progress systematically from the top down.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Thanks Leonard Schütz for the report!
Failing scenario:
click to move cursor
hit backspace
First backspace wasn't being doing anything earlier.
|
|
|
|
| |
This is much nicer.
|
|
|
|
|
| |
I've been subtly finding myself waiting for the cursor to stop blinking
to see if I clicked on the right place.
|
|
|
|
|
| |
There's multiple ways to do this, only one of them is right, and I keep
forgetting what it is. Turn it into a method.
|
|
|
|
|
|
| |
This has been broken since commit b544e8c357 on May 17 :/
I'm just undoing that commit, which turns out to be completely
unnecessary. And adding a test.
|
|
|
|
| |
First idea: just leave it alone. Let's see how this works.
|
|
|
|
| |
Gracefully degrade if previously edited file shrinks.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
bugfix scenario:
press pageup
click somewhere near the bottom
Before this change the selection was flickering when doing this.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
We're still not reading them anywhere.
|
| |
|
|
|
|
| |
Let's try really hard to ignore the terminal.
|
|
|
|
|
| |
I'd hoped this would reduce the blocks of black while resizing, but it
doesn't seem to have made a difference.
|
| |
|
| |
|
|
|
|
|
|
|
| |
New plan:
- render text across the whole window
- let people resize the window to the desired line width
- save window size settings between sessions
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I can't believe I didn't catch this until now. All I had to do is open
MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout,
press page-down and click on the top screen line (or any screen line
containing the same line as the top screen line). Easy to catch with any
file containing lots of overly long lines, as happens in particular at
the start of Moby Dick.
I _had_ seen this problem before, but it seemed to disappear after
unrelated changes, and I convinced myself I'd fixed it as a side-effect.
The bug just failed to manifest if the top line happened to start at the
top of the screen. Scroll down a few pages in Moby Dick and the dialogue
starts and line length drops precipitously.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|