about summary refs log tree commit diff stats
path: root/main.lua
Commit message (Collapse)AuthorAgeFilesLines
* assert for a bug I saw a while ago but can no longer reproduceKartik K. Agaram2022-05-251-0/+1
| | | | | I saw screen_top not at start of screen line, but at cursor location in middle of line.
* no, make sure to compute line width after screen dimensionsKartik K. Agaram2022-05-251-4/+4
|
* couple more testsKartik K. Agaram2022-05-251-17/+19
| | | | Along with the App helpers needed for them.
* get rid of debug variablesKartik K. Agaram2022-05-231-9/+4
|
* keep one screen line of overlap on pagedownKartik K. Agaram2022-05-231-1/+1
| | | | | | | | | | | | | | | | | | | | I'm now extracting the concern of computing line.screen_line_starting_pos out of Text.draw. Earlier I had to make sure I ran through the whole line to compute screen_line_starting_pos, but that had the side-effect of updating Screen_bottom1.pos as well with lines that had never been rendered. In this process I hit my first bug due to an accidental global. It doesn't show up in the patch because I accidentally deleted a local declaration. (I thought I didn't need screen_line_starting_pos anymore, deleted everywhere, then brought it back everywhere from the bottom of the function up, but forgot to put back the very first occurrence.) The amount of yoyoing this caused between App.draw and Text.draw, I very much have spaghetti on my hands. Accidental globals are _terrible_ in a program with tests. Cross test contamination X-(
* a few tests for pageup, and a bugfixKartik K. Agaram2022-05-231-10/+18
| | | | It wasn't screen-line aware. Now it is.
* disable all debug printsKartik K. Agaram2022-05-231-2/+2
|
* .Kartik K. Agaram2022-05-231-1/+2
|
* couple of tests for cursor downKartik K. Agaram2022-05-231-2/+2
|
* bugfix: don't rely on Screen_bottom1 while scrollingKartik K. Agaram2022-05-231-1/+4
| | | | | Setting up the test just right to test the thing I want to test was a rube goldberg machine of constants.
* first successful pagedown test, first bug found by testKartik K. Agaram2022-05-231-7/+8
| | | | | | | | | | | | | | | | | | | I also really need to rethink how people debug my programs. My approach of inserting and deleting print() takes a lot of commitment. I need my old trace-based whitebox testing idea. However, in my past projects I never did figure out a good framework for tweaking how verbose a trace to emit. Perhaps that's too many knobs. Perhaps we just need a way to run a single test with the most verbose trace possible. Then it's just a matter of having the trace tell a coherent story? But even if the trace stays out of program output in that situation, it's still in the programmer's face in the _code_. Ugh. Current plan: ship program with maximum tests and zero commented-out prints. If you want to debug, insert prints. This is better than previous, text-mode, projects just by virtue of the stdout channel being dedicated to debug stuff.
* fold variables for screen dimensions into the app frameworkKartik K. Agaram2022-05-221-8/+8
|
* basic test-enabled frameworkKartik K. Agaram2022-05-221-26/+25
| | | | | Tests still have a lot of side-effects on the real screen. We'll gradually clean those up.
* renameKartik K. Agaram2022-05-221-1/+3
|
* beginnings of a test harnessKartik K. Agaram2022-05-221-0/+1
| | | | | | | | | | | | | | | | | | | I have no fucking idea what I'm doing. All I know is that there's still too many goddamn bugs[1]. Test motherfucking harness or bust. For starters this is just the default love.run from https://love2d.org/wiki/love.run [1] The following file crashes if you repeatedly press cursor-down: << a b c ```lines ``` x >>
* bugfix: printing the first part of a line at the bottom made it seem ↵Kartik K. Agaram2022-05-211-9/+17
| | | | | | non-wrapping Still lots wrong here.
* I feel confident now that page-down is working.Kartik K. Agaram2022-05-211-2/+3
|
* beginning of a new approach to scroll+wrapKartik K. Agaram2022-05-211-25/+31
| | | | | | | So far I've just changed how existing variables are organized, and put some scaffolding in place for dealing with the new types. Next up: rewriting the code for scrolling to something that feels more obviously correct.
* bugfix: escape key to hide online helpKartik K. Agaram2022-05-211-0/+6
|
* support for naming pointsKartik K. Agaram2022-05-211-0/+27
| | | | There's still an absence of affordance showing when you're in naming mode.
* keep cursor on screen when pressing 'down'Kartik K. Agaram2022-05-201-1/+1
|
* reduce ambitions a bit: page up/down need not start screen from the middle ↵Kartik K. Agaram2022-05-201-13/+14
| | | | | | of a line But we still have work to do for cursor up/down.
* ensure Filename is writable when opened outside a terminalKartik K. Agaram2022-05-201-1/+1
| | | | Thanks Jimmy Miller for reporting this.
* snapshot - no, that's all wrongKartik K. Agaram2022-05-201-9/+11
| | | | | I've been only thinking about up arrow when cursor is at top of screen. Hopefully this is better.
* new globals: draw partial screen line up topKartik K. Agaram2022-05-201-0/+3
| | | | | I'm not setting these yet. Rendering seems to be working after manually setting them.
* start using some globalsKartik K. Agaram2022-05-201-1/+1
|
* moveKartik K. Agaram2022-05-201-2/+4
|
* start remembering where the cursor is drawn in pxKartik K. Agaram2022-05-201-0/+2
| | | | We'll start using this in cursor up/down motions.
* extract a functionKartik K. Agaram2022-05-201-4/+1
|
* bugfix: text past cursor was rendered red on wrapped linesKartik K. Agaram2022-05-191-0/+1
|
* change text cursor shapeKartik K. Agaram2022-05-191-2/+3
|
* clicking now moves the cursor even on long, wrapped linesKartik K. Agaram2022-05-191-2/+2
|
* make text and drawings the same widthKartik K. Agaram2022-05-191-5/+3
|
* commentKartik K. Agaram2022-05-191-6/+1
|
* eliminate assumptions that line length == size in bytesKartik K. Agaram2022-05-191-3/+3
|
* snapshot: wrapping long lines at word boundariesKartik K. Agaram2022-05-191-1/+3
| | | | | | Still not working: clicking on text to move the cursor aborts up/down motions still move by logical lines rather than screen lines
* a few more integer coordinatesKartik K. Agaram2022-05-191-1/+1
|
* this is a bit clearerKartik K. Agaram2022-05-191-2/+2
|
* redo y computationsKartik K. Agaram2022-05-191-4/+8
|
* simplerKartik K. Agaram2022-05-191-1/+1
|
* delete another arg that can be deducedKartik K. Agaram2022-05-191-1/+1
|
* delete unused argKartik K. Agaram2022-05-191-1/+1
|
* ensure integer coordinatesKartik K. Agaram2022-05-191-1/+1
| | | | | https://love2d.org/wiki/Text says text can appear blurry otherwise. I can't tell yet, though.
* bugfix: ensure Cursor_line is always on a text lineKartik K. Agaram2022-05-181-3/+4
| | | | | | | | | | | | | | | | | | | | Manual test used here: abc ```lines {"p1":{"y":72,"x":82},"mode":"line","p2":{"y":29,"x":169}} ``` def ```lines {"p1":{"y":36,"x":56},"mode":"line","p2":{"y":59,"x":163}} ``` ```lines ``` ghi jkl Hitting page-down moves the cursor from abc to ghi. The 'ghi' line should be fully visible on screen.
* bugfix: position cursor up top when loading fileKartik K. Agaram2022-05-181-0/+2
|
* scroll past first pageKartik K. Agaram2022-05-181-20/+49
| | | | | | Still some limitations. The text cursor has to be visible on screen, so if you have a long series of drawings without intervening lines of text you won't be able to scroll through them all.
* highlight another globalKartik K. Agaram2022-05-171-1/+1
|
* forgot to move this special case outKartik K. Agaram2022-05-171-0/+5
|
* .Kartik K. Agaram2022-05-171-2/+2
|
* delegate update events to drawingsKartik K. Agaram2022-05-171-21/+1
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-11-14 19:56:05 +0000