about summary refs log tree commit diff stats
path: root/main.lua
Commit message (Collapse)AuthorAgeFilesLines
...
* extract variables for drawing paddingKartik K. Agaram2022-06-141-2/+6
|
* extract variable Margin_leftKartik K. Agaram2022-06-141-1/+2
|
* mouse buttons are integers, not stringsKartik K. Agaram2022-06-141-4/+4
| | | | | | Not sure where that idiom comes from or why strings work in some places (auto-coercion?). I picked it up off some example apps. But https://love2d.org/wiki/love.mouse.isDown says it should be an integer.
* cleanupKartik K. Agaram2022-06-141-6/+0
|
* bugfixKartik K. Agaram2022-06-141-0/+8
| | | | | | | | | | | | | | | | | | | | | | | manifestation: clicking past end of a long, wrapping line containing non-ASCII would cause the cursor to disappear rather than position past end of screen line. Hitting enter would then throw an assertion with the following stack trace: Error: text.lua:381: bad argument #2 to 'sub' (number expected, got nil) stack traceback: [love "boot.lua"]:345: in function <[love "boot.lua"]:341> [C]: in function 'sub' text.lua:381: in function 'insert_return' text.lua:179: in function 'keychord_pressed' main.lua:495: in function 'keychord_pressed' keychord.lua:10: in function <keychord.lua:5> app.lua:34: in function <app.lua:25> [C]: in function 'xpcall' cause: the click caused a call to Text.to_pos_on_line whose result was not on a UTF-8 character boundary. fix: make to_pos_on_line utf8-aware.
* bugfix: UTF-8 in compute_fragmentsKartik K. Agaram2022-06-141-0/+2
|
* override mouse state lookups in testsKartik K. Agaram2022-06-121-3/+3
| | | | | | | If I'd had this stuff in my test harness earlier, two recent commits would have failed tests and given me early warning: ff88238ff1 ff88a2a927
* bugfix in commit e51ce12969Kartik K. Agaram2022-06-121-4/+6
| | | | | | | | | Any time I press a ctrl- chord LÖVE actually sees two key chords: C-lctrl C-... (the real one) But it's not just that. There's also a lot in the codebase that's just habit-based. I need more tests.
* bugfix: BSOD in #4.Kartik K. Agaram2022-06-111-2/+2
| | | | I messed up a function call in commit 391d764e13.
* bugfix: autosave and undo in a couple of casesKartik K. Agaram2022-06-111-0/+6
| | | | This fixes part of #4, but not the BSOD.
* bugfix: missed fixing a callsiteKartik K. Agaram2022-06-111-1/+1
|
* stop handling nil screen_line_starting_pos everywhereKartik K. Agaram2022-06-101-1/+0
| | | | Things seem to be working..
* more precise scroll on pasteKartik K. Agaram2022-06-101-19/+4
|
* faster pasteKartik K. Agaram2022-06-101-9/+7
| | | | | We don't need to perform the scroll calculations after inserting every single character from the clipboard.
* revert previous commitKartik K. Agaram2022-06-101-5/+15
|
* experiment: extremely precise scrolling on pasteKartik K. Agaram2022-06-101-15/+5
| | | | But this is too slow.
* while we're at it, undo naming pointsKartik K. Agaram2022-06-101-0/+2
|
* stop saving the entire file when modifying drawingsKartik K. Agaram2022-06-101-0/+8
| | | | Now we just disallow that entirely.
* undo creating new drawingsKartik K. Agaram2022-06-101-1/+3
|
* extract scrolling logic out of insert_at_cursorKartik K. Agaram2022-06-101-0/+6
|
* extract scrolling logic out of insert_returnKartik K. Agaram2022-06-101-0/+3
|
* remove some memory leaks from rendered fragmentsKartik K. Agaram2022-06-101-0/+3
| | | | | | | | | | | | | | | All signs so far seem to be that CPU is cheap for this application, but memory is expensive. It's easy to get sluggish if the GC comes on. After some experiments using https://github.com/yaukeywang/LuaMemorySnapshotDump, one source of memory leaks is rendered fragments (https://love2d.org/wiki/Text objects). I need to render text in approximately word-sized fragments to mostly break lines more intelligently at word boundaries. I've attached the files I used for my experiments (suffixed with a '.') There's definitely still a leak in fragments. The longer I edit, the more memory goes to them.
* fix a corner case when selecting textKartik K. Agaram2022-06-091-9/+21
| | | | | The hard part here is keeping click-drag selection working (without pressing and holding shift).
* .Kartik K. Agaram2022-06-091-4/+2
|
* experiment: blinking cursorKartik K. Agaram2022-06-091-0/+4
| | | | | | | | | I've tried to keep the time period of the blinking similar to my terminal. Honestly I'm no longer sure if any of my experiments are showing a statistically significant result. Let's see how it feels over a period of time.
* experiment: turn off JITKartik K. Agaram2022-06-091-0/+5
| | | | This seems to speed up copy! What does it slow down?
* more defensive resize handlingKartik K. Agaram2022-06-071-2/+23
| | | | Thanks John Blommers for the report!
* first commandline arg: window dimensionsKartik K. Agaram2022-06-071-8/+33
| | | | Hopefully there won't be too many others.
* use app name in window titleKartik K. Agaram2022-06-071-1/+1
|
* warn on unused commandline argsKartik K. Agaram2022-06-071-0/+4
|
* obsolete commentKartik K. Agaram2022-06-071-1/+0
|
* extract a functionKartik K. Agaram2022-06-071-11/+14
|
* allow the window to be resizedKartik K. Agaram2022-06-071-2/+13
| | | | | | This still isn't ideal. On my Linux laptop for some reason the window receives a signal to maximize itself soon after (but sometime after) the program starts.
* autosave on cut/pasteKartik K. Agaram2022-06-051-0/+2
|
* .Kartik K. Agaram2022-06-051-1/+1
|
* another bugfix in scrolling while inserting textKartik K. Agaram2022-06-051-0/+1
| | | | | | I'm being unprincipled at the moment between pos and x,y coordinates. Whatever is more convenient. Perhaps a cleaner approach will come to me over time.
* renameKartik K. Agaram2022-06-051-2/+2
|
* some unnecessary mutationsKartik K. Agaram2022-06-051-4/+0
| | | | | Why are we not modifying Screen_top1.pos in these places? Because we don't really need to modify Screen_top1 at all.
* regression: couldn't do many drawing operations because line.y was resetKartik K. Agaram2022-06-041-1/+7
|
* try to maintain a reasonable line widthKartik K. Agaram2022-06-041-15/+15
|
* .Kartik K. Agaram2022-06-041-4/+0
|
* select text with shift + mouseclickKartik K. Agaram2022-06-041-2/+8
| | | | | | | It's still a bit simple-minded. Most software will keep the first bound fixed and move the second. Lines currently has the bounds in a queue of sorts. But I have a test to indicate the behavior that is definitely desired. We'll see if we need it to get more complex.
* bugfix: restore state after C-f (find)Kartik K. Agaram2022-06-031-4/+6
|
* highlight selection while draggingKartik K. Agaram2022-06-031-5/+7
| | | | | | | Mouse stuff is pretty strenuous. For the first time I have to be careful not to recompute too often. And I ran into a race condition for the first time where resetting line.y within App.draw meant mouse clicks were extremely unlikely to see line.y set.
* select text using mouse dragKartik K. Agaram2022-06-031-10/+15
| | | | Doesn't yet highlight while dragging.
* renameKartik K. Agaram2022-06-031-2/+2
|
* up arrow to search previousKartik K. Agaram2022-06-031-0/+2
|
* switch copy/paste to ctrl- hotkeysKartik K. Agaram2022-06-021-0/+48
|
* switch undo/redo to ctrl- hotkeysKartik K. Agaram2022-06-021-0/+18
|
* default font size and line-heightKartik K. Agaram2022-06-021-4/+10
|