about summary refs log tree commit diff stats
path: root/text.lua
Commit message (Collapse)AuthorAgeFilesLines
* bugfix: don't append metadata when it already existsKartik K. Agaram2022-05-251-2/+6
|
* bugfixKartik K. Agaram2022-05-251-0/+41
| | | | | I spent 20 minutes converting a manual test to a reproducible automated one, but in the process I knew exactly what the problem was. Nice.
* test and App helper for mouse clicksKartik K. Agaram2022-05-251-1/+18
|
* no, make sure to compute line width after screen dimensionsKartik K. Agaram2022-05-251-1/+2
|
* couple more testsKartik K. Agaram2022-05-251-0/+45
| | | | Along with the App helpers needed for them.
* bugfix: down arrow doesn't scroll up unnecessarilyKartik K. Agaram2022-05-241-4/+46
| | | | up arrow doesn't seem to have the symmetric issue.
* bugfixKartik K. Agaram2022-05-241-5/+46
| | | | Found while reading https://www.gutenberg.org/ebooks/52091
* get rid of debug variablesKartik K. Agaram2022-05-231-7/+2
|
* keep one screen line of overlap on pagedownKartik K. Agaram2022-05-231-18/+43
| | | | | | | | | | | | | | | | | | | | I'm now extracting the concern of computing line.screen_line_starting_pos out of Text.draw. Earlier I had to make sure I ran through the whole line to compute screen_line_starting_pos, but that had the side-effect of updating Screen_bottom1.pos as well with lines that had never been rendered. In this process I hit my first bug due to an accidental global. It doesn't show up in the patch because I accidentally deleted a local declaration. (I thought I didn't need screen_line_starting_pos anymore, deleted everywhere, then brought it back everywhere from the bottom of the function up, but forgot to put back the very first occurrence.) The amount of yoyoing this caused between App.draw and Text.draw, I very much have spaghetti on my hands. Accidental globals are _terrible_ in a program with tests. Cross test contamination X-(
* a few tests for pageup, and a bugfixKartik K. Agaram2022-05-231-0/+89
| | | | It wasn't screen-line aware. Now it is.
* clean up test progress indicatorsKartik K. Agaram2022-05-231-11/+11
|
* one bug I've repeatedly run into while testing with Moby DickKartik K. Agaram2022-05-231-3/+68
| | | | https://www.hogbaysoftware.com/posts/moby-dick-workout
* scrolling with up arrowKartik K. Agaram2022-05-231-20/+19
|
* disable all debug printsKartik K. Agaram2022-05-231-22/+22
|
* quite the frustrating bugfixKartik K. Agaram2022-05-231-5/+7
|
* snapshotKartik K. Agaram2022-05-231-21/+161
| | | | Why the fuck is this so fucking hard?
* similar tests for cursor upKartik K. Agaram2022-05-231-1/+67
|
* couple of tests for cursor downKartik K. Agaram2022-05-231-6/+66
|
* bugfix: don't rely on Screen_bottom1 while scrollingKartik K. Agaram2022-05-231-10/+18
| | | | | Setting up the test just right to test the thing I want to test was a rube goldberg machine of constants.
* first successful pagedown test, first bug found by testKartik K. Agaram2022-05-231-3/+58
| | | | | | | | | | | | | | | | | | | I also really need to rethink how people debug my programs. My approach of inserting and deleting print() takes a lot of commitment. I need my old trace-based whitebox testing idea. However, in my past projects I never did figure out a good framework for tweaking how verbose a trace to emit. Perhaps that's too many knobs. Perhaps we just need a way to run a single test with the most verbose trace possible. Then it's just a matter of having the trace tell a coherent story? But even if the trace stays out of program output in that situation, it's still in the programmer's face in the _code_. Ugh. Current plan: ship program with maximum tests and zero commented-out prints. If you want to debug, insert prints. This is better than previous, text-mode, projects just by virtue of the stdout channel being dedicated to debug stuff.
* first test!Kartik K. Agaram2022-05-221-12/+31
|
* yet another bugfix. But for how long?Kartik K. Agaram2022-05-221-1/+1
|
* up and down arrow now moving by screen line where possibleKartik K. Agaram2022-05-211-25/+47
| | | | Drawings can't be drawn partially, which sometimes makes things jerky.
* bugfix: printing the first part of a line at the bottom made it seem ↵Kartik K. Agaram2022-05-211-21/+26
| | | | | | non-wrapping Still lots wrong here.
* cleanerKartik K. Agaram2022-05-211-3/+2
|
* I feel confident now that page-down is working.Kartik K. Agaram2022-05-211-1/+9
|
* couple of TODOsKartik K. Agaram2022-05-211-1/+1
|
* beginning of a new approach to scroll+wrapKartik K. Agaram2022-05-211-130/+156
| | | | | | | So far I've just changed how existing variables are organized, and put some scaffolding in place for dealing with the new types. Next up: rewriting the code for scrolling to something that feels more obviously correct.
* support for naming pointsKartik K. Agaram2022-05-211-3/+1
| | | | There's still an absence of affordance showing when you're in naming mode.
* disable some debug printsKartik K. Agaram2022-05-201-23/+23
| | | | | I'm still very much in the region where this is valuable sensor data. This is a new domain.
* more precise height calculation when scrolling up as much as possible while ↵Kartik K. Agaram2022-05-201-4/+21
| | | | keeping cursor on screen
* keep cursor on screen when pressing 'down'Kartik K. Agaram2022-05-201-2/+4
|
* renameKartik K. Agaram2022-05-201-7/+7
|
* reduce ambitions a bit: page up/down need not start screen from the middle ↵Kartik K. Agaram2022-05-201-7/+3
| | | | | | of a line But we still have work to do for cursor up/down.
* first stab at equally hacky cursor down supportKartik K. Agaram2022-05-201-11/+42
|
* stop recomputing Cursor_x now that we're saving itKartik K. Agaram2022-05-201-5/+3
|
* clearer commentsKartik K. Agaram2022-05-201-2/+3
|
* some more loggingKartik K. Agaram2022-05-201-1/+11
| | | | | | | | | | | Still lots of signs it's all messed up, but I can't be sure until I bring all the other keyboard shortcuts in sync. I just need a better data structure that simplifies the logic. Perhaps talk in terms of screen lines. In which case: We'll need to convert lines to screen lines at some point. We'll need to fix up screen lines when inserting and deleting characters.
* snapshot - no, that's all wrongKartik K. Agaram2022-05-201-6/+30
| | | | | I've been only thinking about up arrow when cursor is at top of screen. Hopefully this is better.
* another piece of support for line wrapping in cursor upKartik K. Agaram2022-05-201-1/+9
|
* first stab at supporting wrapping in cursor upKartik K. Agaram2022-05-201-13/+22
| | | | Looks pretty clean.
* bugfixKartik K. Agaram2022-05-201-16/+3
| | | | | | | I'd wrapped currx in two conditionals, and not noticed that it gets reclaimed within the other. The hint is clearly more work than it's worth. Just take it out.
* new globals: draw partial screen line up topKartik K. Agaram2022-05-201-2/+6
| | | | | I'm not setting these yet. Rendering seems to be working after manually setting them.
* start using some globalsKartik K. Agaram2022-05-201-5/+5
|
* bugfixKartik K. Agaram2022-05-201-1/+1
|
* start remembering where the cursor is drawn in pxKartik K. Agaram2022-05-201-0/+2
| | | | We'll start using this in cursor up/down motions.
* extract a functionKartik K. Agaram2022-05-201-8/+8
|
* moveKartik K. Agaram2022-05-191-35/+35
|
* planning out cursor up/down over wrapped linesKartik K. Agaram2022-05-191-0/+2
|
* bugfix: cursor past end of screen lineKartik K. Agaram2022-05-191-1/+1
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-11-14 20:17:00 +0000