about summary refs log tree commit diff stats
path: root/text.lua
Commit message (Collapse)AuthorAgeFilesLines
* autosave slightly less aggressivelyKartik K. Agaram2022-06-171-6/+6
| | | | | | | | It might reduce wear and tear on disk, and losing 3 seconds of data doesn't feel catastrophic (short of a C-z rampage). Thanks to the love2d.org community for the suggestion: https://love2d.org/forums/viewtopic.php?f=14&t=93173
* extract variables for drawing paddingKartik K. Agaram2022-06-141-3/+3
|
* extract variable Margin_leftKartik K. Agaram2022-06-141-11/+11
|
* mouse buttons are integers, not stringsKartik K. Agaram2022-06-141-1/+1
| | | | | | Not sure where that idiom comes from or why strings work in some places (auto-coercion?). I picked it up off some example apps. But https://love2d.org/wiki/love.mouse.isDown says it should be an integer.
* go through and fix similar issuesKartik K. Agaram2022-06-141-6/+12
| | | | All places where string.sub was being passed a _pos variable.
* bugfixKartik K. Agaram2022-06-141-4/+13
| | | | | | | | | | | | | | | | | | | | | | | manifestation: clicking past end of a long, wrapping line containing non-ASCII would cause the cursor to disappear rather than position past end of screen line. Hitting enter would then throw an assertion with the following stack trace: Error: text.lua:381: bad argument #2 to 'sub' (number expected, got nil) stack traceback: [love "boot.lua"]:345: in function <[love "boot.lua"]:341> [C]: in function 'sub' text.lua:381: in function 'insert_return' text.lua:179: in function 'keychord_pressed' main.lua:495: in function 'keychord_pressed' keychord.lua:10: in function <keychord.lua:5> app.lua:34: in function <app.lua:25> [C]: in function 'xpcall' cause: the click caused a call to Text.to_pos_on_line whose result was not on a UTF-8 character boundary. fix: make to_pos_on_line utf8-aware.
* bugfix: UTF-8 in compute_fragmentsKartik K. Agaram2022-06-141-5/+7
|
* override mouse state lookups in testsKartik K. Agaram2022-06-121-1/+1
| | | | | | | If I'd had this stuff in my test harness earlier, two recent commits would have failed tests and given me early warning: ff88238ff1 ff88a2a927
* bugfix: BSOD in #4.Kartik K. Agaram2022-06-111-2/+2
| | | | I messed up a function call in commit 391d764e13.
* stop handling nil screen_line_starting_pos everywhereKartik K. Agaram2022-06-101-23/+6
| | | | Things seem to be working..
* this fixes the immediate regressionKartik K. Agaram2022-06-101-19/+17
|
* stop repeatedly checking for line wrappingKartik K. Agaram2022-06-101-7/+8
| | | | | | We have a regression since we started reclaiming love Text fragments more aggressively in commit 69c5d844ccc. Pressing pageup no longer knows about any line's screen lines. Not fixed yet.
* .Kartik K. Agaram2022-06-101-1/+1
|
* extract scrolling logic out of insert_at_cursorKartik K. Agaram2022-06-101-6/+12
|
* extract scrolling logic out of insert_returnKartik K. Agaram2022-06-101-4/+3
|
* remove some memory leaks from rendered fragmentsKartik K. Agaram2022-06-101-0/+4
| | | | | | | | | | | | | | | All signs so far seem to be that CPU is cheap for this application, but memory is expensive. It's easy to get sluggish if the GC comes on. After some experiments using https://github.com/yaukeywang/LuaMemorySnapshotDump, one source of memory leaks is rendered fragments (https://love2d.org/wiki/Text objects). I need to render text in approximately word-sized fragments to mostly break lines more intelligently at word boundaries. I've attached the files I used for my experiments (suffixed with a '.') There's definitely still a leak in fragments. The longer I edit, the more memory goes to them.
* experiment: blinking cursorKartik K. Agaram2022-06-091-3/+6
| | | | | | | | | I've tried to keep the time period of the blinking similar to my terminal. Honestly I'm no longer sure if any of my experiments are showing a statistically significant result. Let's see how it feels over a period of time.
* the problem is that the cursor can occlude textKartik K. Agaram2022-06-091-1/+1
| | | | | | | And anything we do to reduce the occlusion also makes the cursor harder to acquire. I suppose this is why we need the blink.
* make the cursor a little thickerKartik K. Agaram2022-06-091-1/+1
| | | | | | | I'm testing this by moving the cursor around with my eyes closed, then starting a stopwatch as I open my eyes. This seems to help a bit. I'm able to acquire the cursor in 2s. At least the 10s outliers I used to have with the circle or thin line don't seem to be happening.
* experiment: line cursorKartik K. Agaram2022-06-091-1/+1
|
* fix a crashKartik K. Agaram2022-06-061-1/+3
| | | | | This one isn't worth debugging. We know how to recreate this data on demand.
* additional logging for an active bugKartik K. Agaram2022-06-051-1/+5
|
* another bugfix in scrolling while inserting textKartik K. Agaram2022-06-051-2/+1
| | | | | | I'm being unprincipled at the moment between pos and x,y coordinates. Whatever is more convenient. Perhaps a cleaner approach will come to me over time.
* bugfix in previous commitKartik K. Agaram2022-06-051-0/+3
| | | | | | | | I almost pushed this to production. That would have been catastrophic; the very first keystroke anyone typed into the editor would have failed. And in the process, this fixes the next bug on my TODO list! Paste on first line wasn't working. Now it is.
* check for scroll when just typingKartik K. Agaram2022-06-051-0/+5
|
* renameKartik K. Agaram2022-06-051-5/+5
|
* some unnecessary mutationsKartik K. Agaram2022-06-051-4/+0
| | | | | Why are we not modifying Screen_top1.pos in these places? Because we don't really need to modify Screen_top1 at all.
* some typosKartik K. Agaram2022-06-051-3/+3
|
* bugfix: backspace from start of fileKartik K. Agaram2022-06-041-4/+1
|
* regression: couldn't do many drawing operations because line.y was resetKartik K. Agaram2022-06-041-0/+1
|
* experiment: slightly adaptive scrollingKartik K. Agaram2022-06-041-2/+14
| | | | | | | | | | | When long wrapping lines go past the current page, I find myself scrolling before I get to the bottom. So let's scroll less, usually from the start of the bottom-most line, even if it wraps multiple screen lines. The challenge with this is to ensure that a long line that fills the whole page by itself doesn't get you stuck. I take some care to make sure <pagedown> always makes forward progress.
* make cursor more obviousKartik K. Agaram2022-06-041-1/+1
| | | | | Let's see if this is good enough. I can also bump up to 4px radius if I need to.
* more precise search highlightingKartik K. Agaram2022-06-031-6/+2
|
* extract a functionKartik K. Agaram2022-06-031-20/+1
|
* extract a couple of filesKartik K. Agaram2022-06-031-1193/+4
|
* bugfix: restore state after C-f (find)Kartik K. Agaram2022-06-031-4/+8
|
* highlight selection while draggingKartik K. Agaram2022-06-031-12/+40
| | | | | | | Mouse stuff is pretty strenuous. For the first time I have to be careful not to recompute too often. And I ran into a race condition for the first time where resetting line.y within App.draw meant mouse clicks were extremely unlikely to see line.y set.
* select text using mouse dragKartik K. Agaram2022-06-031-2/+6
| | | | Doesn't yet highlight while dragging.
* up arrow to search previousKartik K. Agaram2022-06-031-0/+50
|
* switch copy/paste to ctrl- hotkeysKartik K. Agaram2022-06-021-48/+1
|
* switch undo/redo to ctrl- hotkeysKartik K. Agaram2022-06-021-22/+2
|
* extract a new variableKartik K. Agaram2022-06-021-93/+61
|
* crisp font renderingKartik K. Agaram2022-06-021-193/+135
|
* find textKartik K. Agaram2022-06-021-4/+76
|
* scroll if necessary on pasteKartik K. Agaram2022-06-021-0/+23
|
* renameKartik K. Agaram2022-06-021-2/+2
|
* test harness now supports copy/pasteKartik K. Agaram2022-06-021-3/+68
|
* bugfix: pasting newlinesKartik K. Agaram2022-06-021-12/+21
|
* more efficient undo/redoKartik K. Agaram2022-06-021-56/+36
| | | | | Now the bottleneck shifts to applying undo/redo in large files. But things should be snappy if you don't use the sluggish feature.
* renameKartik K. Agaram2022-06-021-12/+12
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-12-26 09:46:45 +0000