about summary refs log tree commit diff stats
path: root/text_tests.lua
Commit message (Collapse)AuthorAgeFilesLines
* bugfix: clicking on empty linesKartik K. Agaram2022-07-011-0/+16
|
* right marginKartik K. Agaram2022-06-301-0/+71
|
* rip out notion of Line_widthKartik K. Agaram2022-06-301-84/+17
|
* bugfix: lines that aren't drawn from the startKartik K. Agaram2022-06-301-0/+21
| | | | | | | | | | | | | | | I can't believe I didn't catch this until now. All I had to do is open MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout, press page-down and click on the top screen line (or any screen line containing the same line as the top screen line). Easy to catch with any file containing lots of overly long lines, as happens in particular at the start of Moby Dick. I _had_ seen this problem before, but it seemed to disappear after unrelated changes, and I convinced myself I'd fixed it as a side-effect. The bug just failed to manifest if the top line happened to start at the top of the screen. Scroll down a few pages in Moby Dick and the dialogue starts and line length drops precipitously.
* some redundant callsKartik K. Agaram2022-06-301-4/+0
|
* clicking to the right of a line within line widthKartik K. Agaram2022-06-291-0/+22
|
* bugfix: clicking past end of screen lineKartik K. Agaram2022-06-291-0/+49
| | | | I could swear I checked this at some point. But I didn't have a test!
* bugfix: scrolling in left/right movementsKartik K. Agaram2022-06-281-0/+118
| | | | | I'd always had a funny feeling there was something missing there but somehow never thought of the right failing test.
* bugfix: typing a capital letter deletes selectionKartik K. Agaram2022-06-261-0/+22
|
* bugfix: deleting a selection spanning pagesKartik K. Agaram2022-06-261-0/+25
|
* bugfix: don't delete selection when moving cursorKartik K. Agaram2022-06-231-0/+18
|
* keep drawings within the line width slider as wellKartik K. Agaram2022-06-221-2/+3
|
* bugfix: delete selection before pastingKartik K. Agaram2022-06-211-0/+38
|
* revert selection logic to before commit 3ffc2ed8fKartik K. Agaram2022-06-201-0/+1
| | | | | We still have a failing test, but now it's the one we introduced in commit 3ffc2ed8f.
* snapshot: test for a new regressionKartik K. Agaram2022-06-201-0/+22
| | | | | | Caused by commit 3ffc2ed8f. We might need to bring back a lot of complexity for this.
* selection bugfixKartik K. Agaram2022-06-201-0/+18
|
* no, that's not rightKartik K. Agaram2022-06-201-0/+22
| | | | | | | | | | | | | | Bugfix: we want selections to persist even when we lift up the shift key. This requires hoisting some code inside every case inside the whole keypress hierarchy, to ensure we never clear selections before textinput events can handle them. Current cross-cutting concerns we're explicitly scattering code for. - autosave - undo - selection management
* bugfix: typing should delete highlighted textKartik K. Agaram2022-06-201-0/+17
| | | | The test harness now also mimics real usage more precisely.
* bugfixKartik K. Agaram2022-06-191-0/+18
| | | | | | | | | | | | | | | To reproduce: click to position cursor at end of a line hit enter press any key before: newline got erased and key got added to previous line now: newline is preserved The new test checks a generalization of this.
* extract variables for drawing paddingKartik K. Agaram2022-06-141-1/+1
|
* extract variable Margin_leftKartik K. Agaram2022-06-141-44/+38
|
* .Kartik K. Agaram2022-06-141-1/+0
|
* lots more testsKartik K. Agaram2022-06-141-0/+65
| | | | | | | I've been adding diligently to manual_tests but not actually _performing_ any manual tests before releases. They were just a todo list of automated tests to write, and long out of date. Now the list is up to date and much shorter.
* mouse buttons are integers, not stringsKartik K. Agaram2022-06-141-16/+16
| | | | | | Not sure where that idiom comes from or why strings work in some places (auto-coercion?). I picked it up off some example apps. But https://love2d.org/wiki/love.mouse.isDown says it should be an integer.
* answered an open questionKartik K. Agaram2022-06-141-1/+0
| | | | | The default font seems somehow different than the font created by newFont with just a font size.
* bugfixKartik K. Agaram2022-06-141-0/+25
| | | | | | | | | | | | | | | | | | | | | | | manifestation: clicking past end of a long, wrapping line containing non-ASCII would cause the cursor to disappear rather than position past end of screen line. Hitting enter would then throw an assertion with the following stack trace: Error: text.lua:381: bad argument #2 to 'sub' (number expected, got nil) stack traceback: [love "boot.lua"]:345: in function <[love "boot.lua"]:341> [C]: in function 'sub' text.lua:381: in function 'insert_return' text.lua:179: in function 'keychord_pressed' main.lua:495: in function 'keychord_pressed' keychord.lua:10: in function <keychord.lua:5> app.lua:34: in function <app.lua:25> [C]: in function 'xpcall' cause: the click caused a call to Text.to_pos_on_line whose result was not on a UTF-8 character boundary. fix: make to_pos_on_line utf8-aware.
* bugfix: UTF-8 in compute_fragmentsKartik K. Agaram2022-06-141-0/+18
|
* .Kartik K. Agaram2022-06-141-2/+2
|
* new testKartik K. Agaram2022-06-121-0/+17
| | | | | For commit e4e12c77ad which fixed a regression caused by commit 24a0d162ef.
* new testKartik K. Agaram2022-06-121-0/+12
| | | | | | | | | | For commit ff88a2a927 which fixed a regression caused by commit e51ce12969. I'm trying to provide enough guardrails for myself and future readers without causing a combinatorial explosion in tests. The previous commit was able to get more value out of existing tests, but this test feels necessary. And useful in general without reference to a specific bug.
* override mouse state lookups in testsKartik K. Agaram2022-06-121-19/+19
| | | | | | | If I'd had this stuff in my test harness earlier, two recent commits would have failed tests and given me early warning: ff88238ff1 ff88a2a927
* include a unit testKartik K. Agaram2022-06-091-0/+17
|
* fix a corner case when selecting textKartik K. Agaram2022-06-091-0/+30
| | | | | The hard part here is keeping click-drag selection working (without pressing and holding shift).
* moveKartik K. Agaram2022-06-091-4/+4
|
* test both ways of selecting text with mouseKartik K. Agaram2022-06-091-4/+25
|
* another bugfix in scrolling while inserting textKartik K. Agaram2022-06-051-2/+21
| | | | | | I'm being unprincipled at the moment between pos and x,y coordinates. Whatever is more convenient. Perhaps a cleaner approach will come to me over time.
* bugfix in previous commitKartik K. Agaram2022-06-051-0/+10
| | | | | | | | I almost pushed this to production. That would have been catastrophic; the very first keystroke anyone typed into the editor would have failed. And in the process, this fixes the next bug on my TODO list! Paste on first line wasn't working. Now it is.
* check for scroll when just typingKartik K. Agaram2022-06-051-2/+33
|
* some typosKartik K. Agaram2022-06-051-2/+2
|
* experiment: slightly adaptive scrollingKartik K. Agaram2022-06-041-14/+42
| | | | | | | | | | | When long wrapping lines go past the current page, I find myself scrolling before I get to the bottom. So let's scroll less, usually from the start of the bottom-most line, even if it wraps multiple screen lines. The challenge with this is to ensure that a long line that fills the whole page by itself doesn't get you stuck. I take some care to make sure <pagedown> always makes forward progress.
* select text with shift + mouseclickKartik K. Agaram2022-06-041-0/+28
| | | | | | | It's still a bit simple-minded. Most software will keep the first bound fixed and move the second. Lines currently has the bounds in a queue of sorts. But I have a test to indicate the behavior that is definitely desired. We'll see if we need it to get more complex.
* extract a couple of filesKartik K. Agaram2022-06-031-0/+931