| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |
|
| | |
|
| |
|
|
| |
I could swear I checked this at some point. But I didn't have a test!
|
| |
|
|
|
| |
I'd always had a funny feeling there was something missing there but
somehow never thought of the right failing test.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
We still have a failing test, but now it's the one we introduced in
commit 3ffc2ed8f.
|
| |
|
|
|
|
| |
Caused by commit 3ffc2ed8f.
We might need to bring back a lot of complexity for this.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bugfix: we want selections to persist even when we lift up the shift
key.
This requires hoisting some code inside every case inside the whole
keypress hierarchy, to ensure we never clear selections before
textinput events can handle them.
Current cross-cutting concerns we're explicitly scattering code for.
- autosave
- undo
- selection management
|
| |
|
|
| |
The test harness now also mimics real usage more precisely.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reproduce:
click to position cursor at end of a line
hit enter
press any key
before:
newline got erased and key got added to previous line
now:
newline is preserved
The new test checks a generalization of this.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
I've been adding diligently to manual_tests but not actually
_performing_ any manual tests before releases. They were just a todo
list of automated tests to write, and long out of date. Now the list is
up to date and much shorter.
|
| |
|
|
|
|
| |
Not sure where that idiom comes from or why strings work in some places
(auto-coercion?). I picked it up off some example apps. But
https://love2d.org/wiki/love.mouse.isDown says it should be an integer.
|
| |
|
|
|
| |
The default font seems somehow different than the font created by
newFont with just a font size.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
manifestation: clicking past end of a long, wrapping line containing
non-ASCII would cause the cursor to disappear rather than position past
end of screen line. Hitting enter would then throw an assertion with the
following stack trace:
Error: text.lua:381: bad argument #2 to 'sub' (number expected, got nil)
stack traceback:
[love "boot.lua"]:345: in function <[love "boot.lua"]:341>
[C]: in function 'sub'
text.lua:381: in function 'insert_return'
text.lua:179: in function 'keychord_pressed'
main.lua:495: in function 'keychord_pressed'
keychord.lua:10: in function <keychord.lua:5>
app.lua:34: in function <app.lua:25>
[C]: in function 'xpcall'
cause: the click caused a call to Text.to_pos_on_line whose result was
not on a UTF-8 character boundary.
fix: make to_pos_on_line utf8-aware.
|
| | |
|
| | |
|
| |
|
|
|
| |
For commit e4e12c77ad which fixed a regression caused by commit
24a0d162ef.
|
| |
|
|
|
|
|
|
|
|
| |
For commit ff88a2a927 which fixed a regression caused by commit
e51ce12969.
I'm trying to provide enough guardrails for myself and future readers
without causing a combinatorial explosion in tests. The previous commit
was able to get more value out of existing tests, but this test feels
necessary. And useful in general without reference to a specific bug.
|
| |
|
|
|
|
|
| |
If I'd had this stuff in my test harness earlier, two recent commits
would have failed tests and given me early warning:
ff88238ff1
ff88a2a927
|
| | |
|
| |
|
|
|
| |
The hard part here is keeping click-drag selection working (without
pressing and holding shift).
|
| | |
|
| | |
|
| |
|
|
|
|
| |
I'm being unprincipled at the moment between pos and x,y coordinates.
Whatever is more convenient. Perhaps a cleaner approach will come to me
over time.
|
| |
|
|
|
|
|
|
| |
I almost pushed this to production. That would have been catastrophic;
the very first keystroke anyone typed into the editor would have failed.
And in the process, this fixes the next bug on my TODO list! Paste on
first line wasn't working. Now it is.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
When long wrapping lines go past the current page, I find myself
scrolling before I get to the bottom. So let's scroll less, usually from
the start of the bottom-most line, even if it wraps multiple screen
lines.
The challenge with this is to ensure that a long line that fills the
whole page by itself doesn't get you stuck. I take some care to make
sure <pagedown> always makes forward progress.
|
| |
|
|
|
|
|
| |
It's still a bit simple-minded. Most software will keep the first bound
fixed and move the second. Lines currently has the bounds in a queue of
sorts. But I have a test to indicate the behavior that is definitely
desired. We'll see if we need it to get more complex.
|
| |
|