about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
...
* manually maintain mouse button press stateKartik K. Agaram2023-12-012-1/+3
| | | | | | | | | | | | Just checking mouse.isDown works if the editor is the entirety of the app, as is true in this fork. However, we often want to introduce other widgets. We'd like tapping on them to not cause the selection to flash: https://news.ycombinator.com/context?id=38404923&submission=38397715 The right architecture to enforce this is: have each layer of the UI maintain its own state machine between mouse_press and mouse_release events. And only check the state machine in the next level down rather than lower layers or the bottommost layer of raw LÖVE.
* port keyboard layout handling to source editorKartik K. Agaram2023-11-251-1/+8
|
* improved handling of other keyboard layoutsKartik K. Agaram2023-11-251-1/+8
|
* bugfix: infinite loop inside a very narrow windowKartik K. Agaram2023-11-242-2/+6
| | | | | | I'm not sure this can trigger everywhere (I've only been able to exercise it in Lua Carousel), but it seems like a safety net worth having against future modifications by anybody.
* establish a fairly fundamental invariantKartik K. Agaram2023-11-242-0/+12
| | | | | | | This commit doesn't guarantee we'll always catch it. But if this invariant is violated, things can get quite difficult to debug. I found in the Lua Carousel fork that all the xpcalls I keep around were actively hindering my ability to notice this invariant being violated.
* late-bind my App.* handlersKartik K. Agaram2023-11-181-1/+2
| | | | | | | | This came up when trying to integrate my apps with the vudu debugger (https://github.com/deltadaedalus/vudu). In general, it's a subtle part of LÖVE's semantics that you can modify event handlers any time and your modifications will get picked up. Now my Freewheeling Apps will follow this norm as well.
* audit all assertsKartik K. Agaram2023-11-1815-132/+100
| | | | | | | | | | | | | Each one should provide a message that will show up within LÖVE. Stop relying on nearby prints to the terminal. I also found some unnecessary ones. There is some potential here for performance regressions: the format() calls will trigger whether or not the assertion fails, and cause allocations. So far Lua's GC seems good enough to manage the load even with Moby Dick, even in some situations that caused issues in the past like undo.
* remove some dead codeKartik K. Agaram2023-11-121-1/+0
| | | | We have an early exit for 'error' mode in this function.
* check for 'error' mode in a few more placesKartik K. Agaram2023-11-121-5/+14
| | | | | | | In particular, I want to be able to switch to 'error' mode rather than throw a real error() on test failures, because that's a little more responsive and might be recoverable. (On some Android devices the font is slightly different, and tests fail as a result.)
* improve a nameKartik K. Agaram2023-11-101-2/+2
|
* clean up a debug printKartik K. Agaram2023-11-101-1/+0
|
* clean up some cruft from error callstacksKartik K. Agaram2023-11-101-1/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | before: stack traceback: [string "text.lua"]:9: in function 'draw' [string "edit.lua"]:200: in function 'draw' [string "run.lua"]:140: in function 'draw' [string "main.lua"]:162: in function <[string "main.lua"]:155> [C]: in function 'xpcall' [string "app.lua"]:38: in function <[string "app.lua"]:20> [C]: in function 'xpcall' [love "boot.lua"]:370: in function <[love "boot.lua"]:337> after: stack traceback: text.lua:9: in function 'draw' edit.lua:200: in function 'draw' run.lua:140: in function 'draw' main.lua:162: in function <[string "main.lua"]:155> [C]: in function 'xpcall' app.lua:38: in function <[string "app.lua"]:20> [C]: in function 'xpcall' [love "boot.lua"]:370: in function <[love "boot.lua"]:337>
* remove a no-op regex munging on callstacksKartik K. Agaram2023-11-101-1/+1
| | | | Port of a fix "upstream": commit b38f172ceb in template-live-editor.
* use my name for a dirKartik K. Agaram2023-10-272-2/+2
|
* remove stale variable from docsKartik K. Agaram2023-10-271-1/+1
|
* change section delimiters in log for OpenBSDKartik K. Agaram2023-10-202-6/+10
| | | | Thanks eril for the report and patch.
* use color alpha in button backgroundsKartik K. Agaram2023-10-161-1/+1
|
* clearer API for drawing a buttonKartik K. Agaram2023-10-166-9/+5
| | | | | | Make it more obvious that the color passed in is just for the background. The icon will do the rest. r/g/b keys are more consistent with App.color().
* rfind bugfix: handle empty pattern like string.findKartik K. Agaram2023-10-151-0/+2
|
* add some tests for rfindKartik K. Agaram2023-10-151-0/+7
|
* fix all tests in LÖVE v12Kartik K. Agaram2023-10-092-6/+20
| | | | | | | | | | | | | | | | This is all quite hacky. Many of my tests are unfortunately brittle to changes in text rendering. Fortunately there's only one test that currently requires a hacky special case (and a second test I tweaked slightly to be more robust). I can't think of a better approach. It doesn't help to standardize the font, because version changes still come with changes to text-shaping algorithms even if the font itself is unchanged. I could base all my assertions on the widths of individual characters, but that would make the tests much less readable and not express intent as clearly. So here we are, with hopefully just a few hacky special cases (there might be a few more as LÖVE v12 advances towards publication, and in further versions).
* start supporting LÖVE v12Kartik K. Agaram2023-10-093-4/+36
| | | | | | | | | | | To do this I need some support for multiple versions. And I need an 'error' mode to go with existing 'run' and 'source' modes (`Current_app`). Most errors will automatically transition to 'source' editor mode, but some errors aren't really actionable in the editor. For those we'll use 'error' mode. The app doesn't yet work with LÖVE v12. There are some unit tests failing because of differences in font rendering.
* bugfix: clear selection when clicking above or below linesKartik K. Agaram2023-09-205-26/+103
| | | | | | | | | | | | | | | | | | | Matt Wynne pointed out that snap.love would crash when a node went off screen. While debugging it I noticed that selection1 was being set when it shouldn't be. Turns out I introduced a bug when I fixed the inscript bug back in June (commit 9656e137742). One invariant I want to preserve is: selection1 should be unset after a mouse click (press and release without intervening drag). This invariant was violated in my bugfix back in June. I was concerned only with selection back then, and I didn't realize I was breaking the mouse click case (in a fairly subtle way; you can have selection set, and when it's set identically to the cursor everything looks the same). I think there might still be an issue in snap.love after this fix. I noticed screen_bottom1.pos was nil, and as far as I recall that should never happen.
* indentKartik K. Agaram2023-09-162-16/+16
|
* port an old fix to source editorKartik K. Agaram2023-09-161-1/+11
|
* bugfix to the helper I added yesterdayKartik K. Agaram2023-09-162-0/+2
|
* source: show file being edited in window title barKartik K. Agaram2023-09-152-1/+2
|
* delete some dead codeKartik K. Agaram2023-09-152-12/+1
| | | | This is a holdover from the days of bifold text.
* hide line numbers from log browserKartik K. Agaram2023-09-153-8/+14
|
* assume starty can be nil in updateKartik K. Agaram2023-09-151-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a backport of a bugfix in pensieve.love. It's not _technically_ a bug here in lines.love, but it seems worth establishing an architectural invariant (or rather lack of invariant). LÖVE's standard event loop performs the following sequence of operations in a single frame: * process events * update * draw Ideally any mutations to global state happen during the first two phases, while drawing includes no mutation. However, there is a special case: `starty`, the top y coordinate for each each line in the editor. This is used all over the place, and the cheapest way to compute it is to simply save it while drawing. However, draw by definition only updates `starty` for lines that are drawn on screen. To avoid stale data on lines off screen, say after scrolling, events often clear `starty` for all lines, leaving it to the next draw phase to repopulate the right lines. Sandwiched between the above two "however"s, the update phase needs to gracefully handle `starty` being nil in the occasional frame right after an event. I think I've audited all our uses of `starty`, and this commit fixes the only place that violates this rule.
* bugfix: crash when using mouse wheelKartik K. Agaram2023-09-152-0/+4
| | | | | | | | | | | | | | | | | | All the Text functions assume the cursor is always on a text line. I was violating that invariant. * When scrolling up, I start the cursor at the top-most line below the screen top. * When scrolling down, I start the cursor at the top-most line below the screen bottom. I think it would feel slightly more natural for it to be the bottom-most line above the screen bottom. However, the Text functions maintain an invariant that the bottom-most line in a buffer will be text. There's no such invariant for the top-most line.
* change a helper slightlyKartik K. Agaram2023-09-152-14/+22
|
* clean up a slight jitter when drawing circlesKartik K. Agaram2023-09-151-1/+2
| | | | | | | | | | Earlier the ghost while drawing wouldn't quite match the final shape. Now the math is identical in draw_pending_shape. It's a little unfortunate that we have this duplication of formulae. At least there are no other stray calls of App.mouse_x in draw_pending_shape.
* always show line numbers in source editorKartik K. Agaram2023-09-143-3/+7
| | | | | | The drawing buttons are now absolutely positioned, which is a horrible hack. But for just the source editor it seems good enough. The alternative is to modify magic constants in all the tests :/
* Revert "deemphasize the source editor"Kartik K. Agaram2023-09-103-17/+3
| | | | | | | Now that we have decent error handling, I think we can encourage people to press ctrl+e again. This reverts commit 4b43e9e85d985bcedd105fa9693ae751e5b6d0b6.
* yet another bugfix X-(Kartik K. Agaram2023-09-091-2/+2
| | | | This time it really does work with pensieve.love
* two bugfixesKartik K. Agaram2023-09-091-2/+3
| | | | | Annoying dangers of testing in one fork and committing upstream (where it isn't used yet).
* new primitives for reading/writing filesKartik K. Agaram2023-09-091-0/+34
| | | | | | | | These are like versions in nativefs, but only support absolute paths. I want to be thoughtful about the precise location at each call-site. It's a little ugly that app.lua now has a dependency on file.lua. Or source_file.lua for the source editor.
* reorderKartik K. Agaram2023-09-091-11/+11
|
* a few more testable file-system operationsKartik K. Agaram2023-09-081-0/+13
|
* show any error after switching to source editorKartik K. Agaram2023-09-042-0/+9
| | | | | | Error_message is a special global. It's set when the app (Current_app = 'run') encounters an error and switches to the source editor, and cleared when switching from source editor back to the app.
* switch to source editor on errorKartik K. Agaram2023-09-041-3/+18
| | | | | | If we're already in source editor we'll quit as before. It's ugly that app.lua now knows about run.lua. But it's a start.
* stop using keyboard.isDownKartik K. Agaram2023-09-041-2/+18
| | | | It doesn't work on Android, and it's not much work to avoid.
* yet another set of bugfixesKartik K. Agaram2023-08-302-2/+2
| | | | | The key API change I'd underestimated: opening a file used to return nil on failure, and now returns false.
* bugfix in source editorKartik K. Agaram2023-08-301-2/+8
| | | | We now need to explicitly select the directory we want to read from.
* cleaner API for file-system accessKartik K. Agaram2023-08-304-52/+535
| | | | | | | | | | | | | | | | | | | | | Thanks to physfs and nativefs.lua nativefs still introduces some inconsistencies with love.filesystem with relative paths: * love.fs.read: reads from save dir if it exists, falls back to source dir if not * nativefs.read: reads from save dir if it exists, falls back to source dir if not ✓ * love.fs.write: always writes to save dir * nativefs.write: always writes to source dir (since no restrictions) * love.fs.newFile followed by file:open('r'): reads from save dir if it exists, source dir if not * nativefs.newFile followed by file:open('r'): always reads from working dir * love.fs.newFile followed by file:open('w'): always writes to save dir * nativefs.newFile followed by file:open('w'): always writes to working dir So avoid using relative paths with App primitives.
* make a few names consistent with snake_caseKartik K. Agaram2023-08-304-20/+20
|
* reorganize app.lua and its commentsKartik K. Agaram2023-08-261-166/+142
| | | | | | I was so sure my comments were clear when I wrote this a year ago. They were shit. So, most probably, is the current iteration. Feedback appreciated.
* correct various names in this and other pre-freewheeling forksKartik K. Agaram2023-08-261-7/+7
|
* fix method name in documentationKartik K. Agaram2023-08-261-1/+1
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-11-27 07:19:30 +0000