about summary refs log tree commit diff stats
Commit message (Collapse)AuthorAgeFilesLines
* bugfix: clicking on empty linesKartik K. Agaram2022-07-012-1/+18
|
* enforce press/release state only processed onceKartik K. Agaram2022-07-011-4/+7
| | | | | | | | bugfix scenario: press pageup click somewhere near the bottom Before this change the selection was flickering when doing this.
* bugfix: manage screen_top and cursor when resizingKartik K. Agaram2022-07-013-0/+45
|
* bugfix: enable resize when loading settingsKartik K. Agaram2022-06-301-2/+10
|
* right marginKartik K. Agaram2022-06-305-41/+114
|
* start loading settings as applicableKartik K. Agaram2022-06-301-12/+43
|
* start saving some settings to disk on quitKartik K. Agaram2022-06-301-1/+8
| | | | We're still not reading them anywhere.
* initialize screen width to something reasonableKartik K. Agaram2022-06-301-3/+3
|
* rip out geometry commandline argKartik K. Agaram2022-06-301-33/+8
| | | | Let's try really hard to ignore the terminal.
* use the background colorKartik K. Agaram2022-06-301-2/+2
| | | | | I'd hoped this would reduce the blocks of black while resizing, but it doesn't seem to have made a difference.
* stop blanking screen while resizingKartik K. Agaram2022-06-301-9/+0
|
* rip out notion of Line_widthKartik K. Agaram2022-06-306-163/+67
|
* rip out the line-width sliderKartik K. Agaram2022-06-302-48/+0
| | | | | | | New plan: - render text across the whole window - let people resize the window to the desired line width - save window size settings between sessions
* bugfix: lines that aren't drawn from the startKartik K. Agaram2022-06-303-11/+48
| | | | | | | | | | | | | | | I can't believe I didn't catch this until now. All I had to do is open MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout, press page-down and click on the top screen line (or any screen line containing the same line as the top screen line). Easy to catch with any file containing lots of overly long lines, as happens in particular at the start of Moby Dick. I _had_ seen this problem before, but it seemed to disappear after unrelated changes, and I convinced myself I'd fixed it as a side-effect. The bug just failed to manifest if the top line happened to start at the top of the screen. Scroll down a few pages in Moby Dick and the dialogue starts and line length drops precipitously.
* some redundant callsKartik K. Agaram2022-06-301-4/+0
|
* bugfix: save previous file when dropping a new one onKartik K. Agaram2022-06-292-0/+35
|
* new test: dragging and dropping a file on lines.loveKartik K. Agaram2022-06-291-0/+27
|
* avoid redundant writes on exitKartik K. Agaram2022-06-291-1/+3
|
* clarify what "large files" meansKartik K. Agaram2022-06-291-1/+2
|
* clicking to the right of a line within line widthKartik K. Agaram2022-06-292-1/+38
|
* .Kartik K. Agaram2022-06-291-1/+1
|
* bugfix: clicking past end of screen lineKartik K. Agaram2022-06-292-1/+50
| | | | I could swear I checked this at some point. But I didn't have a test!
* bugfix: scrolling in left/right movementsKartik K. Agaram2022-06-282-10/+148
| | | | | I'd always had a funny feeling there was something missing there but somehow never thought of the right failing test.
* when naming points, allow backspacing back to ''Kartik K. Agaram2022-06-271-0/+1
|
* undo commit 861c57b533Kartik K. Agaram2022-06-271-2/+1
| | | | | Turns out ctrl+ makes it into lua.textinput. Thanks John Blommers for the report. This should fix https://github.com/akkartik/lines.love/issues/6.
* bugfix: typing a capital letter deletes selectionKartik K. Agaram2022-06-263-3/+29
|
* bugfix: deleting a selection spanning pagesKartik K. Agaram2022-06-262-0/+29
|
* bugfix: clear selection in a couple more placesKartik K. Agaram2022-06-231-0/+2
|
* bugfix: don't delete selection when moving cursorKartik K. Agaram2022-06-233-1/+23
|
* record one more case I can't automatically detectKartik K. Agaram2022-06-231-0/+5
|
* fix a failing testKartik K. Agaram2022-06-231-4/+2
| | | | | I deployed this without even running it once :/ Production was broken for 9 minutes until I rolled back.
* extract a functionKartik K. Agaram2022-06-232-18/+14
|
* bugfix: recompute screen lines in backspace/deleteKartik K. Agaram2022-06-231-0/+4
| | | | | | | | Scenario: backspacing until a line takes up fewer screen lines, then pressing `down`. I've gone through and checked that fragments and screen_line_starting_pos are now cleared together everywhere.
* keep drawings within the line width slider as wellKartik K. Agaram2022-06-223-29/+30
|
* show the line width when dragging the sliderKartik K. Agaram2022-06-221-0/+4
|
* turns out super- chords to get to textinputKartik K. Agaram2022-06-221-2/+1
|
* bugfix: delete selection before pastingKartik K. Agaram2022-06-213-3/+41
|
* bugfixKartik K. Agaram2022-06-212-1/+8
| | | | | State changes when inserting return are now in sync with other characters.
* better fix for commit 3ffc2ed8fKartik K. Agaram2022-06-201-0/+1
| | | | | | | | | I'm giving up finding a more generalized solution. The issue is that we need the correct selection state right up to the point where we modify Lines, in order to capture precise undo state. Hopefully there aren't any other keychords that should clear the selection.
* revert selection logic to before commit 3ffc2ed8fKartik K. Agaram2022-06-203-8/+12
| | | | | We still have a failing test, but now it's the one we introduced in commit 3ffc2ed8f.
* snapshot: test for a new regressionKartik K. Agaram2022-06-201-0/+22
| | | | | | Caused by commit 3ffc2ed8f. We might need to bring back a lot of complexity for this.
* selection bugfixKartik K. Agaram2022-06-202-1/+19
|
* much simplerKartik K. Agaram2022-06-202-31/+8
| | | | | | | | We just need to ensure textinput events never make use of selection state. All tests are passing, but I'm aware of a couple of issues. But now we can keep all the special cases in one place.
* some early returns should be assertsKartik K. Agaram2022-06-201-1/+3
|
* move Selection1 clearing past business logicKartik K. Agaram2022-06-201-10/+10
| | | | | | Now all the cases that clear Selection1 do so in a very consistent way at the end of each case. And cases that set Selection1 symmetrically do so at the start of each case.
* remove some redundant checksKartik K. Agaram2022-06-201-30/+10
| | | | Now all the cases manage Selection1 similarly.
* no, that's not rightKartik K. Agaram2022-06-203-3/+40
| | | | | | | | | | | | | | Bugfix: we want selections to persist even when we lift up the shift key. This requires hoisting some code inside every case inside the whole keypress hierarchy, to ensure we never clear selections before textinput events can handle them. Current cross-cutting concerns we're explicitly scattering code for. - autosave - undo - selection management
* bugfix: typing should delete highlighted textKartik K. Agaram2022-06-203-9/+29
| | | | The test harness now also mimics real usage more precisely.
* clearer copyKartik K. Agaram2022-06-201-2/+3
|
* bugfixKartik K. Agaram2022-06-193-1/+27
| | | | | | | | | | | | | | | To reproduce: click to position cursor at end of a line hit enter press any key before: newline got erased and key got added to previous line now: newline is preserved The new test checks a generalization of this.