| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |
|
| |
|
|
|
| |
Why are we not modifying Screen_top1.pos in these places? Because we
don't really need to modify Screen_top1 at all.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
It's still a bit simple-minded. Most software will keep the first bound
fixed and move the second. Lines currently has the bounds in a queue of
sorts. But I have a test to indicate the behavior that is definitely
desired. We'll see if we need it to get more complex.
|
| | |
|
| |
|
|
|
|
|
| |
Mouse stuff is pretty strenuous. For the first time I have to be careful
not to recompute too often. And I ran into a race condition for the
first time where resetting line.y within App.draw meant mouse clicks
were extremely unlikely to see line.y set.
|
| |
|
|
| |
Doesn't yet highlight while dragging.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Also clean up drawing state to make sure we don't get into hard-to-debug
situations.
|
| |
|
|
|
|
|
|
|
| |
Incredibly inefficient, but I don't yet know how to efficiently encode
undo mutations that can span multiple lines.
There seems to be one bug related to creating new drawings; they're not
spawning events and undoing past drawing creation has some weird
artifacts. Redo seems to consistently work, though.
|
| | |
|
| |
|
|
|
|
| |
I've written a few tests for delete_selection, but the way different
operations initialize the selection seems fairly standard and not worth
testing so far.
|
| | |
|
| |
|
|
|
| |
I had this idea originally to keep text.lua oblivious to drawings.
But that hasn't been true for some time. Losing battle.
|
| | |
|
| |
|
|
|
| |
I saw screen_top not at start of screen line, but at cursor location in
middle of line.
|
| | |
|
| |
|
|
| |
Along with the App helpers needed for them.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm now extracting the concern of computing
line.screen_line_starting_pos out of Text.draw. Earlier
I had to make sure I ran through the whole line to compute
screen_line_starting_pos, but that had the side-effect of updating
Screen_bottom1.pos as well with lines that had never been rendered.
In this process I hit my first bug due to an accidental global. It
doesn't show up in the patch because I accidentally deleted a local
declaration. (I thought I didn't need screen_line_starting_pos anymore,
deleted everywhere, then brought it back everywhere from the bottom of
the function up, but forgot to put back the very first occurrence.)
The amount of yoyoing this caused between App.draw and Text.draw, I very
much have spaghetti on my hands.
Accidental globals are _terrible_ in a program with tests. Cross test
contamination X-(
|
| |
|
|
| |
It wasn't screen-line aware. Now it is.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Setting up the test just right to test the thing I want to test was a
rube goldberg machine of constants.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also really need to rethink how people debug my programs. My approach
of inserting and deleting print() takes a lot of commitment. I need my
old trace-based whitebox testing idea. However, in my past projects I
never did figure out a good framework for tweaking how verbose a trace
to emit.
Perhaps that's too many knobs. Perhaps we just need a way to run a
single test with the most verbose trace possible. Then it's just a
matter of having the trace tell a coherent story? But even if the trace
stays out of program output in that situation, it's still in the
programmer's face in the _code_. Ugh.
Current plan: ship program with maximum tests and zero commented-out
prints. If you want to debug, insert prints. This is better than
previous, text-mode, projects just by virtue of the stdout channel being
dedicated to debug stuff.
|
| | |
|
| |
|
|
|
| |
Tests still have a lot of side-effects on the real screen. We'll
gradually clean those up.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have no fucking idea what I'm doing. All I know is that there's still
too many goddamn bugs[1]. Test motherfucking harness or bust. For
starters this is just the default love.run from
https://love2d.org/wiki/love.run
[1] The following file crashes if you repeatedly press cursor-down:
<<
a
b
c
```lines
```
x
>>
|
| |
|
|
|
|
| |
non-wrapping
Still lots wrong here.
|
| | |
|
| |
|
|
|
|
|
| |
So far I've just changed how existing variables are organized, and put
some scaffolding in place for dealing with the new types. Next up:
rewriting the code for scrolling to something that feels more obviously
correct.
|
| | |
|
| |
|
|
| |
There's still an absence of affordance showing when you're in naming mode.
|
| | |
|
| |
|
|
|
|
| |
of a line
But we still have work to do for cursor up/down.
|
| |
|
|
| |
Thanks Jimmy Miller for reporting this.
|
| |
|
|
|
| |
I've been only thinking about up arrow when cursor is at top of screen.
Hopefully this is better.
|