about summary refs log tree commit diff stats
path: root/main.lua
Commit message (Collapse)AuthorAgeFilesLines
...
* rip out notion of Line_widthKartik K. Agaram2022-06-301-9/+1
|
* rip out the line-width sliderKartik K. Agaram2022-06-301-30/+0
| | | | | | | New plan: - render text across the whole window - let people resize the window to the desired line width - save window size settings between sessions
* bugfix: lines that aren't drawn from the startKartik K. Agaram2022-06-301-2/+7
| | | | | | | | | | | | | | | I can't believe I didn't catch this until now. All I had to do is open MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout, press page-down and click on the top screen line (or any screen line containing the same line as the top screen line). Easy to catch with any file containing lots of overly long lines, as happens in particular at the start of Moby Dick. I _had_ seen this problem before, but it seemed to disappear after unrelated changes, and I convinced myself I'd fixed it as a side-effect. The bug just failed to manifest if the top line happened to start at the top of the screen. Scroll down a few pages in Moby Dick and the dialogue starts and line length drops precipitously.
* bugfix: save previous file when dropping a new one onKartik K. Agaram2022-06-291-0/+5
|
* avoid redundant writes on exitKartik K. Agaram2022-06-291-1/+3
|
* when naming points, allow backspacing back to ''Kartik K. Agaram2022-06-271-0/+1
|
* bugfix: typing a capital letter deletes selectionKartik K. Agaram2022-06-261-2/+6
|
* bugfix: don't delete selection when moving cursorKartik K. Agaram2022-06-231-1/+1
|
* show the line width when dragging the sliderKartik K. Agaram2022-06-221-0/+4
|
* bugfix: delete selection before pastingKartik K. Agaram2022-06-211-0/+3
|
* revert selection logic to before commit 3ffc2ed8fKartik K. Agaram2022-06-201-4/+0
| | | | | We still have a failing test, but now it's the one we introduced in commit 3ffc2ed8f.
* selection bugfixKartik K. Agaram2022-06-201-1/+1
|
* much simplerKartik K. Agaram2022-06-201-12/+4
| | | | | | | | We just need to ensure textinput events never make use of selection state. All tests are passing, but I'm aware of a couple of issues. But now we can keep all the special cases in one place.
* no, that's not rightKartik K. Agaram2022-06-201-3/+12
| | | | | | | | | | | | | | Bugfix: we want selections to persist even when we lift up the shift key. This requires hoisting some code inside every case inside the whole keypress hierarchy, to ensure we never clear selections before textinput events can handle them. Current cross-cutting concerns we're explicitly scattering code for. - autosave - undo - selection management
* bugfix: typing should delete highlighted textKartik K. Agaram2022-06-201-7/+5
| | | | The test harness now also mimics real usage more precisely.
* bugfixKartik K. Agaram2022-06-191-0/+8
| | | | | | | | | | | | | | | To reproduce: click to position cursor at end of a line hit enter press any key before: newline got erased and key got added to previous line now: newline is preserved The new test checks a generalization of this.
* bugfix: crash in Text.up() after returnKartik K. Agaram2022-06-191-2/+2
| | | | Let's just make all the utf8.offset calculations more defensive.
* make sure to save right when quittingKartik K. Agaram2022-06-181-0/+5
| | | | I just noticed a few characters missing from one of my notes.
* correct location of the line width sliderKartik K. Agaram2022-06-181-2/+2
|
* drop last couple of manual testsKartik K. Agaram2022-06-171-1/+3
|
* affordance to adjust width for word wrapKartik K. Agaram2022-06-171-1/+29
|
* indentKartik K. Agaram2022-06-171-4/+4
|
* autosave slightly less aggressivelyKartik K. Agaram2022-06-171-12/+23
| | | | | | | | It might reduce wear and tear on disk, and losing 3 seconds of data doesn't feel catastrophic (short of a C-z rampage). Thanks to the love2d.org community for the suggestion: https://love2d.org/forums/viewtopic.php?f=14&t=93173
* test: undo naming a pointKartik K. Agaram2022-06-141-0/+2
| | | | Also ensure we autosave.
* test: naming a pointKartik K. Agaram2022-06-141-1/+4
|
* drop non-existent feature from commentKartik K. Agaram2022-06-141-1/+0
|
* extract variables for drawing paddingKartik K. Agaram2022-06-141-2/+6
|
* extract variable Margin_leftKartik K. Agaram2022-06-141-1/+2
|
* mouse buttons are integers, not stringsKartik K. Agaram2022-06-141-4/+4
| | | | | | Not sure where that idiom comes from or why strings work in some places (auto-coercion?). I picked it up off some example apps. But https://love2d.org/wiki/love.mouse.isDown says it should be an integer.
* cleanupKartik K. Agaram2022-06-141-6/+0
|
* bugfixKartik K. Agaram2022-06-141-0/+8
| | | | | | | | | | | | | | | | | | | | | | | manifestation: clicking past end of a long, wrapping line containing non-ASCII would cause the cursor to disappear rather than position past end of screen line. Hitting enter would then throw an assertion with the following stack trace: Error: text.lua:381: bad argument #2 to 'sub' (number expected, got nil) stack traceback: [love "boot.lua"]:345: in function <[love "boot.lua"]:341> [C]: in function 'sub' text.lua:381: in function 'insert_return' text.lua:179: in function 'keychord_pressed' main.lua:495: in function 'keychord_pressed' keychord.lua:10: in function <keychord.lua:5> app.lua:34: in function <app.lua:25> [C]: in function 'xpcall' cause: the click caused a call to Text.to_pos_on_line whose result was not on a UTF-8 character boundary. fix: make to_pos_on_line utf8-aware.
* bugfix: UTF-8 in compute_fragmentsKartik K. Agaram2022-06-141-0/+2
|
* override mouse state lookups in testsKartik K. Agaram2022-06-121-3/+3
| | | | | | | If I'd had this stuff in my test harness earlier, two recent commits would have failed tests and given me early warning: ff88238ff1 ff88a2a927
* bugfix in commit e51ce12969Kartik K. Agaram2022-06-121-4/+6
| | | | | | | | | Any time I press a ctrl- chord LÖVE actually sees two key chords: C-lctrl C-... (the real one) But it's not just that. There's also a lot in the codebase that's just habit-based. I need more tests.
* bugfix: BSOD in #4.Kartik K. Agaram2022-06-111-2/+2
| | | | I messed up a function call in commit 391d764e13.
* bugfix: autosave and undo in a couple of casesKartik K. Agaram2022-06-111-0/+6
| | | | This fixes part of #4, but not the BSOD.
* bugfix: missed fixing a callsiteKartik K. Agaram2022-06-111-1/+1
|
* stop handling nil screen_line_starting_pos everywhereKartik K. Agaram2022-06-101-1/+0
| | | | Things seem to be working..
* more precise scroll on pasteKartik K. Agaram2022-06-101-19/+4
|
* faster pasteKartik K. Agaram2022-06-101-9/+7
| | | | | We don't need to perform the scroll calculations after inserting every single character from the clipboard.
* revert previous commitKartik K. Agaram2022-06-101-5/+15
|
* experiment: extremely precise scrolling on pasteKartik K. Agaram2022-06-101-15/+5
| | | | But this is too slow.
* while we're at it, undo naming pointsKartik K. Agaram2022-06-101-0/+2
|
* stop saving the entire file when modifying drawingsKartik K. Agaram2022-06-101-0/+8
| | | | Now we just disallow that entirely.
* undo creating new drawingsKartik K. Agaram2022-06-101-1/+3
|
* extract scrolling logic out of insert_at_cursorKartik K. Agaram2022-06-101-0/+6
|
* extract scrolling logic out of insert_returnKartik K. Agaram2022-06-101-0/+3
|
* remove some memory leaks from rendered fragmentsKartik K. Agaram2022-06-101-0/+3
| | | | | | | | | | | | | | | All signs so far seem to be that CPU is cheap for this application, but memory is expensive. It's easy to get sluggish if the GC comes on. After some experiments using https://github.com/yaukeywang/LuaMemorySnapshotDump, one source of memory leaks is rendered fragments (https://love2d.org/wiki/Text objects). I need to render text in approximately word-sized fragments to mostly break lines more intelligently at word boundaries. I've attached the files I used for my experiments (suffixed with a '.') There's definitely still a leak in fragments. The longer I edit, the more memory goes to them.
* fix a corner case when selecting textKartik K. Agaram2022-06-091-9/+21
| | | | | The hard part here is keeping click-drag selection working (without pressing and holding shift).
* .Kartik K. Agaram2022-06-091-4/+2
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-12-27 15:00:50 +0000