about summary refs log tree commit diff stats
path: root/text.lua
Commit message (Collapse)AuthorAgeFilesLines
...
* add state arg to a few functionsKartik K. Agaram2022-07-121-12/+12
| | | | | | | - record_undo_event - undo_event - redo_event - snapshot
* add state arg to a few functionsKartik K. Agaram2022-07-121-4/+4
| | | | | | | | | | | - Text.draw_highlight - Text.clip_selection - Text.selection - Text.cut_selection - Text.delete_selection - Text.delete_selection_without_undo - Text.mouse_pos - Text.to_pos
* add state arg to a few functionsKartik K. Agaram2022-07-121-122/+122
| | | | | | | | | | | | | - Text.insert_at_cursor - Text.insert_return - Text.pageup - Text.pagedown - Text.up - Text.down - Text.start_of_line - Text.end_of_line - Text.word_left - Text.word_right
* add state arg to Text.textinputKartik K. Agaram2022-07-121-8/+8
|
* add state arg to schedule_saveKartik K. Agaram2022-07-121-6/+6
|
* add state arg to Text.keychord_pressedKartik K. Agaram2022-07-121-104/+104
|
* add state arg to some functionsKartik K. Agaram2022-07-121-22/+22
| | | | | | - Text.draw - Text.draw_cursor - Text.draw_search_bar
* group all editor globalsKartik K. Agaram2022-07-121-299/+299
| | | | We're still accessing them through a global. But we'll change that next.
* make colors easier to editKartik K. Agaram2022-07-111-4/+4
|
* stop pretending globals are localKartik K. Agaram2022-07-111-4/+0
| | | | | One advantage of this approach: we don't end up with multiple lexical scopes containing duplicates of the same modules.
* skip multiple consecutive whitespaceKartik K. Agaram2022-07-111-2/+27
|
* support other whitespace chars in word movementsKartik K. Agaram2022-07-111-5/+11
|
* done passing left/right margins everywhereKartik K. Agaram2022-07-081-16/+16
| | | | | | | The final step is to add them to: - Text.compute_fragments Doing it carefully caught 5 call-sites that my tests didn't catch.
* add args to some functionsKartik K. Agaram2022-07-081-14/+14
| | | | - Text.populate_screen_line_starting_pos
* add args to some functionsKartik K. Agaram2022-07-081-6/+6
| | | | - Text.to2
* add args to some functionsKartik K. Agaram2022-07-081-5/+5
| | | | - Text.previous_screen_line
* add args to some functionsKartik K. Agaram2022-07-081-10/+10
| | | | - Text.snap_cursor_to_bottom_of_screen
* add args to some functionsKartik K. Agaram2022-07-081-10/+12
| | | | - Text.nearest_cursor_pos
* add args to some functionsKartik K. Agaram2022-07-081-3/+3
| | | | - Text.move_cursor_down_to_next_text_line_while_scrolling_again_if_necessary
* add args to some functionsKartik K. Agaram2022-07-081-2/+2
| | | | - Text.cursor_at_final_screen_line
* add args to some functionsKartik K. Agaram2022-07-081-5/+5
| | | | - Text.pos_at_start_of_cursor_screen_line
* add args to some functionsKartik K. Agaram2022-07-081-3/+2
| | | | - Text.to_pos_on_line
* indentKartik K. Agaram2022-07-081-1/+4
|
* add args to some functionsKartik K. Agaram2022-07-081-2/+2
| | | | - Text.in_line
* add args to some functionsKartik K. Agaram2022-07-081-3/+3
| | | | | | | | | - Text.clip_selection - Text.cut_selection - Text.delete_selection - Text.delete_selection_without_undo - Text.mouse_pos - Text.to_pos
* add args to some functionsKartik K. Agaram2022-07-081-28/+28
| | | | | | | | | | | | - Text.pageup - Text.pagedown - Text.up - Text.down - Text.end_of_line - Text.word_left - Text.word_right - Text.left - Text.right
* start passing left/right margins everywhereKartik K. Agaram2022-07-081-8/+8
| | | | | | | | | | | I have a set of changes that passes all tests, but I'm going to commit them very carefully to ensure I don't miss any call-sites. In this commit I'm adding the args to: - Text.draw - Text.tweak_screen_top_and_cursor But calls within them don't yet pass them where they should. In this manner I'm going to progress systematically from the top down.
* rename a couple of variablesKartik K. Agaram2022-07-081-10/+10
|
* drop an arg from a functionKartik K. Agaram2022-07-081-1/+1
|
* switch arg for a functionKartik K. Agaram2022-07-081-15/+11
|
* optimization: moving cursor to next wordKartik K. Agaram2022-07-051-4/+12
|
* bugfix: avoid scrolling on 'end'Kartik K. Agaram2022-07-051-6/+14
| | | | | There's multiple ways to do this, only one of them is right, and I keep forgetting what it is. Turn it into a method.
* bugfix: manage screen_top and cursor when resizingKartik K. Agaram2022-07-011-0/+35
|
* right marginKartik K. Agaram2022-06-301-14/+14
|
* rip out notion of Line_widthKartik K. Agaram2022-06-301-21/+20
|
* bugfix: lines that aren't drawn from the startKartik K. Agaram2022-06-301-9/+20
| | | | | | | | | | | | | | | I can't believe I didn't catch this until now. All I had to do is open MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout, press page-down and click on the top screen line (or any screen line containing the same line as the top screen line). Easy to catch with any file containing lots of overly long lines, as happens in particular at the start of Moby Dick. I _had_ seen this problem before, but it seemed to disappear after unrelated changes, and I convinced myself I'd fixed it as a side-effect. The bug just failed to manifest if the top line happened to start at the top of the screen. Scroll down a few pages in Moby Dick and the dialogue starts and line length drops precipitously.
* clicking to the right of a line within line widthKartik K. Agaram2022-06-291-1/+16
|
* .Kartik K. Agaram2022-06-291-1/+1
|
* bugfix: clicking past end of screen lineKartik K. Agaram2022-06-291-1/+1
| | | | I could swear I checked this at some point. But I didn't have a test!
* bugfix: scrolling in left/right movementsKartik K. Agaram2022-06-281-10/+30
| | | | | I'd always had a funny feeling there was something missing there but somehow never thought of the right failing test.
* undo commit 861c57b533Kartik K. Agaram2022-06-271-2/+1
| | | | | Turns out ctrl+ makes it into lua.textinput. Thanks John Blommers for the report. This should fix https://github.com/akkartik/lines.love/issues/6.
* bugfix: clear selection in a couple more placesKartik K. Agaram2022-06-231-0/+2
|
* fix a failing testKartik K. Agaram2022-06-231-4/+2
| | | | | I deployed this without even running it once :/ Production was broken for 9 minutes until I rolled back.
* extract a functionKartik K. Agaram2022-06-231-16/+13
|
* bugfix: recompute screen lines in backspace/deleteKartik K. Agaram2022-06-231-0/+4
| | | | | | | | Scenario: backspacing until a line takes up fewer screen lines, then pressing `down`. I've gone through and checked that fragments and screen_line_starting_pos are now cleared together everywhere.
* turns out super- chords to get to textinputKartik K. Agaram2022-06-221-2/+1
|
* bugfix: delete selection before pastingKartik K. Agaram2022-06-211-3/+0
|
* bugfixKartik K. Agaram2022-06-211-1/+4
| | | | | State changes when inserting return are now in sync with other characters.
* better fix for commit 3ffc2ed8fKartik K. Agaram2022-06-201-0/+1
| | | | | | | | | I'm giving up finding a more generalized solution. The issue is that we need the correct selection state right up to the point where we modify Lines, in order to capture precise undo state. Hopefully there aren't any other keychords that should clear the selection.
* revert selection logic to before commit 3ffc2ed8fKartik K. Agaram2022-06-201-4/+11
| | | | | We still have a failing test, but now it's the one we introduced in commit 3ffc2ed8f.