about summary refs log tree commit diff stats
path: root/text.lua
Commit message (Collapse)AuthorAgeFilesLines
* optimization: moving cursor to next wordKartik K. Agaram2022-07-051-4/+12
|
* bugfix: avoid scrolling on 'end'Kartik K. Agaram2022-07-051-6/+14
| | | | | There's multiple ways to do this, only one of them is right, and I keep forgetting what it is. Turn it into a method.
* bugfix: manage screen_top and cursor when resizingKartik K. Agaram2022-07-011-0/+35
|
* right marginKartik K. Agaram2022-06-301-14/+14
|
* rip out notion of Line_widthKartik K. Agaram2022-06-301-21/+20
|
* bugfix: lines that aren't drawn from the startKartik K. Agaram2022-06-301-9/+20
| | | | | | | | | | | | | | | I can't believe I didn't catch this until now. All I had to do is open MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout, press page-down and click on the top screen line (or any screen line containing the same line as the top screen line). Easy to catch with any file containing lots of overly long lines, as happens in particular at the start of Moby Dick. I _had_ seen this problem before, but it seemed to disappear after unrelated changes, and I convinced myself I'd fixed it as a side-effect. The bug just failed to manifest if the top line happened to start at the top of the screen. Scroll down a few pages in Moby Dick and the dialogue starts and line length drops precipitously.
* clicking to the right of a line within line widthKartik K. Agaram2022-06-291-1/+16
|
* .Kartik K. Agaram2022-06-291-1/+1
|
* bugfix: clicking past end of screen lineKartik K. Agaram2022-06-291-1/+1
| | | | I could swear I checked this at some point. But I didn't have a test!
* bugfix: scrolling in left/right movementsKartik K. Agaram2022-06-281-10/+30
| | | | | I'd always had a funny feeling there was something missing there but somehow never thought of the right failing test.
* undo commit 861c57b533Kartik K. Agaram2022-06-271-2/+1
| | | | | Turns out ctrl+ makes it into lua.textinput. Thanks John Blommers for the report. This should fix https://github.com/akkartik/lines.love/issues/6.
* bugfix: clear selection in a couple more placesKartik K. Agaram2022-06-231-0/+2
|
* fix a failing testKartik K. Agaram2022-06-231-4/+2
| | | | | I deployed this without even running it once :/ Production was broken for 9 minutes until I rolled back.
* extract a functionKartik K. Agaram2022-06-231-16/+13
|
* bugfix: recompute screen lines in backspace/deleteKartik K. Agaram2022-06-231-0/+4
| | | | | | | | Scenario: backspacing until a line takes up fewer screen lines, then pressing `down`. I've gone through and checked that fragments and screen_line_starting_pos are now cleared together everywhere.
* turns out super- chords to get to textinputKartik K. Agaram2022-06-221-2/+1
|
* bugfix: delete selection before pastingKartik K. Agaram2022-06-211-3/+0
|
* bugfixKartik K. Agaram2022-06-211-1/+4
| | | | | State changes when inserting return are now in sync with other characters.
* better fix for commit 3ffc2ed8fKartik K. Agaram2022-06-201-0/+1
| | | | | | | | | I'm giving up finding a more generalized solution. The issue is that we need the correct selection state right up to the point where we modify Lines, in order to capture precise undo state. Hopefully there aren't any other keychords that should clear the selection.
* revert selection logic to before commit 3ffc2ed8fKartik K. Agaram2022-06-201-4/+11
| | | | | We still have a failing test, but now it's the one we introduced in commit 3ffc2ed8f.
* much simplerKartik K. Agaram2022-06-201-19/+4
| | | | | | | | We just need to ensure textinput events never make use of selection state. All tests are passing, but I'm aware of a couple of issues. But now we can keep all the special cases in one place.
* some early returns should be assertsKartik K. Agaram2022-06-201-1/+3
|
* move Selection1 clearing past business logicKartik K. Agaram2022-06-201-10/+10
| | | | | | Now all the cases that clear Selection1 do so in a very consistent way at the end of each case. And cases that set Selection1 symmetrically do so at the start of each case.
* remove some redundant checksKartik K. Agaram2022-06-201-30/+10
| | | | Now all the cases manage Selection1 similarly.
* no, that's not rightKartik K. Agaram2022-06-201-0/+6
| | | | | | | | | | | | | | Bugfix: we want selections to persist even when we lift up the shift key. This requires hoisting some code inside every case inside the whole keypress hierarchy, to ensure we never clear selections before textinput events can handle them. Current cross-cutting concerns we're explicitly scattering code for. - autosave - undo - selection management
* bugfixKartik K. Agaram2022-06-191-1/+1
| | | | | | | | | | | | | | | To reproduce: click to position cursor at end of a line hit enter press any key before: newline got erased and key got added to previous line now: newline is preserved The new test checks a generalization of this.
* bugfix: crash in Text.up() after returnKartik K. Agaram2022-06-191-29/+22
| | | | Let's just make all the utf8.offset calculations more defensive.
* correct location of the line width sliderKartik K. Agaram2022-06-181-0/+1
|
* autosave slightly less aggressivelyKartik K. Agaram2022-06-171-6/+6
| | | | | | | | It might reduce wear and tear on disk, and losing 3 seconds of data doesn't feel catastrophic (short of a C-z rampage). Thanks to the love2d.org community for the suggestion: https://love2d.org/forums/viewtopic.php?f=14&t=93173
* extract variables for drawing paddingKartik K. Agaram2022-06-141-3/+3
|
* extract variable Margin_leftKartik K. Agaram2022-06-141-11/+11
|
* mouse buttons are integers, not stringsKartik K. Agaram2022-06-141-1/+1
| | | | | | Not sure where that idiom comes from or why strings work in some places (auto-coercion?). I picked it up off some example apps. But https://love2d.org/wiki/love.mouse.isDown says it should be an integer.
* go through and fix similar issuesKartik K. Agaram2022-06-141-6/+12
| | | | All places where string.sub was being passed a _pos variable.
* bugfixKartik K. Agaram2022-06-141-4/+13
| | | | | | | | | | | | | | | | | | | | | | | manifestation: clicking past end of a long, wrapping line containing non-ASCII would cause the cursor to disappear rather than position past end of screen line. Hitting enter would then throw an assertion with the following stack trace: Error: text.lua:381: bad argument #2 to 'sub' (number expected, got nil) stack traceback: [love "boot.lua"]:345: in function <[love "boot.lua"]:341> [C]: in function 'sub' text.lua:381: in function 'insert_return' text.lua:179: in function 'keychord_pressed' main.lua:495: in function 'keychord_pressed' keychord.lua:10: in function <keychord.lua:5> app.lua:34: in function <app.lua:25> [C]: in function 'xpcall' cause: the click caused a call to Text.to_pos_on_line whose result was not on a UTF-8 character boundary. fix: make to_pos_on_line utf8-aware.
* bugfix: UTF-8 in compute_fragmentsKartik K. Agaram2022-06-141-5/+7
|
* override mouse state lookups in testsKartik K. Agaram2022-06-121-1/+1
| | | | | | | If I'd had this stuff in my test harness earlier, two recent commits would have failed tests and given me early warning: ff88238ff1 ff88a2a927
* bugfix: BSOD in #4.Kartik K. Agaram2022-06-111-2/+2
| | | | I messed up a function call in commit 391d764e13.
* stop handling nil screen_line_starting_pos everywhereKartik K. Agaram2022-06-101-23/+6
| | | | Things seem to be working..
* this fixes the immediate regressionKartik K. Agaram2022-06-101-19/+17
|
* stop repeatedly checking for line wrappingKartik K. Agaram2022-06-101-7/+8
| | | | | | We have a regression since we started reclaiming love Text fragments more aggressively in commit 69c5d844ccc. Pressing pageup no longer knows about any line's screen lines. Not fixed yet.
* .Kartik K. Agaram2022-06-101-1/+1
|
* extract scrolling logic out of insert_at_cursorKartik K. Agaram2022-06-101-6/+12
|
* extract scrolling logic out of insert_returnKartik K. Agaram2022-06-101-4/+3
|
* remove some memory leaks from rendered fragmentsKartik K. Agaram2022-06-101-0/+4
| | | | | | | | | | | | | | | All signs so far seem to be that CPU is cheap for this application, but memory is expensive. It's easy to get sluggish if the GC comes on. After some experiments using https://github.com/yaukeywang/LuaMemorySnapshotDump, one source of memory leaks is rendered fragments (https://love2d.org/wiki/Text objects). I need to render text in approximately word-sized fragments to mostly break lines more intelligently at word boundaries. I've attached the files I used for my experiments (suffixed with a '.') There's definitely still a leak in fragments. The longer I edit, the more memory goes to them.
* experiment: blinking cursorKartik K. Agaram2022-06-091-3/+6
| | | | | | | | | I've tried to keep the time period of the blinking similar to my terminal. Honestly I'm no longer sure if any of my experiments are showing a statistically significant result. Let's see how it feels over a period of time.
* the problem is that the cursor can occlude textKartik K. Agaram2022-06-091-1/+1
| | | | | | | And anything we do to reduce the occlusion also makes the cursor harder to acquire. I suppose this is why we need the blink.
* make the cursor a little thickerKartik K. Agaram2022-06-091-1/+1
| | | | | | | I'm testing this by moving the cursor around with my eyes closed, then starting a stopwatch as I open my eyes. This seems to help a bit. I'm able to acquire the cursor in 2s. At least the 10s outliers I used to have with the circle or thin line don't seem to be happening.
* experiment: line cursorKartik K. Agaram2022-06-091-1/+1
|
* fix a crashKartik K. Agaram2022-06-061-1/+3
| | | | | This one isn't worth debugging. We know how to recreate this data on demand.
* additional logging for an active bugKartik K. Agaram2022-06-051-1/+5
|
generated by cgit-pink 1.4.1-2-gfad0 (git 2.36.2.497.gbbea4dcf42) at 2024-12-16 03:07:53 +0000