| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
| |
The published version of lines.love was broken for almost an hour. The
cursor would render one position to the right of where it really is. To
fix it, this commit rolls back 26ba6e4e5a71. There doesn't seem a good
way to test it.
|
| |
|
|
|
| |
Gratifying how few tests need changing. Recent commits seem on the right
track.
|
| |
|
|
| |
This eliminates another case of overflowing margins.
|
| |
|
|
|
|
| |
The cost is just having to tweak a few more brittle tests. I can't
actually perceive any difference in how the cursor moves when I click on
text.
|
| |
|
|
|
|
|
|
|
|
| |
I've been sloppy about this so far, and outside of tests I can't find
any examples where it matters, but it matters in a potential fork where
I'm rendering multiple columns of text.
It's unfortunate that my tests have this level of brittleness. What I'd
really like to assert in many of these changed lines is that the text
stays inside the margins and that more text would overflow margins.
|
| | |
|
| | |
|
| |
|
|
| |
I have no idea what the performance implications of this are..
|
| |
|
|
|
| |
It's starting to sink in that I don't want hard-coded constants inside
objects.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Editor state initialization now depends on window dimensions, so we have
to more carefully orchestrate startup.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
In this commit, top-level edit functions:
- edit.draw
- edit.update
- edit.quit
- edit.mouse_pressed
- edit.mouse_released
- edit.textinput
- edit.keychord_pressed
- edit.key_released
|
| | |
|
| |
|
|
| |
We're still accessing them through a global. But we'll change that next.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Thanks Leonard Schütz for the report!
Failing scenario:
click to move cursor
hit backspace
First backspace wasn't being doing anything earlier.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I can't believe I didn't catch this until now. All I had to do is open
MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout,
press page-down and click on the top screen line (or any screen line
containing the same line as the top screen line). Easy to catch with any
file containing lots of overly long lines, as happens in particular at
the start of Moby Dick.
I _had_ seen this problem before, but it seemed to disappear after
unrelated changes, and I convinced myself I'd fixed it as a side-effect.
The bug just failed to manifest if the top line happened to start at the
top of the screen. Scroll down a few pages in Moby Dick and the dialogue
starts and line length drops precipitously.
|
| | |
|
| | |
|
| |
|
|
| |
I could swear I checked this at some point. But I didn't have a test!
|
| |
|
|
|
| |
I'd always had a funny feeling there was something missing there but
somehow never thought of the right failing test.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
We still have a failing test, but now it's the one we introduced in
commit 3ffc2ed8f.
|
| |
|
|
|
|
| |
Caused by commit 3ffc2ed8f.
We might need to bring back a lot of complexity for this.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bugfix: we want selections to persist even when we lift up the shift
key.
This requires hoisting some code inside every case inside the whole
keypress hierarchy, to ensure we never clear selections before
textinput events can handle them.
Current cross-cutting concerns we're explicitly scattering code for.
- autosave
- undo
- selection management
|
| |
|
|
| |
The test harness now also mimics real usage more precisely.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reproduce:
click to position cursor at end of a line
hit enter
press any key
before:
newline got erased and key got added to previous line
now:
newline is preserved
The new test checks a generalization of this.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
I've been adding diligently to manual_tests but not actually
_performing_ any manual tests before releases. They were just a todo
list of automated tests to write, and long out of date. Now the list is
up to date and much shorter.
|
| |
|
|
|
|
| |
Not sure where that idiom comes from or why strings work in some places
(auto-coercion?). I picked it up off some example apps. But
https://love2d.org/wiki/love.mouse.isDown says it should be an integer.
|
| |
|
|
|
| |
The default font seems somehow different than the font created by
newFont with just a font size.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
manifestation: clicking past end of a long, wrapping line containing
non-ASCII would cause the cursor to disappear rather than position past
end of screen line. Hitting enter would then throw an assertion with the
following stack trace:
Error: text.lua:381: bad argument #2 to 'sub' (number expected, got nil)
stack traceback:
[love "boot.lua"]:345: in function <[love "boot.lua"]:341>
[C]: in function 'sub'
text.lua:381: in function 'insert_return'
text.lua:179: in function 'keychord_pressed'
main.lua:495: in function 'keychord_pressed'
keychord.lua:10: in function <keychord.lua:5>
app.lua:34: in function <app.lua:25>
[C]: in function 'xpcall'
cause: the click caused a call to Text.to_pos_on_line whose result was
not on a UTF-8 character boundary.
fix: make to_pos_on_line utf8-aware.
|
| | |
|
| | |
|