about summary refs log tree commit diff stats
path: root/text_tests.lua
Commit message (Collapse)AuthorAgeFilesLines
* bugfix: backspace from start of final lineKartik K. Agaram2022-08-101-0/+16
|
* click to the left of a lineKartik K. Agaram2022-07-291-0/+19
|
* line.y -> line_cache.starty in a few more placesKartik K. Agaram2022-07-271-4/+4
| | | | | | Disquieting that none of my tests caught these. On the other hand, I also haven't noticed any issues in practice. Perhaps cache invalidation is often unnecessary.
* bugfix: skip over drawings when searchingKartik K. Agaram2022-07-251-7/+2
|
* bugfix: searchKartik K. Agaram2022-07-211-0/+33
| | | | | Broken since commit 188bbc73 9 days ago :/ At least we have a test for it now.
* bugfix: where cursor is drawnKartik K. Agaram2022-07-201-10/+10
| | | | | | | The published version of lines.love was broken for almost an hour. The cursor would render one position to the right of where it really is. To fix it, this commit rolls back 26ba6e4e5a71. There doesn't seem a good way to test it.
* exclude left margin from my word-split heuristicKartik K. Agaram2022-07-201-2/+2
| | | | | Gratifying how few tests need changing. Recent commits seem on the right track.
* allow Text.nearest_pos_less_than to return 0Kartik K. Agaram2022-07-201-2/+2
| | | | This eliminates another case of overflowing margins.
* unify two similar functionsKartik K. Agaram2022-07-191-13/+12
| | | | | | The cost is just having to tweak a few more brittle tests. I can't actually perceive any difference in how the cursor moves when I click on text.
* keep text from overflowing right marginKartik K. Agaram2022-07-191-36/+33
| | | | | | | | | | I've been sloppy about this so far, and outside of tests I can't find any examples where it matters, but it matters in a potential fork where I'm rendering multiple columns of text. It's unfortunate that my tests have this level of brittleness. What I'd really like to assert in many of these changed lines is that the text stays inside the margins and that more text would overflow margins.
* delete some duplicate initializationKartik K. Agaram2022-07-191-4/+0
|
* bugfix: couple of margin-relative computationsKartik K. Agaram2022-07-171-1/+61
|
* separate data structure for each line's cache dataKartik K. Agaram2022-07-171-12/+96
| | | | I have no idea what the performance implications of this are..
* bring back a set of constantsKartik K. Agaram2022-07-161-1/+1
| | | | | It's starting to sink in that I don't want hard-coded constants inside objects.
* more decoupling editor tests from AppKartik K. Agaram2022-07-161-1/+1
|
* more decoupling editor tests from AppKartik K. Agaram2022-07-161-3/+3
|
* make test initializations a little more obviousKartik K. Agaram2022-07-151-93/+93
|
* left/right margin -> left/right coordinatesKartik K. Agaram2022-07-121-121/+214
| | | | | Editor state initialization now depends on window dimensions, so we have to more carefully orchestrate startup.
* call edit rather than App callbacks in testsKartik K. Agaram2022-07-121-101/+101
|
* start passing in Editor_state explicitlyKartik K. Agaram2022-07-121-76/+77
| | | | | | | | | | | | In this commit, top-level edit functions: - edit.draw - edit.update - edit.quit - edit.mouse_pressed - edit.mouse_released - edit.textinput - edit.keychord_pressed - edit.key_released
* initialize contains test stateKartik K. Agaram2022-07-121-87/+0
|
* group all editor globalsKartik K. Agaram2022-07-121-877/+877
| | | | We're still accessing them through a global. But we'll change that next.
* start decoupling editor tests from AppKartik K. Agaram2022-07-111-76/+76
|
* skip multiple consecutive whitespaceKartik K. Agaram2022-07-111-0/+22
|
* support other whitespace chars in word movementsKartik K. Agaram2022-07-111-0/+22
|
* flesh out some tests for word movementsKartik K. Agaram2022-07-111-0/+125
|
* yet another bugfix in selection managementKartik K. Agaram2022-07-071-18/+1
| | | | | | | | | | Thanks Leonard Schütz for the report! Failing scenario: click to move cursor hit backspace First backspace wasn't being doing anything earlier.
* bugfix: clicking on empty linesKartik K. Agaram2022-07-011-0/+16
|
* right marginKartik K. Agaram2022-06-301-0/+71
|
* rip out notion of Line_widthKartik K. Agaram2022-06-301-84/+17
|
* bugfix: lines that aren't drawn from the startKartik K. Agaram2022-06-301-0/+21
| | | | | | | | | | | | | | | I can't believe I didn't catch this until now. All I had to do is open MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout, press page-down and click on the top screen line (or any screen line containing the same line as the top screen line). Easy to catch with any file containing lots of overly long lines, as happens in particular at the start of Moby Dick. I _had_ seen this problem before, but it seemed to disappear after unrelated changes, and I convinced myself I'd fixed it as a side-effect. The bug just failed to manifest if the top line happened to start at the top of the screen. Scroll down a few pages in Moby Dick and the dialogue starts and line length drops precipitously.
* some redundant callsKartik K. Agaram2022-06-301-4/+0
|
* clicking to the right of a line within line widthKartik K. Agaram2022-06-291-0/+22
|
* bugfix: clicking past end of screen lineKartik K. Agaram2022-06-291-0/+49
| | | | I could swear I checked this at some point. But I didn't have a test!
* bugfix: scrolling in left/right movementsKartik K. Agaram2022-06-281-0/+118
| | | | | I'd always had a funny feeling there was something missing there but somehow never thought of the right failing test.
* bugfix: typing a capital letter deletes selectionKartik K. Agaram2022-06-261-0/+22
|
* bugfix: deleting a selection spanning pagesKartik K. Agaram2022-06-261-0/+25
|
* bugfix: don't delete selection when moving cursorKartik K. Agaram2022-06-231-0/+18
|
* keep drawings within the line width slider as wellKartik K. Agaram2022-06-221-2/+3
|
* bugfix: delete selection before pastingKartik K. Agaram2022-06-211-0/+38
|
* revert selection logic to before commit 3ffc2ed8fKartik K. Agaram2022-06-201-0/+1
| | | | | We still have a failing test, but now it's the one we introduced in commit 3ffc2ed8f.
* snapshot: test for a new regressionKartik K. Agaram2022-06-201-0/+22
| | | | | | Caused by commit 3ffc2ed8f. We might need to bring back a lot of complexity for this.
* selection bugfixKartik K. Agaram2022-06-201-0/+18
|
* no, that's not rightKartik K. Agaram2022-06-201-0/+22
| | | | | | | | | | | | | | Bugfix: we want selections to persist even when we lift up the shift key. This requires hoisting some code inside every case inside the whole keypress hierarchy, to ensure we never clear selections before textinput events can handle them. Current cross-cutting concerns we're explicitly scattering code for. - autosave - undo - selection management
* bugfix: typing should delete highlighted textKartik K. Agaram2022-06-201-0/+17
| | | | The test harness now also mimics real usage more precisely.
* bugfixKartik K. Agaram2022-06-191-0/+18
| | | | | | | | | | | | | | | To reproduce: click to position cursor at end of a line hit enter press any key before: newline got erased and key got added to previous line now: newline is preserved The new test checks a generalization of this.
* extract variables for drawing paddingKartik K. Agaram2022-06-141-1/+1
|
* extract variable Margin_leftKartik K. Agaram2022-06-141-44/+38
|
* .Kartik K. Agaram2022-06-141-1/+0
|
* lots more testsKartik K. Agaram2022-06-141-0/+65
| | | | | | | I've been adding diligently to manual_tests but not actually _performing_ any manual tests before releases. They were just a todo list of automated tests to write, and long out of date. Now the list is up to date and much shorter.