Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | bugfix: check after cursor on same line when searching upwards | Kartik K. Agaram | 2022-08-11 | 1 | -0/+19 |
| | |||||
* | bugfix: search upwards | Kartik K. Agaram | 2022-08-11 | 1 | -0/+19 |
| | |||||
* | bugfix: check before cursor on same line | Kartik K. Agaram | 2022-08-11 | 1 | -0/+19 |
| | |||||
* | bugfix: pagedown was sometimes bouncing up | Kartik K. Agaram | 2022-08-10 | 1 | -0/+17 |
| | |||||
* | bugfix: backspace from start of final line | Kartik K. Agaram | 2022-08-10 | 1 | -0/+16 |
| | |||||
* | click to the left of a line | Kartik K. Agaram | 2022-07-29 | 1 | -0/+19 |
| | |||||
* | line.y -> line_cache.starty in a few more places | Kartik K. Agaram | 2022-07-27 | 1 | -4/+4 |
| | | | | | | Disquieting that none of my tests caught these. On the other hand, I also haven't noticed any issues in practice. Perhaps cache invalidation is often unnecessary. | ||||
* | bugfix: skip over drawings when searching | Kartik K. Agaram | 2022-07-25 | 1 | -7/+2 |
| | |||||
* | bugfix: search | Kartik K. Agaram | 2022-07-21 | 1 | -0/+33 |
| | | | | | Broken since commit 188bbc73 9 days ago :/ At least we have a test for it now. | ||||
* | bugfix: where cursor is drawn | Kartik K. Agaram | 2022-07-20 | 1 | -10/+10 |
| | | | | | | | The published version of lines.love was broken for almost an hour. The cursor would render one position to the right of where it really is. To fix it, this commit rolls back 26ba6e4e5a71. There doesn't seem a good way to test it. | ||||
* | exclude left margin from my word-split heuristic | Kartik K. Agaram | 2022-07-20 | 1 | -2/+2 |
| | | | | | Gratifying how few tests need changing. Recent commits seem on the right track. | ||||
* | allow Text.nearest_pos_less_than to return 0 | Kartik K. Agaram | 2022-07-20 | 1 | -2/+2 |
| | | | | This eliminates another case of overflowing margins. | ||||
* | unify two similar functions | Kartik K. Agaram | 2022-07-19 | 1 | -13/+12 |
| | | | | | | The cost is just having to tweak a few more brittle tests. I can't actually perceive any difference in how the cursor moves when I click on text. | ||||
* | keep text from overflowing right margin | Kartik K. Agaram | 2022-07-19 | 1 | -36/+33 |
| | | | | | | | | | | I've been sloppy about this so far, and outside of tests I can't find any examples where it matters, but it matters in a potential fork where I'm rendering multiple columns of text. It's unfortunate that my tests have this level of brittleness. What I'd really like to assert in many of these changed lines is that the text stays inside the margins and that more text would overflow margins. | ||||
* | delete some duplicate initialization | Kartik K. Agaram | 2022-07-19 | 1 | -4/+0 |
| | |||||
* | bugfix: couple of margin-relative computations | Kartik K. Agaram | 2022-07-17 | 1 | -1/+61 |
| | |||||
* | separate data structure for each line's cache data | Kartik K. Agaram | 2022-07-17 | 1 | -12/+96 |
| | | | | I have no idea what the performance implications of this are.. | ||||
* | bring back a set of constants | Kartik K. Agaram | 2022-07-16 | 1 | -1/+1 |
| | | | | | It's starting to sink in that I don't want hard-coded constants inside objects. | ||||
* | more decoupling editor tests from App | Kartik K. Agaram | 2022-07-16 | 1 | -1/+1 |
| | |||||
* | more decoupling editor tests from App | Kartik K. Agaram | 2022-07-16 | 1 | -3/+3 |
| | |||||
* | make test initializations a little more obvious | Kartik K. Agaram | 2022-07-15 | 1 | -93/+93 |
| | |||||
* | left/right margin -> left/right coordinates | Kartik K. Agaram | 2022-07-12 | 1 | -121/+214 |
| | | | | | Editor state initialization now depends on window dimensions, so we have to more carefully orchestrate startup. | ||||
* | call edit rather than App callbacks in tests | Kartik K. Agaram | 2022-07-12 | 1 | -101/+101 |
| | |||||
* | start passing in Editor_state explicitly | Kartik K. Agaram | 2022-07-12 | 1 | -76/+77 |
| | | | | | | | | | | | | In this commit, top-level edit functions: - edit.draw - edit.update - edit.quit - edit.mouse_pressed - edit.mouse_released - edit.textinput - edit.keychord_pressed - edit.key_released | ||||
* | initialize contains test state | Kartik K. Agaram | 2022-07-12 | 1 | -87/+0 |
| | |||||
* | group all editor globals | Kartik K. Agaram | 2022-07-12 | 1 | -877/+877 |
| | | | | We're still accessing them through a global. But we'll change that next. | ||||
* | start decoupling editor tests from App | Kartik K. Agaram | 2022-07-11 | 1 | -76/+76 |
| | |||||
* | skip multiple consecutive whitespace | Kartik K. Agaram | 2022-07-11 | 1 | -0/+22 |
| | |||||
* | support other whitespace chars in word movements | Kartik K. Agaram | 2022-07-11 | 1 | -0/+22 |
| | |||||
* | flesh out some tests for word movements | Kartik K. Agaram | 2022-07-11 | 1 | -0/+125 |
| | |||||
* | yet another bugfix in selection management | Kartik K. Agaram | 2022-07-07 | 1 | -18/+1 |
| | | | | | | | | | | Thanks Leonard Schütz for the report! Failing scenario: click to move cursor hit backspace First backspace wasn't being doing anything earlier. | ||||
* | bugfix: clicking on empty lines | Kartik K. Agaram | 2022-07-01 | 1 | -0/+16 |
| | |||||
* | right margin | Kartik K. Agaram | 2022-06-30 | 1 | -0/+71 |
| | |||||
* | rip out notion of Line_width | Kartik K. Agaram | 2022-06-30 | 1 | -84/+17 |
| | |||||
* | bugfix: lines that aren't drawn from the start | Kartik K. Agaram | 2022-06-30 | 1 | -0/+21 |
| | | | | | | | | | | | | | | | I can't believe I didn't catch this until now. All I had to do is open MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout, press page-down and click on the top screen line (or any screen line containing the same line as the top screen line). Easy to catch with any file containing lots of overly long lines, as happens in particular at the start of Moby Dick. I _had_ seen this problem before, but it seemed to disappear after unrelated changes, and I convinced myself I'd fixed it as a side-effect. The bug just failed to manifest if the top line happened to start at the top of the screen. Scroll down a few pages in Moby Dick and the dialogue starts and line length drops precipitously. | ||||
* | some redundant calls | Kartik K. Agaram | 2022-06-30 | 1 | -4/+0 |
| | |||||
* | clicking to the right of a line within line width | Kartik K. Agaram | 2022-06-29 | 1 | -0/+22 |
| | |||||
* | bugfix: clicking past end of screen line | Kartik K. Agaram | 2022-06-29 | 1 | -0/+49 |
| | | | | I could swear I checked this at some point. But I didn't have a test! | ||||
* | bugfix: scrolling in left/right movements | Kartik K. Agaram | 2022-06-28 | 1 | -0/+118 |
| | | | | | I'd always had a funny feeling there was something missing there but somehow never thought of the right failing test. | ||||
* | bugfix: typing a capital letter deletes selection | Kartik K. Agaram | 2022-06-26 | 1 | -0/+22 |
| | |||||
* | bugfix: deleting a selection spanning pages | Kartik K. Agaram | 2022-06-26 | 1 | -0/+25 |
| | |||||
* | bugfix: don't delete selection when moving cursor | Kartik K. Agaram | 2022-06-23 | 1 | -0/+18 |
| | |||||
* | keep drawings within the line width slider as well | Kartik K. Agaram | 2022-06-22 | 1 | -2/+3 |
| | |||||
* | bugfix: delete selection before pasting | Kartik K. Agaram | 2022-06-21 | 1 | -0/+38 |
| | |||||
* | revert selection logic to before commit 3ffc2ed8f | Kartik K. Agaram | 2022-06-20 | 1 | -0/+1 |
| | | | | | We still have a failing test, but now it's the one we introduced in commit 3ffc2ed8f. | ||||
* | snapshot: test for a new regression | Kartik K. Agaram | 2022-06-20 | 1 | -0/+22 |
| | | | | | | Caused by commit 3ffc2ed8f. We might need to bring back a lot of complexity for this. | ||||
* | selection bugfix | Kartik K. Agaram | 2022-06-20 | 1 | -0/+18 |
| | |||||
* | no, that's not right | Kartik K. Agaram | 2022-06-20 | 1 | -0/+22 |
| | | | | | | | | | | | | | | Bugfix: we want selections to persist even when we lift up the shift key. This requires hoisting some code inside every case inside the whole keypress hierarchy, to ensure we never clear selections before textinput events can handle them. Current cross-cutting concerns we're explicitly scattering code for. - autosave - undo - selection management | ||||
* | bugfix: typing should delete highlighted text | Kartik K. Agaram | 2022-06-20 | 1 | -0/+17 |
| | | | | The test harness now also mimics real usage more precisely. | ||||
* | bugfix | Kartik K. Agaram | 2022-06-19 | 1 | -0/+18 |
| | | | | | | | | | | | | | | | To reproduce: click to position cursor at end of a line hit enter press any key before: newline got erased and key got added to previous line now: newline is preserved The new test checks a generalization of this. |